projects / openssl.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: db78c84) | patch
engine: fix double free on error path.
authorPauli <pauli@openssl.org>
Sun, 18 Apr 2021 22:57:18 +0000 (08:57 +1000)
committerPauli <pauli@openssl.org>
Tue, 20 Apr 2021 23:17:22 +0000 (09:17 +1000)
commitefe8d69daa1a68be0a7f0f73220947c848e7ed1d
tree50ab5910e13006a82ce9f6edd684ca822da9a667tree | snapshot
parentdb78c84eb2fa9c41124690bcc2ea50e05f5fc7b7commit | diff
engine: fix double free on error path.

In function try_decode_PKCS8Encrypted, p8 is freed via X509_SIG_free() at line 481.
If function new_EMBEDDED() returns a null pointer at line 483, the execution will goto nop8.
In the nop8 branch, p8 is freed again at line 491.

Bug reported by @Yunlongs

Fixes #14915

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14921)
engines/e_loader_attic.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.