Make DH_check set some error bits in recently added error
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Sun, 23 Jul 2023 12:27:54 +0000 (14:27 +0200)
committerBernd Edlinger <bernd.edlinger@hotmail.de>
Wed, 26 Jul 2023 11:23:15 +0000 (13:23 +0200)
commiteec805ee71356c06f9a86192fa06507c3bb92b09
treebe8af93a9091ff10e6b085e421d1166d504a9398
parent97b4f2b515ffd3ce91c6d5cd6d04614a4a15d7df
Make DH_check set some error bits in recently added error

The pre-existing error cases where DH_check returned zero
are not related to the dh params in any way, but are only
triggered by out-of-memory errors, therefore having *ret
set to zero feels right, but since the new error case is
triggered by too large p values that is something different.
On the other hand some callers of this function might not
be prepared to handle the return value correctly but only
rely on *ret. Therefore we set some error bits in *ret as
additional safety measure.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21533)
crypto/dh/dh_check.c