Remove erroneous server_random filling
authorMatt Caswell <matt@openssl.org>
Thu, 25 Jun 2015 13:12:25 +0000 (14:12 +0100)
committerMatt Caswell <matt@openssl.org>
Fri, 31 Jul 2015 19:30:35 +0000 (20:30 +0100)
commite1e088ec7f2f33c4c4ad31312d62c536441d4358
tree1d7281cf2ebcbc34ac1d25ab98159622dfbdebd0
parent1a586b3942de1c0bd64203d09385d5e74f499d8d
Remove erroneous server_random filling

Commit e481f9b90b164 removed OPENSSL_NO_TLSEXT from the code.

Previously if OPENSSL_NO_TLSEXT *was not* defined then the server random was
filled during getting of the ClientHello. If it *was* defined then the
server random would be filled in ssl3_send_server_hello(). Unfortunately in
commit e481f9b90b164 the OPENSSL_NO_TLSEXT guards were removed but *both*
server random fillings were left in. This could cause problems for session
ticket callbacks.

Reviewed-by: Stephen Henson <steve@openssl.org>
ssl/s3_srvr.c