QUIC: Note that we do not retransmit stream data for retransmitted st…

…reams Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #21135)
openssl · Jul 16, 2023 · c407d5e · c407d5e
1 parent 28d0e35
commit c407d5e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ssl/quic/quic_fifd.c b/ssl/quic/quic_fifd.c
@@ -124,6 +124,12 @@ static void on_lost(void *arg)
         sstream_updated = 0;
 
         if (chunks[i].end >= chunks[i].start) {
+            /*
+             * Note: If the stream is being reset, we do not need to retransmit
+             * old data as this is pointless. In this case this will be handled
+             * by (sstream == NULL) above as the QSM will free the QUIC_SSTREAM
+             * and our call to get_sstream_by_id above will return NULL.
+             */
             ossl_quic_sstream_mark_lost(sstream,
                                         chunks[i].start, chunks[i].end);
             sstream_updated = 1;