BIO_s_connect: add an error state and use it
authorRichard Levitte <levitte@openssl.org>
Tue, 13 Nov 2018 14:17:21 +0000 (15:17 +0100)
committerRichard Levitte <levitte@openssl.org>
Sat, 2 Nov 2019 09:44:27 +0000 (10:44 +0100)
commit181f5185ee750291c15c4e83fd315c46a07a9aa3
tree8624ad8af6a33e64f1fb199e37d82d72b86aaa23
parent5d0cf102e038013d6d89ea406562b52f73a67bdd
BIO_s_connect: add an error state and use it

If no connection could be made, addr_iter will eventually end up being
NULL, and if the user didn't check the returned error value, the
BIO_CONN_S_CONNECT code will be performed again and will crash.

So instead, we add a state BIO_CONN_S_CONNECT_ERROR that we enter into
when we run out of addresses to try.  That state will just simply say
"error" back, until the user does something better with the BIO, such
as free it or reset it.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7630)
crypto/bio/bss_conn.c