Revert "Improved detection of engine-provided private "classic" keys"
authorTomas Mraz <tomas@openssl.org>
Fri, 15 Dec 2023 12:45:50 +0000 (13:45 +0100)
committerTomas Mraz <tomas@openssl.org>
Wed, 31 Jan 2024 17:41:10 +0000 (18:41 +0100)
commit0058a55407d824d5b55ecc0a1cbf8931803dc238
treec00b6c78ad1bac70f8715e349cbf6f91c9eadf1c
parent8d60a4f1da13199c727cbc21a9bb807f02509985
Revert "Improved detection of engine-provided private "classic" keys"

This reverts commit 2b74e75331a27fc89cad9c8ea6a26c70019300b5.

The commit was wrong. With 3.x versions the engines must be themselves
responsible for creating their EVP_PKEYs in a way that they are treated
as legacy - either by using the respective set1 calls or by setting
non-default EVP_PKEY_METHOD.

The workaround has caused more problems than it solved.

Fixes #22945

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23063)

(cherry picked from commit 39ea78379826fa98e8dc8c0d2b07e2c17cd68380)
crypto/engine/eng_pkey.c