THREADING: Make CRYPTO_MUTEX and CRYPTO_CONDVAR typesafe
authorHugo Landau <hlandau@openssl.org>
Thu, 8 Feb 2024 10:27:56 +0000 (10:27 +0000)
committerTomas Mraz <tomas@openssl.org>
Fri, 9 Feb 2024 13:10:17 +0000 (14:10 +0100)
commit62cb7c810e882895a71ba2cc479f482df0aa8e32
tree835ecd73332006d90857245d1e713f5a8739d6f9
parentd8d19107618dd89c4584996b2bbed32b983d3890
THREADING: Make CRYPTO_MUTEX and CRYPTO_CONDVAR typesafe

There was really no need for this to be void and it made bugs very easy
to introduce accidentally, especially given that the free functions
needed to be passed a pointer to the pointer.

Also fix some bugs in the QUIC code detected immediately by this change.

.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23519)
include/internal/quic_reactor.h
include/internal/thread_arch.h
ssl/quic/quic_impl.c
ssl/quic/quic_thread_assist.c