X-Git-Url: https://git.openssl.org/gitweb/?p=openssl.git;a=blobdiff_plain;f=test%2Fevp_test.c;h=b6a7c28e3bea3e5641fc2203ea93e6f778415e8c;hp=9dfd4a171991da33ebb9b75268a44d1326aba9d7;hb=fb3ae0e830097a3a2a41a0ea82c7ad725f05a451;hpb=cce65266299e2e89303a90c131e8171225a1bf88 diff --git a/test/evp_test.c b/test/evp_test.c index 9dfd4a1719..b6a7c28e3b 100644 --- a/test/evp_test.c +++ b/test/evp_test.c @@ -210,6 +210,10 @@ struct evp_test { const char *err, *aux_err; /* Expected error value of test */ char *expected_err; + /* Expected error function string */ + char *func; + /* Expected error reason string */ + char *reason; /* Number of tests */ int ntests; /* Error count */ @@ -296,6 +300,10 @@ static void free_expected(struct evp_test *t) { OPENSSL_free(t->expected_err); t->expected_err = NULL; + OPENSSL_free(t->func); + t->func = NULL; + OPENSSL_free(t->reason); + t->reason = NULL; OPENSSL_free(t->out_expected); OPENSSL_free(t->out_received); t->out_expected = NULL; @@ -317,6 +325,9 @@ static void print_expected(struct evp_test *t) static int check_test_error(struct evp_test *t) { + unsigned long err; + const char *func; + const char *reason; if (!t->err && !t->expected_err) return 1; if (t->err && !t->expected_err) { @@ -335,11 +346,44 @@ static int check_test_error(struct evp_test *t) t->start_line, t->expected_err); return 0; } - if (strcmp(t->err, t->expected_err) == 0) + + if (strcmp(t->err, t->expected_err) != 0) { + fprintf(stderr, "Test line %d: expecting %s got %s\n", + t->start_line, t->expected_err, t->err); + return 0; + } + + if (t->func == NULL && t->reason == NULL) + return 1; + + if (t->func == NULL || t->reason == NULL) { + fprintf(stderr, "Test line %d: missing function or reason code\n", + t->start_line); + return 0; + } + + err = ERR_peek_error(); + if (err == 0) { + fprintf(stderr, "Test line %d, expected error \"%s:%s\" not set\n", + t->start_line, t->func, t->reason); + return 0; + } + + func = ERR_func_error_string(err); + reason = ERR_reason_error_string(err); + + if (func == NULL && reason == NULL) { + fprintf(stderr, "Test line %d: expected error \"%s:%s\", no strings available. Skipping...\n", + t->start_line, t->func, t->reason); + return 1; + } + + if (strcmp(func, t->func) == 0 && strcmp(reason, t->reason) == 0) return 1; - fprintf(stderr, "Test line %d: expecting %s got %s\n", - t->start_line, t->expected_err, t->err); + fprintf(stderr, "Test line %d: expected error \"%s:%s\", got \"%s:%s\"\n", + t->start_line, t->func, t->reason, func, reason); + return 0; } @@ -494,7 +538,23 @@ static int process_test(struct evp_test *t, char *buf, int verbose) return 0; } t->expected_err = OPENSSL_strdup(value); - if (!t->expected_err) + if (t->expected_err == NULL) + return 0; + } else if (strcmp(keyword, "Function") == 0) { + if (t->func != NULL) { + fprintf(stderr, "Line %d: multiple function lines\n", t->line); + return 0; + } + t->func = OPENSSL_strdup(value); + if (t->func == NULL) + return 0; + } else if (strcmp(keyword, "Reason") == 0) { + if (t->reason != NULL) { + fprintf(stderr, "Line %d: multiple reason lines\n", t->line); + return 0; + } + t->reason = OPENSSL_strdup(value); + if (t->reason == NULL) return 0; } else { /* Must be test specific line: try to parse it */