Use separate arrays for certificate verify and for finished hashes.
[openssl.git] / ssl / s3_srvr.c
index ebff57506ffbde523024b7686b7db10dca506c3e..9e08b75ee313cebeef7d3c323589ba138c69ec21 100644 (file)
@@ -1,5 +1,5 @@
 /* ssl/s3_srvr.c */
-/* Copyright (C) 1995-1997 Eric Young (eay@cryptsoft.com)
+/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
  * This package is an SSL implementation written
 #define REUSE_CIPHER_BUG
 
 #include <stdio.h>
-#include "buffer.h"
-#include "rand.h"
-#include "objects.h"
-#include "evp.h"
-#include "x509.h"
+#include <openssl/buffer.h>
+#include <openssl/rand.h>
+#include <openssl/objects.h>
+#include <openssl/md5.h>
+#include <openssl/sha.h>
+#include <openssl/evp.h>
+#include <openssl/x509.h>
 #include "ssl_locl.h"
 
-#define BREAK  break
-/* SSLerr(SSL_F_SSL3_ACCEPT,ERR_R_MALLOC_FAILURE);
- * SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,ERR_R_MALLOC_FAILURE);
- * SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,ERR_R_MALLOC_FAILURE);
- * SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,ERR_R_MALLOC_FAILURE);
- * SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,ERR_R_MALLOC_FAILURE);
- */
-
-#ifndef NOPROTO
+static SSL_METHOD *ssl3_get_server_method(int ver);
 static int ssl3_get_client_hello(SSL *s);
+static int ssl3_check_client_hello(SSL *s);
 static int ssl3_send_server_hello(SSL *s);
 static int ssl3_send_server_key_exchange(SSL *s);
 static int ssl3_send_certificate_request(SSL *s);
@@ -85,61 +80,42 @@ static int ssl3_get_client_key_exchange(SSL *s);
 static int ssl3_get_client_certificate(SSL *s);
 static int ssl3_send_hello_request(SSL *s);
 
-#else
-
-static int ssl3_get_client_hello();
-static int ssl3_send_server_hello();
-static int ssl3_send_server_key_exchange();
-static int ssl3_send_certificate_request();
-static int ssl3_send_server_done();
-static int ssl3_get_cert_verify();
-static int ssl3_get_client_key_exchange();
-static int ssl3_get_client_certificate();
-static int ssl3_send_hello_request();
-static SSL_METHOD *ssl3_get_server_method();
-
-#endif
-
-static SSL_METHOD *ssl3_get_server_method(ver)
-int ver;
+static SSL_METHOD *ssl3_get_server_method(int ver)
        {
-       if (ver == 3)
+       if (ver == SSL3_VERSION)
                return(SSLv3_server_method());
        else
                return(NULL);
        }
 
-SSL_METHOD *SSLv3_server_method()
+SSL_METHOD *SSLv3_server_method(void)
        {
        static int init=1;
        static SSL_METHOD SSLv3_server_data;
 
        if (init)
                {
-               init=0;
                memcpy((char *)&SSLv3_server_data,(char *)sslv3_base_method(),
                        sizeof(SSL_METHOD));
                SSLv3_server_data.ssl_accept=ssl3_accept;
                SSLv3_server_data.get_ssl_method=ssl3_get_server_method;
+               init=0;
                }
        return(&SSLv3_server_data);
        }
 
-int ssl3_accept(s)
-SSL *s;
+int ssl3_accept(SSL *s)
        {
        BUF_MEM *buf;
        unsigned long l,Time=time(NULL);
        void (*cb)()=NULL;
        long num1;
        int ret= -1;
-       CERT *ct;
-       BIO *bbio,*under;
        int new_state,state,skip=0;
 
-       RAND_seed((unsigned char *)&Time,sizeof(Time));
+       RAND_seed(&Time,sizeof(Time));
        ERR_clear_error();
-       errno=0;
+       clear_sys_error();
 
        if (s->info_callback != NULL)
                cb=s->info_callback;
@@ -150,17 +126,11 @@ SSL *s;
        if (!SSL_in_init(s) || SSL_in_before(s)) SSL_clear(s);
        s->in_handshake++;
 
-#ifdef undef
-       /* FIX THIS EAY EAY EAY */
-       /* we don't actually need a cert, we just need a cert or a DH_tmp */
-       if (((s->session == NULL) || (s->session->cert == NULL)) &&
-               (s->cert == NULL))
+       if (s->cert == NULL)
                {
                SSLerr(SSL_F_SSL3_ACCEPT,SSL_R_NO_CERTIFICATE_SET);
-               ret= -1;
-               goto end;
+               return(-1);
                }
-#endif
 
        for (;;)
                {
@@ -172,14 +142,18 @@ SSL *s;
                        s->new_session=1;
                        /* s->state=SSL_ST_ACCEPT; */
 
+               case SSL3_ST_SR_MS_SGC:
                case SSL_ST_BEFORE:
                case SSL_ST_ACCEPT:
                case SSL_ST_BEFORE|SSL_ST_ACCEPT:
                case SSL_ST_OK|SSL_ST_ACCEPT:
 
+                       s->server=1;
                        if (cb != NULL) cb(s,SSL_CB_HANDSHAKE_START,1);
 
-                       s->version=3;
+                       if ((s->version>>8) != 3)
+                               abort();
+                       /* s->version=SSL3_VERSION; */
                        s->type=SSL_ST_ACCEPT;
 
                        if (s->init_buf == NULL)
@@ -206,39 +180,19 @@ SSL *s;
                        /* Ok, we now need to push on a buffering BIO so that
                         * the output is sent in a way that TCP likes :-)
                         */
-                       if (s->bbio == NULL)
-                               {
-                               bbio=BIO_new(BIO_f_buffer());
-                               if (bbio == NULL)
-                                       {
-                                       SSLerr(SSL_F_SSL3_ACCEPT,ERR_LIB_BUF);
-                                       ret= -1;
-                                       goto end;
-                                       }
-                               s->bbio=bbio;
-                               }
-                       else
-                               bbio=s->bbio;
-                       BIO_reset(bbio);
-                       if (!BIO_set_write_buffer_size(bbio,16*1024))
-                               {
-                               SSLerr(SSL_F_SSL3_ACCEPT,ERR_LIB_BUF);
-                               ret= -1;
-                               goto end;
-                               }
+                       if (!ssl_init_wbio_buffer(s,1)) { ret= -1; goto end; }
 
-                       s->wbio=BIO_push(bbio,s->wbio);
-
-                       s->ctx->sess_accept++;
                        s->init_num=0;
 
                        if (s->state != SSL_ST_RENEGOTIATE)
                                {
+                               if(s->state != SSL3_ST_SR_MS_SGC) ssl3_init_finished_mac(s);
                                s->state=SSL3_ST_SR_CLNT_HELLO_A;
-                               ssl3_init_finished_mac(s);
+                               s->ctx->stats.sess_accept++;
                                }
                        else
                                {
+                               s->ctx->stats.sess_accept_renegotiate++;
                                s->state=SSL3_ST_SW_HELLO_REQ_A;
                                }
                        break;
@@ -257,19 +211,10 @@ SSL *s;
                        break;
 
                case SSL3_ST_SW_HELLO_REQ_C:
-                       /* remove buffering on output */
-                       under=BIO_pop(s->wbio);
-                       if (under != NULL)
-                               s->wbio=under;
-                       else
-                               abort(); /* ok */
-                       BIO_free(s->bbio);
-                       s->bbio=NULL;
-
                        s->state=SSL_ST_OK;
                        ret=1;
                        goto end;
-                       break;
+                       /* break; */
 
                case SSL3_ST_SR_CLNT_HELLO_A:
                case SSL3_ST_SR_CLNT_HELLO_B:
@@ -311,40 +256,26 @@ SSL *s;
                case SSL3_ST_SW_KEY_EXCH_A:
                case SSL3_ST_SW_KEY_EXCH_B:
                        l=s->s3->tmp.new_cipher->algorithms;
-                       if (s->session->cert == NULL)
-                               {
-                               if (s->cert != NULL)
-                                       {
-                                       CRYPTO_add(&s->cert->references,1,CRYPTO_LOCK_SSL_CERT);
-                                       s->session->cert=s->cert;
-                                       }
-                               else
-                                       {
-                                       CRYPTO_add(&s->ctx->default_cert->references,1,CRYPTO_LOCK_SSL_CERT);
-                                       s->session->cert=s->ctx->default_cert;
-                                       }
-                               }
-                       ct=s->session->cert;
 
                        /* clear this, it may get reset by
                         * send_server_key_exchange */
-                       if (s->ctx->options & SSL_OP_EPHEMERAL_RSA)
+                       if (s->options & SSL_OP_EPHEMERAL_RSA)
                                s->s3->tmp.use_rsa_tmp=1;
                        else
                                s->s3->tmp.use_rsa_tmp=0;
 
                        /* only send if a DH key exchange, fortezza or
                         * RSA but we have a sign only certificate */
-                       if ( s->s3->tmp.use_rsa_tmp ||
-                           (l & (SSL_DH|SSL_kFZA)) ||
-                           ((l & SSL_kRSA) &&
-                            ((ct->pkeys[SSL_PKEY_RSA_ENC].privatekey == NULL)||
-                             ((l & SSL_EXPORT) &&
-                              (EVP_PKEY_size(ct->pkeys[SSL_PKEY_RSA_ENC].privatekey)*8 > 512)
-                             )
-                            )
+                       if (s->s3->tmp.use_rsa_tmp
+                           || (l & (SSL_DH|SSL_kFZA))
+                           || ((l & SSL_kRSA)
+                               && (s->cert->pkeys[SSL_PKEY_RSA_ENC].privatekey == NULL
+                                   || (SSL_IS_EXPORT(l)
+                                       && EVP_PKEY_size(s->cert->pkeys[SSL_PKEY_RSA_ENC].privatekey)*8 > SSL_EXPORT_PKEYLENGTH(l)
+                                       )
+                                   )
+                               )
                            )
-                          )
                                {
                                ret=ssl3_send_server_key_exchange(s);
                                if (ret <= 0) goto end;
@@ -358,16 +289,28 @@ SSL *s;
 
                case SSL3_ST_SW_CERT_REQ_A:
                case SSL3_ST_SW_CERT_REQ_B:
-                       if (!(s->verify_mode & SSL_VERIFY_PEER) ||
+                       if (/* don't request cert unless asked for it: */
+                               !(s->verify_mode & SSL_VERIFY_PEER) ||
+                               /* if SSL_VERIFY_CLIENT_ONCE is set,
+                                * don't request cert during re-negotiation: */
                                ((s->session->peer != NULL) &&
-                                (s->verify_mode & SSL_VERIFY_CLIENT_ONCE)))
+                                (s->verify_mode & SSL_VERIFY_CLIENT_ONCE)) ||
+                               /* never request cert in anonymous ciphersuites
+                                * (see section "Certificate request" in SSL 3 drafts
+                                * and in RFC 2246): */
+                               ((s->s3->tmp.new_cipher->algorithms & SSL_aNULL) &&
+                                /* ... except when the application insists on verification
+                                 * (against the specs, but s3_clnt.c accepts this for SSL 3) */
+                                !(s->verify_mode & SSL_VERIFY_FAIL_IF_NO_PEER_CERT)))
                                {
                                /* no cert request */
                                skip=1;
+                               s->s3->tmp.cert_request=0;
                                s->state=SSL3_ST_SW_SRVR_DONE_A;
                                }
                        else
                                {
+                               s->s3->tmp.cert_request=1;
                                ret=ssl3_send_certificate_request(s);
                                if (ret <= 0) goto end;
                                s->state=SSL3_ST_SW_SRVR_DONE_A;
@@ -400,12 +343,18 @@ SSL *s;
 
                case SSL3_ST_SR_CERT_A:
                case SSL3_ST_SR_CERT_B:
-                       /* could be sent for a DH cert, even if we
-                        * have not asked for it :-) */
-                       ret=ssl3_get_client_certificate(s);
-                       if (ret <= 0) goto end;
-                       s->init_num=0;
-                       s->state=SSL3_ST_SR_KEY_EXCH_A;
+                       /* Check for second client hello if MS SGC */
+                       ret = ssl3_check_client_hello(s);
+                       if(ret <= 0) goto end;
+                       if(ret == 2) s->state = SSL3_ST_SR_MS_SGC;
+                       else {
+                               /* could be sent for a DH cert, even if we
+                                * have not asked for it :-) */
+                               ret=ssl3_get_client_certificate(s);
+                               if (ret <= 0) goto end;
+                               s->init_num=0;
+                               s->state=SSL3_ST_SR_KEY_EXCH_A;
+                       }
                        break;
 
                case SSL3_ST_SR_KEY_EXCH_A:
@@ -417,10 +366,12 @@ SSL *s;
 
                        /* We need to get hashes here so if there is
                         * a client cert, it can be verified */ 
-                       ssl3_final_finish_mac(s,&(s->s3->finish_dgst1),
-                               NULL,&(s->s3->tmp.finish_md1[0]));
-                       ssl3_final_finish_mac(s,&(s->s3->finish_dgst2),
-                               NULL,&(s->s3->tmp.finish_md2[0]));
+                       s->method->ssl3_enc->cert_verify_mac(s,
+                               &(s->s3->finish_dgst1),
+                               &(s->s3->tmp.cert_verify_md[0]));
+                       s->method->ssl3_enc->cert_verify_mac(s,
+                               &(s->s3->finish_dgst2),
+                               &(s->s3->tmp.cert_verify_md[MD5_DIGEST_LENGTH]));
 
                        break;
 
@@ -438,8 +389,7 @@ SSL *s;
                case SSL3_ST_SR_FINISHED_A:
                case SSL3_ST_SR_FINISHED_B:
                        ret=ssl3_get_finished(s,SSL3_ST_SR_FINISHED_A,
-                               SSL3_ST_SR_FINISHED_B,
-                               &(ssl3_client_finished_const[0]));
+                               SSL3_ST_SR_FINISHED_B);
                        if (ret <= 0) goto end;
                        if (s->hit)
                                s->state=SSL_ST_OK;
@@ -452,7 +402,8 @@ SSL *s;
                case SSL3_ST_SW_CHANGE_B:
 
                        s->session->cipher=s->s3->tmp.new_cipher;
-                       if (!ssl3_setup_key_block(s)) { ret= -1; goto end; }
+                       if (!s->method->ssl3_enc->setup_key_block(s))
+                               { ret= -1; goto end; }
 
                        ret=ssl3_send_change_cipher_spec(s,
                                SSL3_ST_SW_CHANGE_A,SSL3_ST_SW_CHANGE_B);
@@ -461,7 +412,7 @@ SSL *s;
                        s->state=SSL3_ST_SW_FINISHED_A;
                        s->init_num=0;
 
-                       if (!ssl3_change_cipher_state(s,
+                       if (!s->method->ssl3_enc->change_cipher_state(s,
                                SSL3_CHANGE_CIPHER_SERVER_WRITE))
                                {
                                ret= -1;
@@ -474,7 +425,8 @@ SSL *s;
                case SSL3_ST_SW_FINISHED_B:
                        ret=ssl3_send_finished(s,
                                SSL3_ST_SW_FINISHED_A,SSL3_ST_SW_FINISHED_B,
-                               &(ssl3_server_finished_const[0]));
+                               s->method->ssl3_enc->server_finished_label,
+                               s->method->ssl3_enc->server_finished_label_len);
                        if (ret <= 0) goto end;
                        s->state=SSL3_ST_SW_FLUSH;
                        if (s->hit)
@@ -492,20 +444,14 @@ SSL *s;
                        s->init_buf=NULL;
 
                        /* remove buffering on output */
-                       under=BIO_pop(s->wbio);
-                       if (under != NULL)
-                               s->wbio=under;
-                       else
-                               abort(); /* ok */
-                       BIO_free(s->bbio);
-                       s->bbio=NULL;
+                       ssl_free_wbio_buffer(s);
 
                        s->new_session=0;
                        s->init_num=0;
 
                        ssl_update_cache(s,SSL_SESS_CACHE_SERVER);
 
-                       s->ctx->sess_accept_good++;
+                       s->ctx->stats.sess_accept_good++;
                        /* s->server=1; */
                        s->handshake_func=ssl3_accept;
                        ret=1;
@@ -513,18 +459,23 @@ SSL *s;
                        if (cb != NULL) cb(s,SSL_CB_HANDSHAKE_DONE,1);
 
                        goto end;
-                       break;
+                       /* break; */
 
                default:
                        SSLerr(SSL_F_SSL3_ACCEPT,SSL_R_UNKNOWN_STATE);
                        ret= -1;
                        goto end;
-                       break;
+                       /* break; */
                        }
                
                if (!s->s3->tmp.reuse_message && !skip)
                        {
-                       if (s->debug) BIO_flush(s->wbio);
+                       if (s->debug)
+                               {
+                               if ((ret=BIO_flush(s->wbio)) <= 0)
+                                       goto end;
+                               }
+
 
                        if ((cb != NULL) && (s->state != state))
                                {
@@ -545,8 +496,7 @@ end:
        return(ret);
        }
 
-static int ssl3_send_hello_request(s)
-SSL *s;
+static int ssl3_send_hello_request(SSL *s)
        {
        unsigned char *p;
 
@@ -568,16 +518,39 @@ SSL *s;
        return(ssl3_do_write(s,SSL3_RT_HANDSHAKE));
        }
 
-static int ssl3_get_client_hello(s)
-SSL *s;
+static int ssl3_check_client_hello(SSL *s)
+       {
+       int ok;
+       long n;
+
+       n=ssl3_get_message(s,
+               SSL3_ST_SR_CERT_A,
+               SSL3_ST_SR_CERT_B,
+               -1,
+               SSL3_RT_MAX_PLAIN_LENGTH,
+               &ok);
+       if (!ok) return((int)n);
+       s->s3->tmp.reuse_message = 1;
+       if(s->s3->tmp.message_type == SSL3_MT_CLIENT_HELLO) return 2;
+       return 1;
+}
+
+static int ssl3_get_client_hello(SSL *s)
        {
        int i,j,ok,al,ret= -1;
        long n;
        unsigned long id;
-       unsigned char *p,*d;
+       unsigned char *p,*d,*q;
        SSL_CIPHER *c;
-       STACK *ciphers=NULL;
-
+       SSL_COMP *comp=NULL;
+       STACK_OF(SSL_CIPHER) *ciphers=NULL;
+
+       /* We do this so that we will respond with our native type.
+        * If we are TLSv1 and we get SSLv3, we will respond with TLSv1,
+        * This down switching should be handled by a different method.
+        * If we are SSLv3, we will respond with SSLv3, even if prompted with
+        * TLSv1.
+        */
        if (s->state == SSL3_ST_SR_CLNT_HELLO_A)
                {
                s->first_packet=1;
@@ -593,11 +566,9 @@ SSL *s;
        if (!ok) return((int)n);
        d=p=(unsigned char *)s->init_buf->data;
 
-       if (p[0] != SSL3_VERSION_MAJOR)
-               {
-               SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_WRONG_SSL_VERSION);
-               goto err;
-               }
+       /* use version from inside client hello, not from record header
+        * (may differ: see RFC 2246, Appendix E, second paragraph) */
+       s->client_version=(((int)p[0])<<8)|(int)p[1];
        p+=2;
 
        /* load the client random */
@@ -615,12 +586,14 @@ SSL *s;
                }
        else
                {
-               i=ssl_get_prev_session(s,j,p);
+               i=ssl_get_prev_session(s,p,j);
                if (i == 1)
                        { /* previous session */
                        s->hit=1;
                        }
-               else
+               else if (i == -1)
+                       goto err;
+               else /* i == 0 */
                        {
                        if (!ssl_get_new_session(s,1))
                                goto err;
@@ -632,14 +605,14 @@ SSL *s;
        if ((i == 0) && (j != 0))
                {
                /* we need a cipher if we are not resuming a session */
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_ILLEGAL_PARAMETER;
                SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_NO_CIPHERS_SPECIFIED);
                goto f_err;
                }
        if ((i+p) > (d+n))
                {
                /* not enough data */
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_DECODE_ERROR;
                SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_LENGTH_MISMATCH);
                goto f_err;
                }
@@ -656,9 +629,16 @@ SSL *s;
                j=0;
                id=s->session->cipher->id;
 
-               for (i=0; i<sk_num(ciphers); i++)
+#ifdef CIPHER_DEBUG
+               printf("client sent %d ciphers\n",sk_num(ciphers));
+#endif
+               for (i=0; i<sk_SSL_CIPHER_num(ciphers); i++)
                        {
-                       c=(SSL_CIPHER *)sk_value(ciphers,i);
+                       c=sk_SSL_CIPHER_value(ciphers,i);
+#ifdef CIPHER_DEBUG
+                       printf("client [%2d of %2d]:%s\n",
+                               i,sk_num(ciphers),SSL_CIPHER_get_name(c));
+#endif
                        if (c->id == id)
                                {
                                j=1;
@@ -667,17 +647,17 @@ SSL *s;
                        }
                if (j == 0)
                        {
-                       if ((s->ctx->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_num(ciphers) == 1))
+                       if ((s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_SSL_CIPHER_num(ciphers) == 1))
                                {
                                /* Very bad for multi-threading.... */
-                               s->session->cipher=
-                                       (SSL_CIPHER *)sk_value(ciphers,0);
+                               s->session->cipher=sk_SSL_CIPHER_value(ciphers,
+                                                                      0);
                                }
                        else
                                {
                                /* we need to have the cipher in the cipher
                                 * list if we are asked to reuse it */
-                               al=SSL3_AD_ILLEGAL_PARAMETER;
+                               al=SSL_AD_ILLEGAL_PARAMETER;
                                SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_REQUIRED_CIPHER_MISSING);
                                goto f_err;
                                }
@@ -686,50 +666,85 @@ SSL *s;
 
        /* compression */
        i= *(p++);
+       q=p;
        for (j=0; j<i; j++)
+               {
                if (p[j] == 0) break;
+               }
 
        p+=i;
        if (j >= i)
                {
                /* no compress */
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_DECODE_ERROR;
                SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_NO_COMPRESSION_SPECIFIED);
                goto f_err;
                }
 
-       if (p > (d+n))
-               {
-               /* wrong number of bytes,
-                * there could be more to follow */
-               al=SSL3_AD_ILLEGAL_PARAMETER;
-               SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_LENGTH_MISMATCH);
-               goto f_err;
+       /* Worst case, we will use the NULL compression, but if we have other
+        * options, we will now look for them.  We have i-1 compression
+        * algorithms from the client, starting at q. */
+       s->s3->tmp.new_compression=NULL;
+       if (s->ctx->comp_methods != NULL)
+               { /* See if we have a match */
+               int m,nn,o,v,done=0;
+
+               nn=sk_SSL_COMP_num(s->ctx->comp_methods);
+               for (m=0; m<nn; m++)
+                       {
+                       comp=sk_SSL_COMP_value(s->ctx->comp_methods,m);
+                       v=comp->id;
+                       for (o=0; o<i; o++)
+                               {
+                               if (v == q[o])
+                                       {
+                                       done=1;
+                                       break;
+                                       }
+                               }
+                       if (done) break;
+                       }
+               if (done)
+                       s->s3->tmp.new_compression=comp;
+               else
+                       comp=NULL;
                }
 
-       /* do nothing with compression */
+       /* TLS does not mind if there is extra stuff */
+       if (s->version == SSL3_VERSION)
+               {
+               if (p > (d+n))
+                       {
+                       /* wrong number of bytes,
+                        * there could be more to follow */
+                       al=SSL_AD_DECODE_ERROR;
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_LENGTH_MISMATCH);
+                       goto f_err;
+                       }
+               }
 
        /* Given s->session->ciphers and ssl_get_ciphers_by_id(s), we must
         * pick a cipher */
 
        if (!s->hit)
                {
+               s->session->compress_meth=(comp == NULL)?0:comp->id;
                if (s->session->ciphers != NULL)
-                       sk_free(s->session->ciphers);
+                       sk_SSL_CIPHER_free(s->session->ciphers);
                s->session->ciphers=ciphers;
                if (ciphers == NULL)
                        {
-                       al=SSL3_AD_HANDSHAKE_FAILURE;
+                       al=SSL_AD_ILLEGAL_PARAMETER;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_NO_CIPHERS_PASSED);
                        goto f_err;
                        }
                ciphers=NULL;
                c=ssl3_choose_cipher(s,s->session->ciphers,
-                       ssl_get_ciphers_by_id(s));
+                                    ssl_get_ciphers_by_id(s));
 
                if (c == NULL)
                        {
-                       al=SSL3_AD_HANDSHAKE_FAILURE;
+                       al=SSL_AD_HANDSHAKE_FAILURE;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO,SSL_R_NO_SHARED_CIPHER);
                        goto f_err;
                        }
@@ -739,19 +754,19 @@ SSL *s;
                {
                /* Session-id reuse */
 #ifdef REUSE_CIPHER_BUG
-               STACK *sk;
+               STACK_OF(SSL_CIPHER) *sk;
                SSL_CIPHER *nc=NULL;
                SSL_CIPHER *ec=NULL;
 
-               if (s->ctx->options & SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG)
+               if (s->options & SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG)
                        {
                        sk=s->session->ciphers;
-                       for (i=0; i<sk_num(sk); i++)
+                       for (i=0; i<sk_SSL_CIPHER_num(sk); i++)
                                {
-                               c=(SSL_CIPHER *)sk_value(sk,i);
+                               c=sk_SSL_CIPHER_value(sk,i);
                                if (c->algorithms & SSL_eNULL)
                                        nc=c;
-                               if (c->algorithms & SSL_EXP)
+                               if (SSL_C_IS_EXPORT(c))
                                        ec=c;
                                }
                        if (nc != NULL)
@@ -784,12 +799,11 @@ f_err:
                ssl3_send_alert(s,SSL3_AL_FATAL,al);
                }
 err:
-       if (ciphers != NULL) sk_free(ciphers);
+       if (ciphers != NULL) sk_SSL_CIPHER_free(ciphers);
        return(ret);
        }
 
-static int ssl3_send_server_hello(s)
-SSL *s;
+static int ssl3_send_server_hello(SSL *s)
        {
        unsigned char *buf;
        unsigned char *p,*d;
@@ -806,8 +820,8 @@ SSL *s;
                /* Do the message type and length last */
                d=p= &(buf[4]);
 
-               *(p++)=SSL3_VERSION_MAJOR;
-               *(p++)=SSL3_VERSION_MINOR;
+               *(p++)=s->version>>8;
+               *(p++)=s->version&0xff;
 
                /* Random stuff */
                memcpy(p,s->s3->server_random,SSL3_RANDOM_SIZE);
@@ -819,7 +833,10 @@ SSL *s;
                 * back the new session-id or we send back a 0 length
                 * session-id if we want it to be single use.
                 * Currently I will not implement the '0' length session-id
+                * 12-Jan-98 - I'll now support the '0' length stuff.
                 */
+               if (!(s->ctx->session_cache_mode & SSL_SESS_CACHE_SERVER))
+                       s->session->session_id_length=0;
 
                sl=s->session->session_id_length;
                *(p++)=sl;
@@ -831,7 +848,10 @@ SSL *s;
                p+=i;
 
                /* put the compression method */
-               *(p++)=0;
+               if (s->s3->tmp.new_compression == NULL)
+                       *(p++)=0;
+               else
+                       *(p++)=s->s3->tmp.new_compression->id;
 
                /* do the header */
                l=(p-d);
@@ -849,8 +869,7 @@ SSL *s;
        return(ssl3_do_write(s,SSL3_RT_HANDSHAKE));
        }
 
-static int ssl3_send_server_done(s)
-SSL *s;
+static int ssl3_send_server_done(SSL *s)
        {
        unsigned char *p;
 
@@ -874,8 +893,7 @@ SSL *s;
        return(ssl3_do_write(s,SSL3_RT_HANDSHAKE));
        }
 
-static int ssl3_send_server_key_exchange(s)
-SSL *s;
+static int ssl3_send_server_key_exchange(SSL *s)
        {
 #ifndef NO_RSA
        unsigned char *q;
@@ -889,6 +907,7 @@ SSL *s;
        EVP_PKEY *pkey;
        unsigned char *p,*d;
        int al,i;
+       unsigned int u;
        unsigned long type;
        int n;
        CERT *cert;
@@ -900,7 +919,7 @@ SSL *s;
        if (s->state == SSL3_ST_SW_KEY_EXCH_A)
                {
                type=s->s3->tmp.new_cipher->algorithms & SSL_MKEY_MASK;
-               cert=s->session->cert;
+               cert=s->cert;
 
                buf=s->init_buf;
 
@@ -910,17 +929,17 @@ SSL *s;
                if (type & SSL_kRSA)
                        {
                        rsa=cert->rsa_tmp;
-                       if ((rsa == NULL) && (s->ctx->default_cert->rsa_tmp_cb != NULL))
+                       if ((rsa == NULL) && (s->cert->rsa_tmp_cb != NULL))
                                {
-                               rsa=s->ctx->default_cert->rsa_tmp_cb(s,
-                                       (s->s3->tmp.new_cipher->algorithms|
-                                       SSL_NOT_EXP)?0:1);
+                               rsa=s->cert->rsa_tmp_cb(s,
+                                     SSL_C_IS_EXPORT(s->s3->tmp.new_cipher),
+                                     SSL_C_EXPORT_PKEYLENGTH(s->s3->tmp.new_cipher));
                                CRYPTO_add(&rsa->references,1,CRYPTO_LOCK_RSA);
                                cert->rsa_tmp=rsa;
                                }
                        if (rsa == NULL)
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,SSL_R_MISSING_TMP_RSA_KEY);
                                goto f_err;
                                }
@@ -934,13 +953,13 @@ SSL *s;
                        if (type & SSL_kEDH)
                        {
                        dhp=cert->dh_tmp;
-                       if ((dhp == NULL) && (cert->dh_tmp_cb != NULL))
-                               dhp=cert->dh_tmp_cb(s,
-                                       (s->s3->tmp.new_cipher->algorithms|
-                                       SSL_NOT_EXP)?0:1);
+                       if ((dhp == NULL) && (s->cert->dh_tmp_cb != NULL))
+                               dhp=s->cert->dh_tmp_cb(s,
+                                     !SSL_C_IS_EXPORT(s->s3->tmp.new_cipher),
+                                     SSL_C_EXPORT_PKEYLENGTH(s->s3->tmp.new_cipher));
                        if (dhp == NULL)
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,SSL_R_MISSING_TMP_DH_KEY);
                                goto f_err;
                                }
@@ -951,13 +970,16 @@ SSL *s;
                                }
 
                        s->s3->tmp.dh=dh;
-                       if (((dhp->pub_key == NULL) ||
-                            (dhp->priv_key == NULL) ||
-                            (s->ctx->options & SSL_OP_SINGLE_DH_USE)) &&
-                           (!DH_generate_key(dh)))
+                       if ((dhp->pub_key == NULL ||
+                            dhp->priv_key == NULL ||
+                            (s->options & SSL_OP_SINGLE_DH_USE)))
                                {
-                               SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,ERR_R_DH_LIB);
-                               goto err;
+                               if(!DH_generate_key(dh))
+                                   {
+                                   SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,
+                                          ERR_R_DH_LIB);
+                                   goto err;
+                                   }
                                }
                        else
                                {
@@ -977,7 +999,7 @@ SSL *s;
                else 
 #endif
                        {
-                       al=SSL3_AD_HANDSHAKE_FAILURE;
+                       al=SSL_AD_HANDSHAKE_FAILURE;
                        SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,SSL_R_UNKNOWN_KEY_EXCHANGE_TYPE);
                        goto f_err;
                        }
@@ -992,7 +1014,7 @@ SSL *s;
                        if ((pkey=ssl_get_sign_pkey(s,s->s3->tmp.new_cipher))
                                == NULL)
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_DECODE_ERROR;
                                goto f_err;
                                }
                        kn=EVP_PKEY_size(pkey);
@@ -1030,7 +1052,8 @@ SSL *s;
                                j=0;
                                for (num=2; num > 0; num--)
                                        {
-                                       EVP_DigestInit(&md_ctx,(num == 2)?EVP_md5():EVP_sha1());
+                                       EVP_DigestInit(&md_ctx,(num == 2)
+                                               ?s->ctx->md5:s->ctx->sha1);
                                        EVP_DigestUpdate(&md_ctx,&(s->s3->client_random[0]),SSL3_RANDOM_SIZE);
                                        EVP_DigestUpdate(&md_ctx,&(s->s3->server_random[0]),SSL3_RANDOM_SIZE);
                                        EVP_DigestUpdate(&md_ctx,&(d[4]),n);
@@ -1039,15 +1062,14 @@ SSL *s;
                                        q+=i;
                                        j+=i;
                                        }
-                               i=RSA_private_encrypt(j,md_buf,&(p[2]),
-                                       pkey->pkey.rsa,RSA_PKCS1_PADDING);
-                               if (i <= 0)
+                               if (RSA_sign(NID_md5_sha1, md_buf, j,
+                                       &(p[2]), &u, pkey->pkey.rsa) <= 0)
                                        {
                                        SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,ERR_LIB_RSA);
                                        goto err;
                                        }
-                               s2n(i,p);
-                               n+=i+2;
+                               s2n(u,p);
+                               n+=u+2;
                                }
                        else
 #endif
@@ -1072,7 +1094,7 @@ SSL *s;
 #endif
                                {
                                /* Is this error check actually needed? */
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_SEND_SERVER_KEY_EXCHANGE,SSL_R_UNKNOWN_PKEY_TYPE);
                                goto f_err;
                                }
@@ -1095,12 +1117,11 @@ err:
        return(-1);
        }
 
-static int ssl3_send_certificate_request(s)
-SSL *s;
+static int ssl3_send_certificate_request(SSL *s)
        {
        unsigned char *p,*d;
        int i,j,nl,off,n;
-       STACK *sk=NULL;
+       STACK_OF(X509_NAME) *sk=NULL;
        X509_NAME *name;
        BUF_MEM *buf;
 
@@ -1125,9 +1146,9 @@ SSL *s;
                nl=0;
                if (sk != NULL)
                        {
-                       for (i=0; i<sk_num(sk); i++)
+                       for (i=0; i<sk_X509_NAME_num(sk); i++)
                                {
-                               name=(X509_NAME *)sk_value(sk,i);
+                               name=sk_X509_NAME_value(sk,i);
                                j=i2d_X509_NAME(name,NULL);
                                if (!BUF_MEM_grow(buf,4+n+j+2))
                                        {
@@ -1135,7 +1156,7 @@ SSL *s;
                                        goto err;
                                        }
                                p=(unsigned char *)&(buf->data[4+n]);
-                               if (!(s->ctx->options & SSL_OP_NETSCAPE_CA_DN_BUG))
+                               if (!(s->options & SSL_OP_NETSCAPE_CA_DN_BUG))
                                        {
                                        s2n(j,p);
                                        i2d_X509_NAME(name,&p);
@@ -1173,17 +1194,20 @@ err:
        return(-1);
        }
 
-static int ssl3_get_client_key_exchange(s)
-SSL *s;
+static int ssl3_get_client_key_exchange(SSL *s)
        {
        int i,al,ok;
        long n;
        unsigned long l;
        unsigned char *p;
+#ifndef NO_RSA
        RSA *rsa=NULL;
-       BIGNUM *pub=NULL;
        EVP_PKEY *pkey=NULL;
+#endif
+#ifndef NO_DH
+       BIGNUM *pub=NULL;
        DH *dh_srvr;
+#endif
 
        n=ssl3_get_message(s,
                SSL3_ST_SR_KEY_EXCH_A,
@@ -1203,17 +1227,13 @@ SSL *s;
                /* FIX THIS UP EAY EAY EAY EAY */
                if (s->s3->tmp.use_rsa_tmp)
                        {
-                       if ((s->session->cert != NULL) &&
-                               (s->session->cert->rsa_tmp != NULL))
-                               rsa=s->session->cert->rsa_tmp;
-                       else if ((s->ctx->default_cert != NULL) &&
-                               (s->ctx->default_cert->rsa_tmp != NULL))
-                               rsa=s->ctx->default_cert->rsa_tmp;
+                       if ((s->cert != NULL) && (s->cert->rsa_tmp != NULL))
+                               rsa=s->cert->rsa_tmp;
                        /* Don't do a callback because rsa_tmp should
                         * be sent already */
                        if (rsa == NULL)
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_MISSING_TMP_RSA_PKEY);
                                goto f_err;
 
@@ -1226,24 +1246,56 @@ SSL *s;
                                (pkey->type != EVP_PKEY_RSA) ||
                                (pkey->pkey.rsa == NULL))
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_MISSING_RSA_CERTIFICATE);
                                goto f_err;
                                }
                        rsa=pkey->pkey.rsa;
                        }
 
+               /* TLS */
+               if (s->version > SSL3_VERSION)
+                       {
+                       n2s(p,i);
+                       if (n != i+2)
+                               {
+                               if (!(s->options & SSL_OP_TLS_D5_BUG))
+                                       {
+                                       SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_TLS_RSA_ENCRYPTED_VALUE_LENGTH_IS_WRONG);
+                                       goto err;
+                                       }
+                               else
+                                       p-=2;
+                               }
+                       else
+                               n=i;
+                       }
+
                i=RSA_private_decrypt((int)n,p,p,rsa,RSA_PKCS1_PADDING);
-#if 1
-               /* If a bad decrypt, use a dud master key */
+
+#if 0
+               /* If a bad decrypt, use a random master key */
                if ((i != SSL_MAX_MASTER_KEY_LENGTH) ||
-                       (p[0] != 3) ||
-                        (p[1] != 0))
+                       ((p[0] != (s->client_version>>8)) ||
+                        (p[1] != (s->client_version & 0xff))))
                        {
-                       p[0]=3;
-                       p[1]=0;
-                       RAND_bytes(&(p[2]),SSL_MAX_MASTER_KEY_LENGTH-2);
-                       i=SSL_MAX_MASTER_KEY_LENGTH;
+                       int bad=1;
+
+                       if ((i == SSL_MAX_MASTER_KEY_LENGTH) &&
+                               (p[0] == (s->version>>8)) &&
+                               (p[1] == 0))
+                               {
+                               if (s->options & SSL_OP_TLS_ROLLBACK_BUG)
+                                       bad=0;
+                               }
+                       if (bad)
+                               {
+                               p[0]=(s->version>>8);
+                               p[1]=(s->version & 0xff);
+                               RAND_bytes(&(p[2]),SSL_MAX_MASTER_KEY_LENGTH-2);
+                               i=SSL_MAX_MASTER_KEY_LENGTH;
+                               }
+                       /* else, an SSLeay bug, ssl only server, tls client */
                        }
 #else
                if (i != SSL_MAX_MASTER_KEY_LENGTH)
@@ -1253,7 +1305,7 @@ SSL *s;
                        goto f_err;
                        }
 
-               if ((p[0] != (s->version>>8)) || (p[1] != (s->version & 0xff)))
+               if ((p[0] != (s->client_version>>8)) || (p[1] != (s->client_version & 0xff)))
                        {
                        al=SSL_AD_DECODE_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_BAD_PROTOCOL_VERSION_NUMBER);
@@ -1262,7 +1314,7 @@ SSL *s;
 #endif
 
                s->session->master_key_length=
-                       ssl3_generate_master_secret(s,
+                       s->method->ssl3_enc->generate_master_secret(s,
                                s->session->master_key,
                                p,i);
                memset(p,0,i);
@@ -1272,11 +1324,10 @@ SSL *s;
 #ifndef NO_DH
                if (l & (SSL_kEDH|SSL_kDHr|SSL_kDHd))
                {
-
                n2s(p,i);
                if (n != i+2)
                        {
-                       if (!(s->ctx->options & SSL_OP_SSLEAY_080_CLIENT_DH_BUG))
+                       if (!(s->options & SSL_OP_SSLEAY_080_CLIENT_DH_BUG))
                                {
                                SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_DH_PUBLIC_VALUE_LENGTH_IS_WRONG);
                                goto err;
@@ -1290,7 +1341,7 @@ SSL *s;
 
                if (n == 0L) /* the parameters are in the cert */
                        {
-                       al=SSL3_AD_HANDSHAKE_FAILURE;
+                       al=SSL_AD_HANDSHAKE_FAILURE;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_UNABLE_TO_DECODE_DH_CERTS);
                        goto f_err;
                        }
@@ -1298,7 +1349,7 @@ SSL *s;
                        {
                        if (s->s3->tmp.dh == NULL)
                                {
-                               al=SSL3_AD_HANDSHAKE_FAILURE;
+                               al=SSL_AD_HANDSHAKE_FAILURE;
                                SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_MISSING_TMP_DH_KEY);
                                goto f_err;
                                }
@@ -1312,6 +1363,7 @@ SSL *s;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_BN_LIB);
                        goto err;
                        }
+
                i=DH_compute_key(p,pub,dh_srvr);
 
                if (i <= 0)
@@ -1326,13 +1378,13 @@ SSL *s;
                BN_clear_free(pub);
                pub=NULL;
                s->session->master_key_length=
-                       ssl3_generate_master_secret(s,
+                       s->method->ssl3_enc->generate_master_secret(s,
                                s->session->master_key,p,i);
                }
        else
 #endif
                {
-               al=SSL3_AD_HANDSHAKE_FAILURE;
+               al=SSL_AD_HANDSHAKE_FAILURE;
                SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE,SSL_R_UNKNOWN_CIPHER_TYPE);
                goto f_err;
                }
@@ -1340,12 +1392,13 @@ SSL *s;
        return(1);
 f_err:
        ssl3_send_alert(s,SSL3_AL_FATAL,al);
+#if !defined(NO_DH) || !defined(NO_RSA)
 err:
+#endif
        return(-1);
        }
 
-static int ssl3_get_cert_verify(s)
-SSL *s;
+static int ssl3_get_cert_verify(SSL *s)
        {
        EVP_PKEY *pkey=NULL;
        unsigned char *p;
@@ -1380,8 +1433,8 @@ SSL *s;
                s->s3->tmp.reuse_message=1;
                if ((peer != NULL) && (type | EVP_PKT_SIGN))
                        {
+                       al=SSL_AD_UNEXPECTED_MESSAGE;
                        SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_MISSING_VERIFY_MESSAGE);
-                       al=SSL3_AD_UNEXPECTED_MESSAGE;
                        goto f_err;
                        }
                ret=1;
@@ -1391,21 +1444,21 @@ SSL *s;
        if (peer == NULL)
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_NO_CLIENT_CERT_RECEIVED);
-               al=SSL3_AD_UNEXPECTED_MESSAGE;
+               al=SSL_AD_UNEXPECTED_MESSAGE;
                goto f_err;
                }
 
        if (!(type & EVP_PKT_SIGN))
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_SIGNATURE_FOR_NON_SIGNING_CERTIFICATE);
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_ILLEGAL_PARAMETER;
                goto f_err;
                }
 
        if (s->s3->change_cipher_spec)
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_CCS_RECEIVED_EARLY);
-               al=SSL3_AD_UNEXPECTED_MESSAGE;
+               al=SSL_AD_UNEXPECTED_MESSAGE;
                goto f_err;
                }
 
@@ -1416,7 +1469,7 @@ SSL *s;
        if (i > n)
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_LENGTH_MISMATCH);
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_DECODE_ERROR;
                goto f_err;
                }
 
@@ -1424,27 +1477,25 @@ SSL *s;
        if ((i > j) || (n > j) || (n <= 0))
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_WRONG_SIGNATURE_SIZE);
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_DECODE_ERROR;
                goto f_err;
                }
 
 #ifndef NO_RSA 
        if (pkey->type == EVP_PKEY_RSA)
                {
-               i=RSA_public_decrypt(i,p,p,pkey->pkey.rsa,RSA_PKCS1_PADDING);
+               i=RSA_verify(NID_md5_sha1, s->s3->tmp.cert_verify_md,
+                       MD5_DIGEST_LENGTH+SHA_DIGEST_LENGTH, p, i, 
+                                                       pkey->pkey.rsa);
                if (i < 0)
                        {
-                       al=SSL3_AD_ILLEGAL_PARAMETER;
+                       al=SSL_AD_DECRYPT_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_BAD_RSA_DECRYPT);
                        goto f_err;
                        }
-               if ((i != (MD5_DIGEST_LENGTH+SHA_DIGEST_LENGTH)) ||
-                       memcmp(&(s->s3->tmp.finish_md1[0]),
-                               p,MD5_DIGEST_LENGTH) ||
-                       memcmp(&(s->s3->tmp.finish_md2[0]),
-                               &(p[MD5_DIGEST_LENGTH]),SHA_DIGEST_LENGTH))
+               if (i == 0)
                        {
-                       al=SSL3_AD_ILLEGAL_PARAMETER;
+                       al=SSL_AD_DECRYPT_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_BAD_RSA_SIGNATURE);
                        goto f_err;
                        }
@@ -1454,12 +1505,13 @@ SSL *s;
 #ifndef NO_DSA
                if (pkey->type == EVP_PKEY_DSA)
                {
-               j=DSA_verify(pkey->save_type,s->s3->tmp.finish_md2,
+               j=DSA_verify(pkey->save_type,
+                       &(s->s3->tmp.cert_verify_md[MD5_DIGEST_LENGTH]),
                        SHA_DIGEST_LENGTH,p,i,pkey->pkey.dsa);
                if (j <= 0)
                        {
                        /* bad signature */
-                       al=SSL3_AD_ILLEGAL_PARAMETER;
+                       al=SSL_AD_DECRYPT_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_BAD_DSA_SIGNATURE);
                        goto f_err;
                        }
@@ -1468,7 +1520,7 @@ SSL *s;
 #endif
                {
                SSLerr(SSL_F_SSL3_GET_CERT_VERIFY,SSL_R_INTERNAL_ERROR);
-               al=SSL3_AD_UNSUPPORTED_CERTIFICATE;
+               al=SSL_AD_UNSUPPORTED_CERTIFICATE;
                goto f_err;
                }
 
@@ -1480,17 +1532,17 @@ f_err:
                ssl3_send_alert(s,SSL3_AL_FATAL,al);
                }
 end:
+       EVP_PKEY_free(pkey);
        return(ret);
        }
 
-static int ssl3_get_client_certificate(s)
-SSL *s;
+static int ssl3_get_client_certificate(SSL *s)
        {
        int i,ok,al,ret= -1;
        X509 *x=NULL;
        unsigned long l,nc,llen,n;
        unsigned char *p,*d,*q;
-       STACK *sk=NULL;
+       STACK_OF(X509) *sk=NULL;
 
        n=ssl3_get_message(s,
                SSL3_ST_SR_CERT_A,
@@ -1511,7 +1563,14 @@ SSL *s;
                        (s->verify_mode & SSL_VERIFY_FAIL_IF_NO_PEER_CERT))
                        {
                        SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_PEER_DID_NOT_RETURN_A_CERTIFICATE);
-                       al=SSL3_AD_NO_CERTIFICATE;
+                       al=SSL_AD_HANDSHAKE_FAILURE;
+                       goto f_err;
+                       }
+               /* If tls asked for a client cert, the client must return a 0 list */
+               if ((s->version > SSL3_VERSION) && s->s3->tmp.cert_request)
+                       {
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_TLS_PEER_DID_NOT_RESPOND_WITH_CERTIFICATE_LIST);
+                       al=SSL_AD_UNEXPECTED_MESSAGE;
                        goto f_err;
                        }
                s->s3->tmp.reuse_message=1;
@@ -1520,13 +1579,13 @@ SSL *s;
 
        if (s->s3->tmp.message_type != SSL3_MT_CERTIFICATE)
                {
-               al=SSL3_AD_UNEXPECTED_MESSAGE;
+               al=SSL_AD_UNEXPECTED_MESSAGE;
                SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_WRONG_MESSAGE_TYPE);
                goto f_err;
                }
        d=p=(unsigned char *)s->init_buf->data;
 
-       if ((sk=sk_new_null()) == NULL)
+       if ((sk=sk_X509_new_null()) == NULL)
                {
                SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,ERR_R_MALLOC_FAILURE);
                goto err;
@@ -1535,7 +1594,7 @@ SSL *s;
        n2l3(p,llen);
        if (llen+3 != n)
                {
-               al=SSL3_AD_ILLEGAL_PARAMETER;
+               al=SSL_AD_DECODE_ERROR;
                SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_LENGTH_MISMATCH);
                goto f_err;
                }
@@ -1544,7 +1603,7 @@ SSL *s;
                n2l3(p,l);
                if ((l+nc+3) > llen)
                        {
-                       al=SSL3_AD_ILLEGAL_PARAMETER;
+                       al=SSL_AD_DECODE_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_CERT_LENGTH_MISMATCH);
                        goto f_err;
                        }
@@ -1558,11 +1617,11 @@ SSL *s;
                        }
                if (p != (q+l))
                        {
-                       al=SSL3_AD_ILLEGAL_PARAMETER;
+                       al=SSL_AD_DECODE_ERROR;
                        SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_CERT_LENGTH_MISMATCH);
                        goto f_err;
                        }
-               if (!sk_push(sk,(char *)x))
+               if (!sk_X509_push(sk,x))
                        {
                        SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,ERR_R_MALLOC_FAILURE);
                        goto err;
@@ -1571,25 +1630,56 @@ SSL *s;
                nc+=l+3;
                }
 
-       if (sk_num(sk) <= 0)
+       if (sk_X509_num(sk) <= 0)
                {
-               al=SSL3_AD_ILLEGAL_PARAMETER;
-               SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_NO_CERTIFICATES_PASSED);
-               goto f_err;
+               /* TLS does not mind 0 certs returned */
+               if (s->version == SSL3_VERSION)
+                       {
+                       al=SSL_AD_HANDSHAKE_FAILURE;
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_NO_CERTIFICATES_RETURNED);
+                       goto f_err;
+                       }
+               /* Fail for TLS only if we required a certificate */
+               else if ((s->verify_mode & SSL_VERIFY_PEER) &&
+                        (s->verify_mode & SSL_VERIFY_FAIL_IF_NO_PEER_CERT))
+                       {
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_PEER_DID_NOT_RETURN_A_CERTIFICATE);
+                       al=SSL_AD_HANDSHAKE_FAILURE;
+                       goto f_err;
+                       }
                }
-       i=ssl_verify_cert_chain(s,sk);
-       if (!i)
+       else
                {
-               al=ssl_verify_alarm_type(s->verify_result);
-               SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_NO_CERTIFICATE_RETURNED);
-               goto f_err;
+               i=ssl_verify_cert_chain(s,sk);
+               if (!i)
+                       {
+                       al=ssl_verify_alarm_type(s->verify_result);
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,SSL_R_NO_CERTIFICATE_RETURNED);
+                       goto f_err;
+                       }
                }
 
-       /* This should not be needed */
-       if (s->session->peer != NULL)
+       if (s->session->peer != NULL) /* This should not be needed */
                X509_free(s->session->peer);
-       
-       s->session->peer=(X509 *)sk_shift(sk);
+       s->session->peer=sk_X509_shift(sk);
+       s->session->verify_result = s->verify_result;
+
+       /* With the current implementation, sess_cert will always be NULL
+        * when we arrive here. */
+       if (s->session->sess_cert == NULL)
+               {
+               s->session->sess_cert = ssl_sess_cert_new();
+               if (s->session->sess_cert == NULL)
+                       {
+                       SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE, ERR_R_MALLOC_FAILURE);
+                       goto err;
+                       }
+               }
+       if (s->session->sess_cert->cert_chain != NULL)
+               sk_X509_pop_free(s->session->sess_cert->cert_chain, X509_free);
+       s->session->sess_cert->cert_chain=sk;
+
+       sk=NULL;
 
        ret=1;
        if (0)
@@ -1599,12 +1689,11 @@ f_err:
                }
 err:
        if (x != NULL) X509_free(x);
-       if (sk != NULL) sk_pop_free(sk,X509_free);
+       if (sk != NULL) sk_X509_pop_free(sk,X509_free);
        return(ret);
        }
 
-int ssl3_send_server_certificate(s)
-SSL *s;
+int ssl3_send_server_certificate(SSL *s)
        {
        unsigned long l;
        X509 *x;