Fix no-ssl3 configuration option

[openssl.git] / ssl / s23_clnt.c

diff --git a/ssl/s23_clnt.c b/ssl/s23_clnt.c
index 60a028430d37558b7ab906246ac4c3e33cfc5a25..42c3d6861f9a4eeb285fc402cd3c74d3e3254066 100644 (file)
--- a/ssl/s23_clnt.c
+++ b/ssl/s23_clnt.c
@@ -125,9 +125,11 @@ static const SSL_METHOD *ssl23_get_client_method(int ver)
        if (ver == SSL2_VERSION)
                return(SSLv2_client_method());
 #endif
+#ifndef OPENSSL_NO_SSL3
        if (ver == SSL3_VERSION)
                return(SSLv3_client_method());
-       else if (ver == TLS1_VERSION)
+#endif
+       if (ver == TLS1_VERSION)
                return(TLSv1_client_method());
        else if (ver == TLS1_1_VERSION)
                return(TLSv1_1_client_method());
@@ -259,10 +261,13 @@ static int ssl23_no_ssl2_ciphers(SSL *s)
        SSL_CIPHER *cipher;
        STACK_OF(SSL_CIPHER) *ciphers;
        int i;
+       ssl_set_client_disabled(s);
        ciphers = SSL_get_ciphers(s);
        for (i = 0; i < sk_SSL_CIPHER_num(ciphers); i++)
                {
                cipher = sk_SSL_CIPHER_value(ciphers, i);
+               if (ssl_cipher_disabled(s, cipher, SSL_SECOP_CIPHER_SUPPORTED))
+                       continue;
                if (cipher->algorithm_ssl == SSL_SSLV2)
                        return 0;
                }
@@ -282,7 +287,7 @@ int ssl_fill_hello_random(SSL *s, int server, unsigned char *result, int len)
                        send_time = (s->mode & SSL_MODE_SEND_CLIENTHELLO_TIME) != 0;
                if (send_time)
                        {
-                       unsigned long Time = time(NULL);
+                       unsigned long Time = (unsigned long)time(NULL);
                        unsigned char *p = result;
                        l2n(Time, p);
                        return RAND_pseudo_bytes(p, len-4);
@@ -309,6 +314,8 @@ static int ssl23_client_hello(SSL *s)
 
        ssl2_compat = (options & SSL_OP_NO_SSLv2) ? 0 : 1;
 
+       if (ssl2_compat && !ssl_security(s, SSL_SECOP_SSL2_COMPAT, 0, 0, NULL))
+               ssl2_compat = 0;
        if (ssl2_compat && ssl23_no_ssl2_ciphers(s))
                ssl2_compat = 0;
 
@@ -363,9 +370,7 @@ static int ssl23_client_hello(SSL *s)
                if (s->ctx->tlsext_opaque_prf_input_callback != 0 || s->tlsext_opaque_prf_input != NULL)
                        ssl2_compat = 0;
 #endif
-               if (s->ctx->custom_cli_ext_records_count != 0)
-                       ssl2_compat = 0;
-               if (s->ctx->cli_supp_data_records_count != 0)
+               if (s->cert->cli_ext.meths_count != 0)
                        ssl2_compat = 0;
                }
 #endif
@@ -533,8 +538,7 @@ static int ssl23_client_hello(SSL *s)
 #ifdef OPENSSL_NO_COMP
                        *(p++)=1;
 #else
-                       if ((s->options & SSL_OP_NO_COMPRESSION)
-                                               || !s->ctx->comp_methods)
+                       if (!ssl_allow_compression(s) || !s->ctx->comp_methods)
                                j=0;
                        else
                                j=sk_SSL_COMP_num(s->ctx->comp_methods);
@@ -712,6 +716,7 @@ static int ssl23_get_server_hello(SSL *s)
                {
                /* we have sslv3 or tls1 (server hello or alert) */
 
+#ifndef OPENSSL_NO_SSL3
                if ((p[2] == SSL3_VERSION_MINOR) &&
                        !(s->options & SSL_OP_NO_SSLv3))
                        {
@@ -726,7 +731,9 @@ static int ssl23_get_server_hello(SSL *s)
                        s->version=SSL3_VERSION;
                        s->method=SSLv3_client_method();
                        }
-               else if ((p[2] == TLS1_VERSION_MINOR) &&
+               else
+#endif
+               if ((p[2] == TLS1_VERSION_MINOR) &&
                        !(s->options & SSL_OP_NO_TLSv1))
                        {
                        s->version=TLS1_VERSION;
@@ -750,6 +757,15 @@ static int ssl23_get_server_hello(SSL *s)
                        goto err;
                        }
 
+               /* ensure that TLS_MAX_VERSION is up-to-date */
+               OPENSSL_assert(s->version <= TLS_MAX_VERSION);
+
+               if (!ssl_security(s, SSL_SECOP_VERSION, 0, s->version, NULL))
+                       {
+                       SSLerr(SSL_F_SSL23_GET_SERVER_HELLO,SSL_R_VERSION_TOO_LOW);
+                       goto err;
+                       }
+
                if (p[0] == SSL3_RT_ALERT && p[5] != SSL3_AL_WARNING)
                        {
                        /* fatal alert */