Compare encodings in X509_cmp as well as hash.
[openssl.git] / crypto / x509 / x509_cmp.c
index ee234b04ad1689ba6eebf3379460cafd8fa1cc67..123709902a80db5288638a9ec98ff08bf4a52c76 100644 (file)
@@ -86,16 +86,20 @@ unsigned long X509_issuer_and_serial_hash(X509 *a)
 
        EVP_MD_CTX_init(&ctx);
        f=X509_NAME_oneline(a->cert_info->issuer,NULL,0);
-       ret=strlen(f);
-       EVP_DigestInit_ex(&ctx, EVP_md5(), NULL);
-       EVP_DigestUpdate(&ctx,(unsigned char *)f,ret);
+       if (!EVP_DigestInit_ex(&ctx, EVP_md5(), NULL))
+               goto err;
+       if (!EVP_DigestUpdate(&ctx,(unsigned char *)f,strlen(f)))
+               goto err;
        OPENSSL_free(f);
-       EVP_DigestUpdate(&ctx,(unsigned char *)a->cert_info->serialNumber->data,
-               (unsigned long)a->cert_info->serialNumber->length);
-       EVP_DigestFinal_ex(&ctx,&(md[0]),NULL);
+       if(!EVP_DigestUpdate(&ctx,(unsigned char *)a->cert_info->serialNumber->data,
+               (unsigned long)a->cert_info->serialNumber->length))
+               goto err;
+       if (!EVP_DigestFinal_ex(&ctx,&(md[0]),NULL))
+               goto err;
        ret=(   ((unsigned long)md[0]     )|((unsigned long)md[1]<<8L)|
                ((unsigned long)md[2]<<16L)|((unsigned long)md[3]<<24L)
                )&0xffffffffL;
+       err:
        EVP_MD_CTX_cleanup(&ctx);
        return(ret);
        }
@@ -133,6 +137,13 @@ unsigned long X509_issuer_name_hash(X509 *x)
        return(X509_NAME_hash(x->cert_info->issuer));
        }
 
+#ifndef OPENSSL_NO_MD5
+unsigned long X509_issuer_name_hash_old(X509 *x)
+       {
+       return(X509_NAME_hash_old(x->cert_info->issuer));
+       }
+#endif
+
 X509_NAME *X509_get_subject_name(X509 *a)
        {
        return(a->cert_info->subject);
@@ -148,6 +159,13 @@ unsigned long X509_subject_name_hash(X509 *x)
        return(X509_NAME_hash(x->cert_info->subject));
        }
 
+#ifndef OPENSSL_NO_MD5
+unsigned long X509_subject_name_hash_old(X509 *x)
+       {
+       return(X509_NAME_hash_old(x->cert_info->subject));
+       }
+#endif
+
 #ifndef OPENSSL_NO_SHA
 /* Compare two certificates: they must be identical for
  * this to work. NB: Although "cmp" operations are generally
@@ -160,11 +178,24 @@ unsigned long X509_subject_name_hash(X509 *x)
  */
 int X509_cmp(const X509 *a, const X509 *b)
 {
+       int rv;
        /* ensure hash is valid */
        X509_check_purpose((X509 *)a, -1, 0);
        X509_check_purpose((X509 *)b, -1, 0);
 
-       return memcmp(a->sha1_hash, b->sha1_hash, SHA_DIGEST_LENGTH);
+       rv = memcmp(a->sha1_hash, b->sha1_hash, SHA_DIGEST_LENGTH);
+       if (rv)
+               return rv;
+       /* Check for match against stored encoding too */
+       if (!a->cert_info->enc.modified && !b->cert_info->enc.modified)
+               {
+               rv = (int)(a->cert_info->enc.len - b->cert_info->enc.len);
+               if (rv)
+                       return rv;
+               return memcmp(a->cert_info->enc.enc, b->cert_info->enc.enc,
+                               a->cert_info->enc.len);
+               }
+       return rv;
 }
 #endif
 
@@ -173,16 +204,16 @@ int X509_NAME_cmp(const X509_NAME *a, const X509_NAME *b)
        {
        int ret;
 
-       /* Ensure canonical encoding is present */
+       /* Ensure canonical encoding is present and up to date */
 
-       if (!a->canon_enc)
+       if (!a->canon_enc || a->modified)
                {
                ret = i2d_X509_NAME((X509_NAME *)a, NULL);
                if (ret < 0)
                        return -2;
                }
 
-       if (!b->canon_enc)
+       if (!b->canon_enc || b->modified)
                {
                ret = i2d_X509_NAME((X509_NAME *)b, NULL);
                if (ret < 0)
@@ -201,11 +232,13 @@ int X509_NAME_cmp(const X509_NAME *a, const X509_NAME *b)
 unsigned long X509_NAME_hash(X509_NAME *x)
        {
        unsigned long ret=0;
-       unsigned char md[16];
+       unsigned char md[SHA_DIGEST_LENGTH];
 
        /* Make sure X509_NAME structure contains valid cached encoding */
        i2d_X509_NAME(x,NULL);
-       EVP_Digest(x->canon_enc, x->canon_enclen, md, NULL, EVP_sha1(), NULL);
+       if (!EVP_Digest(x->canon_enc, x->canon_enclen, md, NULL, EVP_sha1(),
+               NULL))
+               return 0;
 
        ret=(   ((unsigned long)md[0]     )|((unsigned long)md[1]<<8L)|
                ((unsigned long)md[2]<<16L)|((unsigned long)md[3]<<24L)
@@ -220,16 +253,22 @@ unsigned long X509_NAME_hash(X509_NAME *x)
 
 unsigned long X509_NAME_hash_old(X509_NAME *x)
        {
+       EVP_MD_CTX md_ctx;
        unsigned long ret=0;
        unsigned char md[16];
 
        /* Make sure X509_NAME structure contains valid cached encoding */
        i2d_X509_NAME(x,NULL);
-       EVP_Digest(x->bytes->data, x->bytes->length, md, NULL, EVP_md5(), NULL);
+       EVP_MD_CTX_init(&md_ctx);
+       EVP_MD_CTX_set_flags(&md_ctx, EVP_MD_CTX_FLAG_NON_FIPS_ALLOW);
+       if (EVP_DigestInit_ex(&md_ctx, EVP_md5(), NULL)
+           && EVP_DigestUpdate(&md_ctx, x->bytes->data, x->bytes->length)
+           && EVP_DigestFinal_ex(&md_ctx,md,NULL))
+               ret=(((unsigned long)md[0]     )|((unsigned long)md[1]<<8L)|
+                    ((unsigned long)md[2]<<16L)|((unsigned long)md[3]<<24L)
+                    )&0xffffffffL;
+       EVP_MD_CTX_cleanup(&md_ctx);
 
-       ret=(   ((unsigned long)md[0]     )|((unsigned long)md[1]<<8L)|
-               ((unsigned long)md[2]<<16L)|((unsigned long)md[3]<<24L)
-               )&0xffffffffL;
        return(ret);
        }
 #endif
@@ -284,6 +323,7 @@ ASN1_BIT_STRING *X509_get0_pubkey_bitstr(const X509 *x)
        return x->cert_info->key->public_key;
        }
 
+
 int X509_check_private_key(X509 *x, EVP_PKEY *k)
        {
        EVP_PKEY *xk;
@@ -315,3 +355,158 @@ int X509_check_private_key(X509 *x, EVP_PKEY *k)
                return 1;
        return 0;
        }
+
+/* Check a suite B algorithm is permitted: pass in a public key and
+ * the NID of its signature (or 0 if no signature). The pflags is
+ * a pointer to a flags field which must contain the suite B verification
+ * flags.
+ */
+
+#ifndef OPENSSL_NO_EC
+
+static int check_suite_b(EVP_PKEY *pkey, int sign_nid, unsigned long *pflags)
+       {
+       const EC_GROUP *grp = NULL;
+       int curve_nid;
+       if (pkey && pkey->type == EVP_PKEY_EC)
+               grp = EC_KEY_get0_group(pkey->pkey.ec);
+       if (!grp)
+               return X509_V_ERR_SUITE_B_INVALID_ALGORITHM;
+       curve_nid = EC_GROUP_get_curve_name(grp);
+       /* Check curve is consistent with LOS */
+       if (curve_nid == NID_secp384r1) /* P-384 */
+               {
+               /* Check signature algorithm is consistent with
+                * curve.
+                */
+               if (sign_nid != -1 && sign_nid != NID_ecdsa_with_SHA384)
+                       return X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM;
+               if (!(*pflags & X509_V_FLAG_SUITEB_192_LOS))
+                       return X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED;
+               /* If we encounter P-384 we cannot use P-256 later */
+               *pflags &= ~X509_V_FLAG_SUITEB_128_LOS_ONLY;
+               }
+       else if (curve_nid == NID_X9_62_prime256v1) /* P-256 */
+               {
+               if (sign_nid != -1 && sign_nid != NID_ecdsa_with_SHA256)
+                       return X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM;
+               if (!(*pflags & X509_V_FLAG_SUITEB_128_LOS_ONLY))
+                       return X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED;
+               }
+       else
+               return X509_V_ERR_SUITE_B_INVALID_CURVE;
+
+       return X509_V_OK;
+       }
+
+int X509_chain_check_suiteb(int *perror_depth, X509 *x, STACK_OF(X509) *chain,
+                                                       unsigned long flags)
+       {
+       int rv, i, sign_nid;
+       EVP_PKEY *pk = NULL;
+       unsigned long tflags;
+       if (!(flags & X509_V_FLAG_SUITEB_128_LOS))
+               return X509_V_OK;
+       tflags = flags;
+       /* If no EE certificate passed in must be first in chain */
+       if (x == NULL)
+               {
+               x = sk_X509_value(chain, 0);
+               i = 1;
+               }
+       else
+               i = 0;
+
+       if (X509_get_version(x) != 2)
+               {
+               rv = X509_V_ERR_SUITE_B_INVALID_VERSION;
+               /* Correct error depth */
+               i = 0;
+               goto end;
+               }
+
+       pk = X509_get_pubkey(x);
+       /* Check EE key only */
+       rv = check_suite_b(pk, -1, &tflags);
+       if (rv != X509_V_OK)
+               {
+               /* Correct error depth */
+               i = 0;
+               goto end;
+               }
+       for(; i < sk_X509_num(chain); i++)
+               {
+               sign_nid = X509_get_signature_nid(x);
+               x = sk_X509_value(chain, i);
+               if (X509_get_version(x) != 2)
+                       {
+                       rv = X509_V_ERR_SUITE_B_INVALID_VERSION;
+                       goto end;
+                       }
+               EVP_PKEY_free(pk);
+               pk = X509_get_pubkey(x);
+               rv = check_suite_b(pk, sign_nid, &tflags);
+               if (rv != X509_V_OK)
+                       goto end;
+               }
+
+       /* Final check: root CA signature */
+       rv = check_suite_b(pk, X509_get_signature_nid(x), &tflags);
+       end:
+       if (pk)
+               EVP_PKEY_free(pk);
+       if (rv != X509_V_OK)
+               {
+               /* Invalid signature or LOS errors are for previous cert */
+               if ((rv == X509_V_ERR_SUITE_B_INVALID_SIGNATURE_ALGORITHM
+                   || rv == X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED) && i)
+                       i--;
+               /* If we have LOS error and flags changed then we are signing
+                * P-384 with P-256. Use more meaninggul error.
+                */
+               if (rv == X509_V_ERR_SUITE_B_LOS_NOT_ALLOWED && flags != tflags)
+                       rv = X509_V_ERR_SUITE_B_CANNOT_SIGN_P_384_WITH_P_256;
+               if (perror_depth)
+                       *perror_depth = i;
+               }
+       return rv;
+       }
+
+int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags)
+       {
+       int sign_nid;
+       if (!(flags & X509_V_FLAG_SUITEB_128_LOS))
+               return X509_V_OK;
+       sign_nid = OBJ_obj2nid(crl->crl->sig_alg->algorithm);
+       return check_suite_b(pk, sign_nid, &flags);
+       }
+
+#else
+int X509_chain_check_suiteb(int *perror_depth, X509 *x, STACK_OF(X509) *chain,
+                                                       unsigned long flags)
+       {
+       return 0;
+       }
+
+int X509_CRL_check_suiteb(X509_CRL *crl, EVP_PKEY *pk, unsigned long flags)
+       {
+       return 0;
+       }
+
+#endif
+/* Not strictly speaking an "up_ref" as a STACK doesn't have a reference
+ * count but it has the same effect by duping the STACK and upping the ref
+ * of each X509 structure.
+ */
+STACK_OF(X509) *X509_chain_up_ref(STACK_OF(X509) *chain)
+       {
+       STACK_OF(X509) *ret;
+       int i;
+       ret = sk_X509_dup(chain);
+       for (i = 0; i < sk_X509_num(ret); i++)
+               {
+               X509 *x = sk_X509_value(ret, i);
+               CRYPTO_add(&x->references, 1, CRYPTO_LOCK_X509);
+               }
+       return ret;
+       }