free NULL cleanup 8
[openssl.git] / crypto / pkcs12 / p12_attr.c
index 6247fdb76651a88de8265630cfdf9e53ba871770..70695b7bb6844e2f869b05265dccedf43bf65f05 100644 (file)
@@ -1,6 +1,7 @@
 /* p12_attr.c */
-/* Written by Dr Stephen N Henson (shenson@bigfoot.com) for the OpenSSL
- * project 1999.
+/*
+ * Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL project
+ * 1999.
  */
 /* ====================================================================
  * Copyright (c) 1999 The OpenSSL Project.  All rights reserved.
@@ -10,7 +11,7 @@
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer. 
+ *    notice, this list of conditions and the following disclaimer.
  *
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in
 
 #include <stdio.h>
 #include "cryptlib.h"
-#include "pkcs12.h"
+#include <openssl/pkcs12.h>
 
 /* Add a local keyid to a safebag */
 
-int PKCS12_add_localkeyid (PKCS12_SAFEBAG *bag, unsigned char *name,
-            int namelen)
+int PKCS12_add_localkeyid(PKCS12_SAFEBAG *bag, unsigned char *name,
+                          int namelen)
 {
-       X509_ATTRIBUTE *attrib;
-       ASN1_BMPSTRING *oct;
-       ASN1_TYPE *keyid;
-       if (!(keyid = ASN1_TYPE_new ())) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       keyid->type = V_ASN1_OCTET_STRING;
-       if (!(oct = ASN1_OCTET_STRING_new())) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       if (!ASN1_OCTET_STRING_set(oct, name, namelen)) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       keyid->value.octet_string = oct;
-       if (!(attrib = X509_ATTRIBUTE_new ())) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       attrib->object = OBJ_nid2obj(NID_localKeyID);
-       if (!(attrib->value.set = sk_new(NULL))) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (attrib->value.set, (char *)keyid);
-       attrib->set = 1;
-       if (!bag->attrib && !(bag->attrib = sk_new (NULL))) {
-               PKCS12err(PKCS12_F_PKCS12_ADD_LOCALKEYID, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (bag->attrib, (char *)attrib);
-       return 1;
+    if (X509at_add1_attr_by_NID(&bag->attrib, NID_localKeyID,
+                                V_ASN1_OCTET_STRING, name, namelen))
+        return 1;
+    else
+        return 0;
 }
 
 /* Add key usage to PKCS#8 structure */
 
-int PKCS8_add_keyusage (PKCS8_PRIV_KEY_INFO *p8, int usage)
+int PKCS8_add_keyusage(PKCS8_PRIV_KEY_INFO *p8, int usage)
 {
-       X509_ATTRIBUTE *attrib;
-       ASN1_BIT_STRING *bstr;
-       ASN1_TYPE *keyid;
-       unsigned char us_val;
-       us_val = (unsigned char) usage;
-       if (!(keyid = ASN1_TYPE_new ())) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       keyid->type = V_ASN1_BIT_STRING;
-       if (!(bstr = ASN1_BIT_STRING_new())) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       if (!ASN1_BIT_STRING_set(bstr, &us_val, 1)) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       keyid->value.bit_string = bstr;
-       if (!(attrib = X509_ATTRIBUTE_new ())) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       attrib->object = OBJ_nid2obj(NID_key_usage);
-       if (!(attrib->value.set = sk_new(NULL))) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (attrib->value.set, (char *)keyid);
-       attrib->set = 1;
-       if (!p8->attributes && !(p8->attributes = sk_new (NULL))) {
-               PKCS12err(PKCS12_F_PKCS8_ADD_KEYUSAGE, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (p8->attributes, (char *)attrib);
-       return 1;
+    unsigned char us_val;
+    us_val = (unsigned char)usage;
+    if (X509at_add1_attr_by_NID(&p8->attributes, NID_key_usage,
+                                V_ASN1_BIT_STRING, &us_val, 1))
+        return 1;
+    else
+        return 0;
 }
 
 /* Add a friendlyname to a safebag */
 
-int PKCS12_add_friendlyname_asc (PKCS12_SAFEBAG *bag, unsigned char *name,
-            int namelen)
+int PKCS12_add_friendlyname_asc(PKCS12_SAFEBAG *bag, const char *name,
+                                int namelen)
 {
-       unsigned char *uniname;
-       int ret, unilen;
-       if (!asc2uni(name, &uniname, &unilen)) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_ASC,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       ret = PKCS12_add_friendlyname_uni (bag, uniname, unilen);
-       Free(uniname);
-       return ret;
+    if (X509at_add1_attr_by_NID(&bag->attrib, NID_friendlyName,
+                                MBSTRING_ASC, (unsigned char *)name, namelen))
+        return 1;
+    else
+        return 0;
 }
-       
 
-int PKCS12_add_friendlyname_uni (PKCS12_SAFEBAG *bag, unsigned char *name,
-            int namelen)
+int PKCS12_add_friendlyname_uni(PKCS12_SAFEBAG *bag,
+                                const unsigned char *name, int namelen)
 {
-       X509_ATTRIBUTE *attrib;
-       ASN1_BMPSTRING *bmp;
-       ASN1_TYPE *fname;
-       /* Zap ending double null if included */
-       if(!name[namelen - 1] && !name[namelen - 2]) namelen -= 2;
-       if (!(fname = ASN1_TYPE_new ())) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_UNI,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       fname->type = V_ASN1_BMPSTRING;
-       if (!(bmp = ASN1_BMPSTRING_new())) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_UNI,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       if (!(bmp->data = Malloc (namelen))) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_UNI,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       memcpy (bmp->data, name, namelen);
-       bmp->length = namelen;
-       fname->value.bmpstring = bmp;
-       if (!(attrib = X509_ATTRIBUTE_new ())) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_UNI,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       attrib->object = OBJ_nid2obj(NID_friendlyName);
-       if (!(attrib->value.set = sk_new(NULL))) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME,ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (attrib->value.set, (char *)fname);
-       attrib->set = 1;
-       if (!bag->attrib && !(bag->attrib = sk_new (NULL))) {
-               PKCS12err(PKCS12_F_ADD_FRIENDLYNAME_UNI, ERR_R_MALLOC_FAILURE);
-               return 0;
-       }
-       sk_push (bag->attrib, (char *)attrib);
-       return PKCS12_OK;
+    if (X509at_add1_attr_by_NID(&bag->attrib, NID_friendlyName,
+                                MBSTRING_BMP, name, namelen))
+        return 1;
+    else
+        return 0;
 }
 
-ASN1_TYPE *PKCS12_get_attr_gen (STACK *attrs, int attr_nid)
+int PKCS12_add_CSPName_asc(PKCS12_SAFEBAG *bag, const char *name, int namelen)
 {
-       X509_ATTRIBUTE *attrib;
-       int i;
-       if (!attrs) return NULL;
-       for (i = 0; i < sk_num (attrs); i++) {
-               attrib = (X509_ATTRIBUTE *) sk_value (attrs, i);
-               if (OBJ_obj2nid (attrib->object) == attr_nid) {
-                       if (sk_num (attrib->value.set))
-                               return (ASN1_TYPE *)
-                                        sk_value (attrib->value.set, 0);
-                       else return NULL;
-               }
-       }
-       return NULL;
+    if (X509at_add1_attr_by_NID(&bag->attrib, NID_ms_csp_name,
+                                MBSTRING_ASC, (unsigned char *)name, namelen))
+        return 1;
+    else
+        return 0;
 }
 
-char *PKCS12_get_friendlyname(PKCS12_SAFEBAG *bag)
+ASN1_TYPE *PKCS12_get_attr_gen(STACK_OF(X509_ATTRIBUTE) *attrs, int attr_nid)
 {
-       ASN1_TYPE *atype;
-       if (!(atype = PKCS12_get_attr(bag, NID_friendlyName))) return NULL;
-       if (atype->type != V_ASN1_BMPSTRING) return NULL;
-       return uni2asc(atype->value.bmpstring->data,
-                                atype->value.bmpstring->length);
+    X509_ATTRIBUTE *attrib;
+    int i;
+    i = X509at_get_attr_by_NID(attrs, attr_nid, -1);
+    attrib = X509at_get_attr(attrs, i);
+    return X509_ATTRIBUTE_get0_type(attrib, 0);
 }
 
+char *PKCS12_get_friendlyname(PKCS12_SAFEBAG *bag)
+{
+    ASN1_TYPE *atype;
+    if (!(atype = PKCS12_get_attr(bag, NID_friendlyName)))
+        return NULL;
+    if (atype->type != V_ASN1_BMPSTRING)
+        return NULL;
+    return OPENSSL_uni2asc(atype->value.bmpstring->data,
+                           atype->value.bmpstring->length);
+}