Return an error if no recipient type matches.

[openssl.git] / crypto / pem / pem_seal.c

diff --git a/crypto/pem/pem_seal.c b/crypto/pem/pem_seal.c
index 5f5d2c0e43ddada4212f3b10843e23e763624583..ae4598d67408947c889f2d8a3806f2825eb98798 100644 (file)
--- a/crypto/pem/pem_seal.c
+++ b/crypto/pem/pem_seal.c
@@ -56,6 +56,8 @@
  * [including the GNU Public Licence.]
  */
 
+#include <openssl/opensslconf.h>       /* for OPENSSL_NO_RSA */
+#ifndef OPENSSL_NO_RSA
 #include <stdio.h>
 #include "cryptlib.h"
 #include <openssl/evp.h>
@@ -63,6 +65,7 @@
 #include <openssl/objects.h>
 #include <openssl/x509.h>
 #include <openssl/pem.h>
+#include <openssl/rsa.h>
 
 int PEM_SealInit(PEM_ENCODE_SEAL_CTX *ctx, EVP_CIPHER *type, EVP_MD *md_type,
             unsigned char **ek, int *ekl, unsigned char *iv, EVP_PKEY **pubk,
@@ -83,18 +86,22 @@ int PEM_SealInit(PEM_ENCODE_SEAL_CTX *ctx, EVP_CIPHER *type, EVP_MD *md_type,
                j=RSA_size(pubk[i]->pkey.rsa);
                if (j > max) max=j;
                }
-       s=(char *)Malloc(max*2);
+       s=(char *)OPENSSL_malloc(max*2);
        if (s == NULL)
                {
                PEMerr(PEM_F_PEM_SEALINIT,ERR_R_MALLOC_FAILURE);
                goto err;
                }
 
-       EVP_EncodeInit(&(ctx->encode));
-       EVP_SignInit(&(ctx->md),md_type);
+       EVP_EncodeInit(&ctx->encode);
 
-       ret=EVP_SealInit(&(ctx->cipher),type,ek,ekl,iv,pubk,npubk);
-       if (!ret) goto err;
+       EVP_MD_CTX_init(&ctx->md);
+       if (!EVP_SignInit(&ctx->md,md_type))
+               goto err;
+
+       EVP_CIPHER_CTX_init(&ctx->cipher);
+       ret=EVP_SealInit(&ctx->cipher,type,ek,ekl,iv,pubk,npubk);
+       if (ret <= 0) goto err;
 
        /* base64 encode the keys */
        for (i=0; i<npubk; i++)
@@ -107,19 +114,20 @@ int PEM_SealInit(PEM_ENCODE_SEAL_CTX *ctx, EVP_CIPHER *type, EVP_MD *md_type,
 
        ret=npubk;
 err:
-       if (s != NULL) Free(s);
-       memset(key,0,EVP_MAX_KEY_LENGTH);
+       if (s != NULL) OPENSSL_free(s);
+       OPENSSL_cleanse(key,EVP_MAX_KEY_LENGTH);
        return(ret);
        }
 
-void PEM_SealUpdate(PEM_ENCODE_SEAL_CTX *ctx, unsigned char *out, int *outl,
+int PEM_SealUpdate(PEM_ENCODE_SEAL_CTX *ctx, unsigned char *out, int *outl,
             unsigned char *in, int inl)
        {
        unsigned char buffer[1600];
        int i,j;
 
        *outl=0;
-       EVP_SignUpdate(&(ctx->md),in,inl);
+       if (!EVP_SignUpdate(&ctx->md,in,inl))
+               return 0;
        for (;;)
                {
                if (inl <= 0) break;
@@ -127,13 +135,15 @@ void PEM_SealUpdate(PEM_ENCODE_SEAL_CTX *ctx, unsigned char *out, int *outl,
                        i=1200;
                else
                        i=inl;
-               EVP_EncryptUpdate(&(ctx->cipher),buffer,&j,in,i);
-               EVP_EncodeUpdate(&(ctx->encode),out,&j,buffer,j);
+               if (!EVP_EncryptUpdate(&ctx->cipher,buffer,&j,in,i))
+                       return 0;
+               EVP_EncodeUpdate(&ctx->encode,out,&j,buffer,j);
                *outl+=j;
                out+=j;
                in+=i;
                inl-=i;
                }
+       return 1;
        }
 
 int PEM_SealFinal(PEM_ENCODE_SEAL_CTX *ctx, unsigned char *sig, int *sigl,
@@ -150,27 +160,35 @@ int PEM_SealFinal(PEM_ENCODE_SEAL_CTX *ctx, unsigned char *sig, int *sigl,
                }
        i=RSA_size(priv->pkey.rsa);
        if (i < 100) i=100;
-       s=(unsigned char *)Malloc(i*2);
+       s=(unsigned char *)OPENSSL_malloc(i*2);
        if (s == NULL)
                {
                PEMerr(PEM_F_PEM_SEALFINAL,ERR_R_MALLOC_FAILURE);
                goto err;
                }
 
-       EVP_EncryptFinal(&(ctx->cipher),s,(int *)&i);
-       EVP_EncodeUpdate(&(ctx->encode),out,&j,s,i);
+       if (!EVP_EncryptFinal_ex(&ctx->cipher,s,(int *)&i))
+               goto err;
+       EVP_EncodeUpdate(&ctx->encode,out,&j,s,i);
        *outl=j;
        out+=j;
-       EVP_EncodeFinal(&(ctx->encode),out,&j);
+       EVP_EncodeFinal(&ctx->encode,out,&j);
        *outl+=j;
 
-       if (!EVP_SignFinal(&(ctx->md),s,&i,priv)) goto err;
+       if (!EVP_SignFinal(&ctx->md,s,&i,priv)) goto err;
        *sigl=EVP_EncodeBlock(sig,s,i);
 
        ret=1;
 err:
-       memset((char *)&(ctx->md),0,sizeof(ctx->md));
-       memset((char *)&(ctx->cipher),0,sizeof(ctx->cipher));
-       if (s != NULL) Free(s);
+       EVP_MD_CTX_cleanup(&ctx->md);
+       EVP_CIPHER_CTX_cleanup(&ctx->cipher);
+       if (s != NULL) OPENSSL_free(s);
        return(ret);
        }
+#else /* !OPENSSL_NO_RSA */
+
+# if PEDANTIC
+static void *dummy=&dummy;
+# endif
+
+#endif