Make `safe' (EC)DSA nonces the default.
[openssl.git] / crypto / ecdsa / ecs_ossl.c
index 7e4b61fdef505d168fde020314cfcd677760fd71..9f7aecf5ee64fd9b537a255274fc8a99a156476a 100644 (file)
  *
  */
 
-#include "ecdsa.h"
+#define OPENSSL_FIPSAPI
+
+#include "ecs_locl.h"
 #include <openssl/err.h>
 #include <openssl/obj_mac.h>
+#include <openssl/bn.h>
+#include <openssl/rand.h>
 
 static ECDSA_SIG *ecdsa_do_sign(const unsigned char *dgst, int dlen, 
-               EC_KEY *eckey);
-static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp, 
+               const BIGNUM *, const BIGNUM *, EC_KEY *eckey);
+static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp,
                BIGNUM **rp);
+static int ecdsa_sign_setup_with_digest(EC_KEY *eckey, BN_CTX *ctx_in,
+                                       BIGNUM **kinvp, BIGNUM **rp,
+                                       const unsigned char *dgst, int dlen);
 static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len, 
-               ECDSA_SIG *sig, EC_KEY *eckey);
+               const ECDSA_SIG *sig, EC_KEY *eckey);
 
 static ECDSA_METHOD openssl_ecdsa_meth = {
        "OpenSSL ECDSA method",
@@ -76,7 +83,7 @@ static ECDSA_METHOD openssl_ecdsa_meth = {
        NULL, /* init     */
        NULL, /* finish   */
 #endif
-       0,    /* flags    */
+       ECDSA_FLAG_FIPS_METHOD,    /* flags    */
        NULL  /* app_data */
 };
 
@@ -86,19 +93,25 @@ const ECDSA_METHOD *ECDSA_OpenSSL(void)
 }
 
 static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp,
-               BIGNUM **rp)
+               BIGNUM **rp) {
+       return ecdsa_sign_setup_with_digest(eckey, ctx_in, kinvp, rp, NULL, 0);
+}
+
+static int ecdsa_sign_setup_with_digest(EC_KEY *eckey, BN_CTX *ctx_in,
+                                       BIGNUM **kinvp, BIGNUM **rp,
+                                       const unsigned char *dgst, int dlen)
 {
        BN_CTX   *ctx = NULL;
        BIGNUM   *k = NULL, *r = NULL, *order = NULL, *X = NULL;
        EC_POINT *tmp_point=NULL;
-       EC_GROUP *group;
+       const EC_GROUP *group;
        int      ret = 0;
-       if (!eckey  || !eckey->group || !eckey->pub_key || !eckey->priv_key)
+
+       if (eckey == NULL || (group = EC_KEY_get0_group(eckey)) == NULL)
        {
                ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP, ERR_R_PASSED_NULL_PARAMETER);
                return 0;
        }
-       group = eckey->group;
 
        if (ctx_in == NULL) 
        {
@@ -130,19 +143,47 @@ static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp,
                ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP, ERR_R_EC_LIB);
                goto err;
        }
+
+#ifdef OPENSSL_FIPS
+       if (!fips_check_ec_prng(eckey))
+               goto err;
+#endif
        
        do
        {
                /* get random k */      
                do
-                       if (!BN_rand_range(k, order))
+#ifndef OPENSSL_NO_SHA512
+                       if (dgst != NULL)
                        {
-                               ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP,
-                                ECDSA_R_RANDOM_NUMBER_GENERATION_FAILED);      
-                               goto err;
+                               if (!BN_generate_dsa_nonce(k, order, EC_KEY_get0_private_key(eckey),
+                                                          dgst, dlen, ctx))
+                                       {
+                                       ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP,
+                                                ECDSA_R_RANDOM_NUMBER_GENERATION_FAILED);
+                                       goto err;
+                                       }
+                       }
+                       else
+#endif
+                       {
+                               if (!BN_rand_range(k, order))
+                               {
+                                       ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP,
+                                                ECDSA_R_RANDOM_NUMBER_GENERATION_FAILED);
+                                       goto err;
+                               }
                        }
                while (BN_is_zero(k));
 
+               /* We do not want timing information to leak the length of k,
+                * so we compute G*k using an equivalent scalar of fixed
+                * bit-length. */
+
+               if (!BN_add(k, k, order)) goto err;
+               if (BN_num_bits(k) <= BN_num_bits(order))
+                       if (!BN_add(k, k, order)) goto err;
+
                /* compute r the x-coordinate of generator * k */
                if (!EC_POINT_mul(group, tmp_point, k, NULL, NULL, ctx))
                {
@@ -158,6 +199,7 @@ static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp,
                                goto err;
                        }
                }
+#ifndef OPENSSL_NO_EC2M
                else /* NID_X9_62_characteristic_two_field */
                {
                        if (!EC_POINT_get_affine_coordinates_GF2m(group,
@@ -167,6 +209,7 @@ static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, BIGNUM **kinvp,
                                goto err;
                        }
                }
+#endif
                if (!BN_nnmod(r, X, order, ctx))
                {
                        ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP, ERR_R_BN_LIB);
@@ -209,24 +252,40 @@ err:
 
 
 static ECDSA_SIG *ecdsa_do_sign(const unsigned char *dgst, int dgst_len, 
-               EC_KEY *eckey)
+               const BIGNUM *in_kinv, const BIGNUM *in_r, EC_KEY *eckey)
 {
-       int     ok = 0;
-       BIGNUM *kinv=NULL, *r, *s, *m=NULL,*tmp=NULL,*order=NULL;
+       int     ok = 0, i;
+       BIGNUM *kinv=NULL, *s, *m=NULL,*tmp=NULL,*order=NULL;
+       const BIGNUM *ckinv;
        BN_CTX     *ctx = NULL;
-       EC_GROUP   *group;
+       const EC_GROUP   *group;
        ECDSA_SIG  *ret;
        ECDSA_DATA *ecdsa;
+       const BIGNUM *priv_key;
 
-       ecdsa = ecdsa_check(eckey);
+#ifdef OPENSSL_FIPS
+       if(FIPS_selftest_failed())
+               {
+               FIPSerr(FIPS_F_ECDSA_DO_SIGN,FIPS_R_FIPS_SELFTEST_FAILED);
+               return NULL;
+               }
+#endif
 
-       if (!eckey->group || !eckey->pub_key || !eckey->priv_key || !ecdsa)
+       ecdsa    = ecdsa_check(eckey);
+       group    = EC_KEY_get0_group(eckey);
+       priv_key = EC_KEY_get0_private_key(eckey);
+       
+       if (group == NULL || priv_key == NULL || ecdsa == NULL)
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_PASSED_NULL_PARAMETER);
                return NULL;
        }
 
-       group = eckey->group;
+#ifdef OPENSSL_FIPS
+       if (!fips_check_ec_prng(eckey))
+               return NULL;
+#endif
+
        ret = ECDSA_SIG_new();
        if (!ret)
        {
@@ -247,40 +306,46 @@ static ECDSA_SIG *ecdsa_do_sign(const unsigned char *dgst, int dgst_len,
                ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_EC_LIB);
                goto err;
        }
-       if (dgst_len > BN_num_bytes(order))
+       i = BN_num_bits(order);
+       /* Need to truncate digest if it is too long: first truncate whole
+        * bytes.
+        */
+       if (8 * dgst_len > i)
+               dgst_len = (i + 7)/8;
+       if (!BN_bin2bn(dgst, dgst_len, m))
        {
-               ECDSAerr(ECDSA_F_ECDSA_DO_SIGN,
-                       ECDSA_R_DATA_TOO_LARGE_FOR_KEY_SIZE);
+               ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_BN_LIB);
                goto err;
        }
-
-       if (!BN_bin2bn(dgst, dgst_len, m))
+       /* If still too long truncate remaining bits with a shift */
+       if ((8 * dgst_len > i) && !BN_rshift(m, m, 8 - (i & 0x7)))
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_BN_LIB);
                goto err;
        }
        do
        {
-               if (ecdsa->kinv == NULL || ecdsa->r == NULL)
+               if (in_kinv == NULL || in_r == NULL)
                {
-                       if (!ECDSA_sign_setup(eckey, ctx, &kinv, &ret->r))
+                       if (!ecdsa_sign_setup_with_digest(
+                               eckey, ctx, &kinv, &ret->r, dgst, dgst_len))
                        {
                                ECDSAerr(ECDSA_F_ECDSA_DO_SIGN,ERR_R_ECDSA_LIB);
                                goto err;
                        }
-                       r = ret->r;
+                       ckinv = kinv;
                }
                else
                {
-                       BN_free(ret->r);
-                       kinv   = ecdsa->kinv;
-                       r      = ecdsa->r;
-                       ret->r = r;
-                       ecdsa->kinv = NULL;
-                       ecdsa->r    = NULL;
+                       ckinv  = in_kinv;
+                       if (BN_copy(ret->r, in_r) == NULL)
+                       {
+                               ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_MALLOC_FAILURE);
+                               goto err;
+                       }
                }
 
-               if (!BN_mod_mul(tmp, eckey->priv_key, r, order, ctx))
+               if (!BN_mod_mul(tmp, priv_key, ret->r, order, ctx))
                {
                        ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_BN_LIB);
                        goto err;
@@ -290,13 +355,26 @@ static ECDSA_SIG *ecdsa_do_sign(const unsigned char *dgst, int dgst_len,
                        ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_BN_LIB);
                        goto err;
                }
-               if (!BN_mod_mul(s, s, kinv, order, ctx))
+               if (!BN_mod_mul(s, s, ckinv, order, ctx))
                {
                        ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ERR_R_BN_LIB);
                        goto err;
                }
+               if (BN_is_zero(s))
+               {
+                       /* if kinv and r have been supplied by the caller
+                        * don't to generate new kinv and r values */
+                       if (in_kinv != NULL && in_r != NULL)
+                       {
+                               ECDSAerr(ECDSA_F_ECDSA_DO_SIGN, ECDSA_R_NEED_NEW_SETUP_VALUES);
+                               goto err;
+                       }
+               }
+               else
+                       /* s != 0 => we have a valid signature */
+                       break;
        }
-       while (BN_is_zero(s));
+       while (1);
 
        ok = 1;
 err:
@@ -319,22 +397,31 @@ err:
 }
 
 static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len,
-               ECDSA_SIG *sig, EC_KEY *eckey)
+               const ECDSA_SIG *sig, EC_KEY *eckey)
 {
-       int ret = -1;
+       int ret = -1, i;
        BN_CTX   *ctx;
        BIGNUM   *order, *u1, *u2, *m, *X;
        EC_POINT *point = NULL;
-       EC_GROUP *group;
+       const EC_GROUP *group;
+       const EC_POINT *pub_key;
+
+#ifdef OPENSSL_FIPS
+       if(FIPS_selftest_failed())
+               {
+               FIPSerr(FIPS_F_ECDSA_DO_VERIFY,FIPS_R_FIPS_SELFTEST_FAILED);
+               return -1;
+               }
+#endif
+
        /* check input values */
-       if (!eckey || !eckey->group || !eckey->pub_key || !sig)
+       if (eckey == NULL || (group = EC_KEY_get0_group(eckey)) == NULL ||
+           (pub_key = EC_KEY_get0_public_key(eckey)) == NULL || sig == NULL)
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ECDSA_R_MISSING_PARAMETERS);
                return -1;
        }
 
-       group = eckey->group;
-
        ctx = BN_CTX_new();
        if (!ctx)
        {
@@ -359,9 +446,9 @@ static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len,
                goto err;
        }
 
-       if (BN_is_zero(sig->r)          || BN_get_sign(sig->r) || 
+       if (BN_is_zero(sig->r)          || BN_is_negative(sig->r) || 
            BN_ucmp(sig->r, order) >= 0 || BN_is_zero(sig->s)  ||
-           BN_get_sign(sig->s)         || BN_ucmp(sig->s, order) >= 0)
+           BN_is_negative(sig->s)      || BN_ucmp(sig->s, order) >= 0)
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ECDSA_R_BAD_SIGNATURE);
                ret = 0;        /* signature is invalid */
@@ -374,11 +461,23 @@ static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len,
                goto err;
        }
        /* digest -> m */
+       i = BN_num_bits(order);
+       /* Need to truncate digest if it is too long: first truncate whole
+        * bytes.
+        */
+       if (8 * dgst_len > i)
+               dgst_len = (i + 7)/8;
        if (!BN_bin2bn(dgst, dgst_len, m))
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_BN_LIB);
                goto err;
        }
+       /* If still too long truncate remaining bits with a shift */
+       if ((8 * dgst_len > i) && !BN_rshift(m, m, 8 - (i & 0x7)))
+       {
+               ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_BN_LIB);
+               goto err;
+       }
        /* u1 = m * tmp mod order */
        if (!BN_mod_mul(u1, m, u2, order, ctx))
        {
@@ -397,7 +496,7 @@ static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len,
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_MALLOC_FAILURE);
                goto err;
        }
-       if (!EC_POINT_mul(group, point, u1, eckey->pub_key, u2, ctx))
+       if (!EC_POINT_mul(group, point, u1, pub_key, u2, ctx))
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_EC_LIB);
                goto err;
@@ -407,20 +506,21 @@ static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len,
                if (!EC_POINT_get_affine_coordinates_GFp(group,
                        point, X, NULL, ctx))
                {
-                       ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP, ERR_R_EC_LIB);
+                       ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_EC_LIB);
                        goto err;
                }
        }
+#ifndef OPENSSL_NO_EC2M
        else /* NID_X9_62_characteristic_two_field */
        {
                if (!EC_POINT_get_affine_coordinates_GF2m(group,
                        point, X, NULL, ctx))
                {
-                       ECDSAerr(ECDSA_F_ECDSA_SIGN_SETUP, ERR_R_EC_LIB);
+                       ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_EC_LIB);
                        goto err;
                }
        }
-       
+#endif 
        if (!BN_nnmod(u1, X, order, ctx))
        {
                ECDSAerr(ECDSA_F_ECDSA_DO_VERIFY, ERR_R_BN_LIB);
@@ -435,3 +535,32 @@ err:
                EC_POINT_free(point);
        return ret;
 }
+
+#ifdef OPENSSL_FIPSCANISTER
+/* FIPS stanadlone version of ecdsa_check: just return FIPS method */
+ECDSA_DATA *fips_ecdsa_check(EC_KEY *key)
+       {
+       static ECDSA_DATA rv = {
+               0,0,0,
+               &openssl_ecdsa_meth
+               };
+       return &rv;
+       }
+/* Standalone digest sign and verify */
+int FIPS_ecdsa_verify_digest(EC_KEY *key,
+                       const unsigned char *dig, int dlen, ECDSA_SIG *s)
+       {
+       ECDSA_DATA *ecdsa = ecdsa_check(key);
+       if (ecdsa == NULL)
+               return 0;
+       return ecdsa->meth->ecdsa_do_verify(dig, dlen, s, key);
+       }
+ECDSA_SIG * FIPS_ecdsa_sign_digest(EC_KEY *key,
+                                       const unsigned char *dig, int dlen)
+       {
+       ECDSA_DATA *ecdsa = ecdsa_check(key);
+       if (ecdsa == NULL)
+               return NULL;
+       return ecdsa->meth->ecdsa_do_sign(dig, dlen, NULL, NULL, key);
+       }
+#endif