fix DH_generate_parameters for general 'generator'

[openssl.git] / crypto / dh / dh_key.c

diff --git a/crypto/dh/dh_key.c b/crypto/dh/dh_key.c
index 91af882e43356860459ddd4a91e6025c405b74c2..1a0efca2c4c19c0eb319e48b2ac30d3371cac7df 100644 (file)
--- a/crypto/dh/dh_key.c
+++ b/crypto/dh/dh_key.c
@@ -74,12 +74,12 @@ static int dh_finish(DH *dh);
 
 int DH_generate_key(DH *dh)
        {
-       return ENGINE_get_DH(dh->engine)->generate_key(dh);
+       return dh->meth->generate_key(dh);
        }
 
 int DH_compute_key(unsigned char *key, const BIGNUM *pub_key, DH *dh)
        {
-       return ENGINE_get_DH(dh->engine)->compute_key(key, pub_key, dh);
+       return dh->meth->compute_key(key, pub_key, dh);
        }
 
 static DH_METHOD dh_ossl = {
@@ -101,6 +101,8 @@ const DH_METHOD *DH_OpenSSL(void)
 static int generate_key(DH *dh)
        {
        int ok=0;
+       int generate_new_key=0;
+       unsigned l;
        BN_CTX *ctx;
        BN_MONT_CTX *mont;
        BIGNUM *pub_key=NULL,*priv_key=NULL;
@@ -112,9 +114,7 @@ static int generate_key(DH *dh)
                {
                priv_key=BN_new();
                if (priv_key == NULL) goto err;
-               do
-                       if (!BN_rand_range(priv_key, dh->p)) goto err;
-               while (BN_is_zero(priv_key));
+               generate_new_key=1;
                }
        else
                priv_key=dh->priv_key;
@@ -135,8 +135,12 @@ static int generate_key(DH *dh)
                }
        mont=(BN_MONT_CTX *)dh->method_mont_p;
 
-       if (!ENGINE_get_DH(dh->engine)->bn_mod_exp(dh, pub_key, dh->g,
-                               priv_key,dh->p,ctx,mont))
+       if (generate_new_key)
+               {
+               l = dh->length ? dh->length : BN_num_bits(dh->p)-1; /* secret exponent length */
+               if (!BN_rand(priv_key, l, 0, 0)) goto err;
+               }
+       if (!dh->meth->bn_mod_exp(dh, pub_key, dh->g, priv_key,dh->p,ctx,mont))
                goto err;
                
        dh->pub_key=pub_key;
@@ -177,8 +181,7 @@ static int compute_key(unsigned char *key, const BIGNUM *pub_key, DH *dh)
                }
 
        mont=(BN_MONT_CTX *)dh->method_mont_p;
-       if (!ENGINE_get_DH(dh->engine)->bn_mod_exp(dh, tmp, pub_key,
-                               dh->priv_key,dh->p,ctx,mont))
+       if (!dh->meth->bn_mod_exp(dh, tmp, pub_key, dh->priv_key,dh->p,ctx,mont))
                {
                DHerr(DH_F_DH_COMPUTE_KEY,ERR_R_BN_LIB);
                goto err;