Fix memory leak on bad inputs.
[openssl.git] / crypto / asn1 / x_name.c
index c03f9169cb212a20f2179dea6214ce56759f26ed..49be08b4daab7d43ba4ccaebd5f164e261264cd9 100644 (file)
@@ -1,5 +1,5 @@
 /* crypto/asn1/x_name.c */
-/* Copyright (C) 1995-1997 Eric Young (eay@cryptsoft.com)
+/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
  * This package is an SSL implementation written
  */
 
 #include <stdio.h>
+#include <ctype.h>
 #include "cryptlib.h"
-#include "objects.h"
-#include "asn1_mac.h"
-
-/*
- * ASN1err(ASN1_F_D2I_X509_NAME,ASN1_R_LENGTH_MISMATCH);
- * ASN1err(ASN1_F_X509_NAME_NEW,ASN1_R_UNKNOWN_ATTRIBUTE_TYPE);
- * ASN1err(ASN1_F_D2I_X509_NAME_ENTRY,ASN1_R_LENGTH_MISMATCH);
- * ASN1err(ASN1_F_X509_NAME_ENTRY_NEW,ASN1_R_UNKNOWN_ATTRIBUTE_TYPE);
+#include <openssl/asn1t.h>
+#include <openssl/x509.h>
+#include "asn1_locl.h"
+
+typedef STACK_OF(X509_NAME_ENTRY) STACK_OF_X509_NAME_ENTRY;
+DECLARE_STACK_OF(STACK_OF_X509_NAME_ENTRY)
+
+static int x509_name_ex_d2i(ASN1_VALUE **val,
+                               const unsigned char **in, long len,
+                               const ASN1_ITEM *it,
+                               int tag, int aclass, char opt, ASN1_TLC *ctx);
+
+static int x509_name_ex_i2d(ASN1_VALUE **val, unsigned char **out,
+                               const ASN1_ITEM *it, int tag, int aclass);
+static int x509_name_ex_new(ASN1_VALUE **val, const ASN1_ITEM *it);
+static void x509_name_ex_free(ASN1_VALUE **val, const ASN1_ITEM *it);
+
+static int x509_name_encode(X509_NAME *a);
+static int x509_name_canon(X509_NAME *a);
+static int asn1_string_canon(ASN1_STRING *out, ASN1_STRING *in);
+static int i2d_name_canon(STACK_OF(STACK_OF_X509_NAME_ENTRY) *intname,
+                         unsigned char **in);
+
+
+static int x509_name_ex_print(BIO *out, ASN1_VALUE **pval,
+                                               int indent,
+                                               const char *fname, 
+                                               const ASN1_PCTX *pctx);
+
+ASN1_SEQUENCE(X509_NAME_ENTRY) = {
+       ASN1_SIMPLE(X509_NAME_ENTRY, object, ASN1_OBJECT),
+       ASN1_SIMPLE(X509_NAME_ENTRY, value, ASN1_PRINTABLE)
+} ASN1_SEQUENCE_END(X509_NAME_ENTRY)
+
+IMPLEMENT_ASN1_FUNCTIONS(X509_NAME_ENTRY)
+IMPLEMENT_ASN1_DUP_FUNCTION(X509_NAME_ENTRY)
+
+/* For the "Name" type we need a SEQUENCE OF { SET OF X509_NAME_ENTRY }
+ * so declare two template wrappers for this
  */
 
-#ifndef NOPROTO
-static int i2d_X509_NAME_entries(X509_NAME *a);
-#else
-static int i2d_X509_NAME_entries();
-#endif
+ASN1_ITEM_TEMPLATE(X509_NAME_ENTRIES) =
+       ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SET_OF, 0, RDNS, X509_NAME_ENTRY)
+ASN1_ITEM_TEMPLATE_END(X509_NAME_ENTRIES)
 
-int i2d_X509_NAME_ENTRY(a,pp)
-X509_NAME_ENTRY *a;
-unsigned char **pp;
-       {
-       M_ASN1_I2D_vars(a);
+ASN1_ITEM_TEMPLATE(X509_NAME_INTERNAL) =
+       ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SEQUENCE_OF, 0, Name, X509_NAME_ENTRIES)
+ASN1_ITEM_TEMPLATE_END(X509_NAME_INTERNAL)
 
-       M_ASN1_I2D_len(a->object,i2d_ASN1_OBJECT);
-       M_ASN1_I2D_len(a->value,i2d_ASN1_PRINTABLE);
+/* Normally that's where it would end: we'd have two nested STACK structures
+ * representing the ASN1. Unfortunately X509_NAME uses a completely different
+ * form and caches encodings so we have to process the internal form and convert
+ * to the external form.
+ */
+
+const ASN1_EXTERN_FUNCS x509_name_ff = {
+       NULL,
+       x509_name_ex_new,
+       x509_name_ex_free,
+       0,      /* Default clear behaviour is OK */
+       x509_name_ex_d2i,
+       x509_name_ex_i2d,
+       x509_name_ex_print
+};
+
+IMPLEMENT_EXTERN_ASN1(X509_NAME, V_ASN1_SEQUENCE, x509_name_ff) 
+
+IMPLEMENT_ASN1_FUNCTIONS(X509_NAME)
+IMPLEMENT_ASN1_DUP_FUNCTION(X509_NAME)
+
+static int x509_name_ex_new(ASN1_VALUE **val, const ASN1_ITEM *it)
+{
+       X509_NAME *ret = NULL;
+       ret = OPENSSL_malloc(sizeof(X509_NAME));
+       if(!ret) goto memerr;
+       if ((ret->entries=sk_X509_NAME_ENTRY_new_null()) == NULL)
+               goto memerr;
+       if((ret->bytes = BUF_MEM_new()) == NULL) goto memerr;
+       ret->canon_enc = NULL;
+       ret->canon_enclen = 0;
+       ret->modified=1;
+       *val = (ASN1_VALUE *)ret;
+       return 1;
 
-       M_ASN1_I2D_seq_total();
+ memerr:
+       ASN1err(ASN1_F_X509_NAME_EX_NEW, ERR_R_MALLOC_FAILURE);
+       if (ret)
+               {
+               if (ret->entries)
+                       sk_X509_NAME_ENTRY_free(ret->entries);
+               OPENSSL_free(ret);
+               }
+       return 0;
+}
 
-       M_ASN1_I2D_put(a->object,i2d_ASN1_OBJECT);
-       M_ASN1_I2D_put(a->value,i2d_ASN1_PRINTABLE);
+static void x509_name_ex_free(ASN1_VALUE **pval, const ASN1_ITEM *it)
+{
+       X509_NAME *a;
+       if(!pval || !*pval)
+           return;
+       a = (X509_NAME *)*pval;
 
-       M_ASN1_I2D_finish();
+       BUF_MEM_free(a->bytes);
+       sk_X509_NAME_ENTRY_pop_free(a->entries,X509_NAME_ENTRY_free);
+       if (a->canon_enc)
+               OPENSSL_free(a->canon_enc);
+       OPENSSL_free(a);
+       *pval = NULL;
+}
+
+static int x509_name_ex_d2i(ASN1_VALUE **val,
+                       const unsigned char **in, long len, const ASN1_ITEM *it,
+                               int tag, int aclass, char opt, ASN1_TLC *ctx)
+{
+       const unsigned char *p = *in, *q;
+       union { STACK_OF(STACK_OF_X509_NAME_ENTRY) *s;
+               ASN1_VALUE *a; } intname = {NULL};
+       union { X509_NAME *x; ASN1_VALUE *a; } nm = {NULL};
+       int i, j, ret;
+       STACK_OF(X509_NAME_ENTRY) *entries;
+       X509_NAME_ENTRY *entry;
+       q = p;
+
+       /* Get internal representation of Name */
+       ret = ASN1_item_ex_d2i(&intname.a,
+                              &p, len, ASN1_ITEM_rptr(X509_NAME_INTERNAL),
+                              tag, aclass, opt, ctx);
+       
+       if(ret <= 0) return ret;
+
+       if(*val) x509_name_ex_free(val, NULL);
+       if(!x509_name_ex_new(&nm.a, NULL)) goto err;
+       /* We've decoded it: now cache encoding */
+       if(!BUF_MEM_grow(nm.x->bytes, p - q)) goto err;
+       memcpy(nm.x->bytes->data, q, p - q);
+
+       /* Convert internal representation to X509_NAME structure */
+       for(i = 0; i < sk_STACK_OF_X509_NAME_ENTRY_num(intname.s); i++) {
+               entries = sk_STACK_OF_X509_NAME_ENTRY_value(intname.s, i);
+               for(j = 0; j < sk_X509_NAME_ENTRY_num(entries); j++) {
+                       entry = sk_X509_NAME_ENTRY_value(entries, j);
+                       entry->set = i;
+                       if(!sk_X509_NAME_ENTRY_push(nm.x->entries, entry))
+                               goto err;
+               }
+               sk_X509_NAME_ENTRY_free(entries);
+       }
+       sk_STACK_OF_X509_NAME_ENTRY_free(intname.s);
+       ret = x509_name_canon(nm.x);
+       if (!ret)
+               goto err;
+       nm.x->modified = 0;
+       *val = nm.a;
+       *in = p;
+       return ret;
+err:
+        if (nm.x != NULL)
+               X509_NAME_free(nm.x);
+       ASN1err(ASN1_F_X509_NAME_EX_D2I, ERR_R_NESTED_ASN1_ERROR);
+       return 0;
+}
+
+static int x509_name_ex_i2d(ASN1_VALUE **val, unsigned char **out, const ASN1_ITEM *it, int tag, int aclass)
+{
+       int ret;
+       X509_NAME *a = (X509_NAME *)*val;
+       if(a->modified) {
+               ret = x509_name_encode(a);
+               if(ret < 0)
+                       return ret;
+               ret = x509_name_canon(a);
+               if(ret < 0)
+                       return ret;
+       }
+       ret = a->bytes->length;
+       if(out != NULL) {
+               memcpy(*out,a->bytes->data,ret);
+               *out+=ret;
        }
+       return ret;
+}
 
-X509_NAME_ENTRY *d2i_X509_NAME_ENTRY(a,pp,length)
-X509_NAME_ENTRY **a;
-unsigned char **pp;
-long length;
+static void local_sk_X509_NAME_ENTRY_free(STACK_OF(X509_NAME_ENTRY) *ne)
        {
-       M_ASN1_D2I_vars(a,X509_NAME_ENTRY *,X509_NAME_ENTRY_new);
-
-       M_ASN1_D2I_Init();
-       M_ASN1_D2I_start_sequence();
-       M_ASN1_D2I_get(ret->object,d2i_ASN1_OBJECT);
-       M_ASN1_D2I_get(ret->value,d2i_ASN1_PRINTABLE);
-       ret->set=0;
-       M_ASN1_D2I_Finish(a,X509_NAME_ENTRY_free,ASN1_F_D2I_X509_NAME_ENTRY);
+       sk_X509_NAME_ENTRY_free(ne);
        }
 
-int i2d_X509_NAME(a,pp)
-X509_NAME *a;
-unsigned char **pp;
+static void local_sk_X509_NAME_ENTRY_pop_free(STACK_OF(X509_NAME_ENTRY) *ne)
        {
-       int ret;
-
-       if (a == NULL) return(0);
-       if (a->modified)
-               {
-               ret=i2d_X509_NAME_entries(a);
-               if (ret < 0) return(ret);
-               }
+       sk_X509_NAME_ENTRY_pop_free(ne, X509_NAME_ENTRY_free);
+       }
 
-       ret=a->bytes->length;
-       if (pp != NULL)
-               {
-               memcpy(*pp,a->bytes->data,ret);
-               *pp+=ret;
+static int x509_name_encode(X509_NAME *a)
+{
+       union { STACK_OF(STACK_OF_X509_NAME_ENTRY) *s;
+               ASN1_VALUE *a; } intname = {NULL};
+       int len;
+       unsigned char *p;
+       STACK_OF(X509_NAME_ENTRY) *entries = NULL;
+       X509_NAME_ENTRY *entry;
+       int i, set = -1;
+       intname.s = sk_STACK_OF_X509_NAME_ENTRY_new_null();
+       if(!intname.s) goto memerr;
+       for(i = 0; i < sk_X509_NAME_ENTRY_num(a->entries); i++) {
+               entry = sk_X509_NAME_ENTRY_value(a->entries, i);
+               if(entry->set != set) {
+                       entries = sk_X509_NAME_ENTRY_new_null();
+                       if(!entries) goto memerr;
+                       if(!sk_STACK_OF_X509_NAME_ENTRY_push(intname.s,
+                                                            entries))
+                               goto memerr;
+                       set = entry->set;
                }
-       return(ret);
+               if(!sk_X509_NAME_ENTRY_push(entries, entry)) goto memerr;
+       }
+       len = ASN1_item_ex_i2d(&intname.a, NULL,
+                              ASN1_ITEM_rptr(X509_NAME_INTERNAL), -1, -1);
+       if (!BUF_MEM_grow(a->bytes,len)) goto memerr;
+       p=(unsigned char *)a->bytes->data;
+       ASN1_item_ex_i2d(&intname.a,
+                        &p, ASN1_ITEM_rptr(X509_NAME_INTERNAL), -1, -1);
+       sk_STACK_OF_X509_NAME_ENTRY_pop_free(intname.s,
+                                            local_sk_X509_NAME_ENTRY_free);
+       a->modified = 0;
+       return len;
+memerr:
+       sk_STACK_OF_X509_NAME_ENTRY_pop_free(intname.s,
+                                            local_sk_X509_NAME_ENTRY_free);
+       ASN1err(ASN1_F_X509_NAME_ENCODE, ERR_R_MALLOC_FAILURE);
+       return -1;
+}
+
+static int x509_name_ex_print(BIO *out, ASN1_VALUE **pval,
+                                               int indent,
+                                               const char *fname, 
+                                               const ASN1_PCTX *pctx)
+       {
+       if (X509_NAME_print_ex(out, (X509_NAME *)*pval,
+                                       indent, pctx->nm_flags) <= 0)
+               return 0;
+       return 2;
        }
 
-static int i2d_X509_NAME_entries(a)
-X509_NAME *a;
+/* This function generates the canonical encoding of the Name structure.
+ * In it all strings are converted to UTF8, leading, trailing and
+ * multiple spaces collapsed, converted to lower case and the leading
+ * SEQUENCE header removed.
+ *
+ * In future we could also normalize the UTF8 too.
+ *
+ * By doing this comparison of Name structures can be rapidly
+ * perfomed by just using memcmp() of the canonical encoding.
+ * By omitting the leading SEQUENCE name constraints of type
+ * dirName can also be checked with a simple memcmp().
+ */
+
+static int x509_name_canon(X509_NAME *a)
        {
-       X509_NAME_ENTRY *ne,*fe=NULL;
-       STACK *sk;
-       BUF_MEM *buf=NULL;
-       int set=0,r,ret=0;
-       int i;
        unsigned char *p;
-       int size=0;
+       STACK_OF(STACK_OF_X509_NAME_ENTRY) *intname = NULL;
+       STACK_OF(X509_NAME_ENTRY) *entries = NULL;
+       X509_NAME_ENTRY *entry, *tmpentry = NULL;
+       int i, set = -1, ret = 0;
 
-       sk=a->entries;
-       for (i=0; i<sk_num(sk); i++)
+       if (a->canon_enc)
                {
-               ne=(X509_NAME_ENTRY *)sk_value(sk,i);
-               if (fe == NULL)
+               OPENSSL_free(a->canon_enc);
+               a->canon_enc = NULL;
+               }
+       /* Special case: empty X509_NAME => null encoding */
+       if (sk_X509_NAME_ENTRY_num(a->entries) == 0)
+               {
+               a->canon_enclen = 0;
+               return 1;
+               }
+       intname = sk_STACK_OF_X509_NAME_ENTRY_new_null();
+       if(!intname)
+               goto err;
+       for(i = 0; i < sk_X509_NAME_ENTRY_num(a->entries); i++)
+               {
+               entry = sk_X509_NAME_ENTRY_value(a->entries, i);
+               if(entry->set != set)
                        {
-                       fe=ne;
-                       size=0;
+                       entries = sk_X509_NAME_ENTRY_new_null();
+                       if(!entries)
+                               goto err;
+                       if(!sk_STACK_OF_X509_NAME_ENTRY_push(intname, entries))
+                               goto err;
+                       set = entry->set;
                        }
+               tmpentry = X509_NAME_ENTRY_new();
+               tmpentry->object = OBJ_dup(entry->object);
+               if (!asn1_string_canon(tmpentry->value, entry->value))
+                       goto err;
+               if(!sk_X509_NAME_ENTRY_push(entries, tmpentry))
+                       goto err;
+               tmpentry = NULL;
+               }
 
-               if (ne->set != set)
-                       {
-                       ret+=ASN1_object_size(1,size,V_ASN1_SET);
-                       fe->size=size;
-                       fe=ne;
-                       size=0;
-                       set=ne->set;
-                       }
-               size+=i2d_X509_NAME_ENTRY(ne,NULL);
+       /* Finally generate encoding */
+
+       a->canon_enclen = i2d_name_canon(intname, NULL);
+
+       p = OPENSSL_malloc(a->canon_enclen);
+
+       if (!p)
+               goto err;
+
+       a->canon_enc = p;
+
+       i2d_name_canon(intname, &p);
+
+       ret = 1;
+
+       err:
+
+       if (tmpentry)
+               X509_NAME_ENTRY_free(tmpentry);
+       if (intname)
+               sk_STACK_OF_X509_NAME_ENTRY_pop_free(intname,
+                                       local_sk_X509_NAME_ENTRY_pop_free);
+       return ret;
+       }
+
+/* Bitmap of all the types of string that will be canonicalized. */
+
+#define ASN1_MASK_CANON        \
+       (B_ASN1_UTF8STRING | B_ASN1_BMPSTRING | B_ASN1_UNIVERSALSTRING \
+       | B_ASN1_PRINTABLESTRING | B_ASN1_T61STRING | B_ASN1_IA5STRING \
+       | B_ASN1_VISIBLESTRING)
+       
+
+static int asn1_string_canon(ASN1_STRING *out, ASN1_STRING *in)
+       {
+       unsigned char *to, *from;
+       int len, i;
+
+       /* If type not in bitmask just copy string across */
+       if (!(ASN1_tag2bit(in->type) & ASN1_MASK_CANON))
+               {
+               out->type = in->type;
+               if (!ASN1_STRING_set(out, in->data, in->length))
+                       return 0;
+               return 1;
                }
 
-       ret+=ASN1_object_size(1,size,V_ASN1_SET);
-       if (fe != NULL)
-               fe->size=size;
+       out->type = V_ASN1_UTF8STRING;
+       out->length = ASN1_STRING_to_UTF8(&out->data, in);
+       if (out->length == -1)
+               return 0;
 
-       r=ASN1_object_size(1,ret,V_ASN1_SEQUENCE);
+       to = out->data;
+       from = to;
 
-       buf=a->bytes;
-       if (!BUF_MEM_grow(buf,r)) goto err;
-       p=(unsigned char *)buf->data;
+       len = out->length;
 
-       ASN1_put_object(&p,1,ret,V_ASN1_SEQUENCE,V_ASN1_UNIVERSAL);
+       /* Convert string in place to canonical form.
+        * Ultimately we may need to handle a wider range of characters
+        * but for now ignore anything with MSB set and rely on the
+        * isspace() and tolower() functions.
+        */
 
-       set= -1;
-       for (i=0; i<sk_num(sk); i++)
+       /* Ignore leading spaces */
+       while((len > 0) && !(*from & 0x80) && isspace(*from))
                {
-               ne=(X509_NAME_ENTRY *)sk_value(sk,i);
-               if (set != ne->set)
-                       {
-                       set=ne->set;
-                       ASN1_put_object(&p,1,ne->size,
-                               V_ASN1_SET,V_ASN1_UNIVERSAL);
-                       }
-               i2d_X509_NAME_ENTRY(ne,&p);
+               from++;
+               len--;
                }
-       a->modified=0;
-       return(r);
-err:
-       return(-1);
-       }
 
-X509_NAME *d2i_X509_NAME(a,pp,length)
-X509_NAME **a;
-unsigned char **pp;
-long length;
-       {
-       int set=0,i;
-       int idx=0;
-       unsigned char *orig;
-       M_ASN1_D2I_vars(a,X509_NAME *,X509_NAME_new);
+       to = from + len - 1;
 
-       orig= *pp;
-       if (sk_num(ret->entries) > 0)
+       /* Ignore trailing spaces */
+       while ((len > 0) && !(*to & 0x80) && isspace(*to))
                {
-               while (sk_num(ret->entries) > 0)
-                       X509_NAME_ENTRY_free((X509_NAME_ENTRY *)
-                               sk_pop(ret->entries));
+               to--;
+               len--;
                }
 
-       M_ASN1_D2I_Init();
-       M_ASN1_D2I_start_sequence();
-       for (;;)
+       to = out->data;
+
+       i = 0;
+       while(i < len)
                {
-               if (M_ASN1_D2I_end_sequence()) break;
-               M_ASN1_D2I_get_set(ret->entries,d2i_X509_NAME_ENTRY);
-               for (; idx < sk_num(ret->entries); idx++)
+               /* If MSB set just copy across */
+               if (*from & 0x80)
+                       {
+                       *to++ = *from++;
+                       i++;
+                       }
+               /* Collapse multiple spaces */
+               else if (isspace(*from))
+                       {
+                       /* Copy one space across */
+                       *to++ = ' ';
+                       /* Ignore subsequent spaces. Note: don't need to
+                        * check len here because we know the last 
+                        * character is a non-space so we can't overflow.
+                        */
+                       do
+                               {
+                               from++;
+                               i++;
+                               }
+                       while(!(*from & 0x80) && isspace(*from));
+                       }
+               else
                        {
-                       ((X509_NAME_ENTRY *)sk_value(ret->entries,idx))->set=
-                               set;
+                       *to++ = tolower(*from);
+                       from++;
+                       i++;
                        }
-               set++;
                }
 
-       i=(int)(c.p-orig);
-       if (!BUF_MEM_grow(ret->bytes,i)) goto err;
-       memcpy(ret->bytes->data,orig,i);
-       ret->bytes->length=i;
-       ret->modified=0;
-
-       M_ASN1_D2I_Finish(a,X509_NAME_free,ASN1_F_D2I_X509_NAME);
-       }
-
-X509_NAME *X509_NAME_new()
-       {
-       X509_NAME *ret=NULL;
+       out->length = to - out->data;
 
-       M_ASN1_New_Malloc(ret,X509_NAME);
-       if ((ret->entries=sk_new(NULL)) == NULL) goto err2;
-       M_ASN1_New(ret->bytes,BUF_MEM_new);
-       ret->modified=1;
-       return(ret);
-       M_ASN1_New_Error(ASN1_F_X509_NAME_NEW);
-       }
+       return 1;
 
-X509_NAME_ENTRY *X509_NAME_ENTRY_new()
-       {
-       X509_NAME_ENTRY *ret=NULL;
-
-       M_ASN1_New_Malloc(ret,X509_NAME_ENTRY);
-/*     M_ASN1_New(ret->object,ASN1_OBJECT_new);*/
-       ret->object=NULL;
-       ret->set=0;
-       M_ASN1_New(ret->value,ASN1_STRING_new);
-       return(ret);
-       M_ASN1_New_Error(ASN1_F_X509_NAME_ENTRY_NEW);
        }
 
-void X509_NAME_free(a)
-X509_NAME *a;
+static int i2d_name_canon(STACK_OF(STACK_OF_X509_NAME_ENTRY) *_intname,
+                         unsigned char **in)
        {
-       BUF_MEM_free(a->bytes);
-       sk_pop_free(a->entries,X509_NAME_ENTRY_free);
-       Free((char *)a);
-       }
+       int i, len, ltmp;
+       ASN1_VALUE *v;
+       STACK_OF(ASN1_VALUE) *intname = (STACK_OF(ASN1_VALUE) *)_intname;
 
-void X509_NAME_ENTRY_free(a)
-X509_NAME_ENTRY *a;
-       {
-       if (a == NULL) return;
-       ASN1_OBJECT_free(a->object);
-       ASN1_BIT_STRING_free(a->value);
-       Free((char *)a);
+       len = 0;
+       for (i = 0; i < sk_ASN1_VALUE_num(intname); i++)
+               {
+               v = sk_ASN1_VALUE_value(intname, i);
+               ltmp = ASN1_item_ex_i2d(&v, in,
+                       ASN1_ITEM_rptr(X509_NAME_ENTRIES), -1, -1);
+               if (ltmp < 0)
+                       return ltmp;
+               len += ltmp;
+               }
+       return len;
        }
 
-int X509_NAME_set(xn,name)
-X509_NAME **xn;
-X509_NAME *name;
+int X509_NAME_set(X509_NAME **xn, X509_NAME *name)
        {
        X509_NAME *in;
 
-       if (*xn == NULL) return(0);
+       if (!xn || !name) return(0);
 
        if (*xn != name)
                {
@@ -293,3 +516,5 @@ X509_NAME *name;
        return(*xn != NULL);
        }
        
+IMPLEMENT_STACK_OF(X509_NAME_ENTRY)
+IMPLEMENT_ASN1_SET_OF(X509_NAME_ENTRY)