Change safestack reimplementation to match 0.9.8.
[openssl.git] / crypto / asn1 / x_crl.c
index 39fe8916fa4fab18b5195afa59553583f6dfbc42..d7093df9da82c758c8c0ee8a99ed243d17994c67 100644 (file)
 
 #include <stdio.h>
 #include "cryptlib.h"
-#include <openssl/asn1_mac.h>
+#include "asn1_locl.h"
+#include <openssl/asn1t.h>
 #include <openssl/x509.h>
+#include <openssl/x509v3.h>
 
 static int X509_REVOKED_cmp(const X509_REVOKED * const *a,
                                const X509_REVOKED * const *b);
-static int X509_REVOKED_seq_cmp(const X509_REVOKED * const *a,
-                               const X509_REVOKED * const *b);
-int i2d_X509_REVOKED(X509_REVOKED *a, unsigned char **pp)
-       {
-       M_ASN1_I2D_vars(a);
+static void setup_idp(X509_CRL *crl, ISSUING_DIST_POINT *idp);
 
-       M_ASN1_I2D_len(a->serialNumber,i2d_ASN1_INTEGER);
-       M_ASN1_I2D_len(a->revocationDate,i2d_ASN1_TIME);
-       M_ASN1_I2D_len_SEQUENCE_opt_type(X509_EXTENSION,a->extensions,
-                                        i2d_X509_EXTENSION);
+ASN1_SEQUENCE(X509_REVOKED) = {
+       ASN1_SIMPLE(X509_REVOKED,serialNumber, ASN1_INTEGER),
+       ASN1_SIMPLE(X509_REVOKED,revocationDate, ASN1_TIME),
+       ASN1_SEQUENCE_OF_OPT(X509_REVOKED,extensions, X509_EXTENSION)
+} ASN1_SEQUENCE_END(X509_REVOKED)
 
-       M_ASN1_I2D_seq_total();
+static int def_crl_verify(X509_CRL *crl, EVP_PKEY *r);
+static int def_crl_lookup(X509_CRL *crl,
+               X509_REVOKED **ret, ASN1_INTEGER *serial);
 
-       M_ASN1_I2D_put(a->serialNumber,i2d_ASN1_INTEGER);
-       M_ASN1_I2D_put(a->revocationDate,i2d_ASN1_TIME);
-       M_ASN1_I2D_put_SEQUENCE_opt_type(X509_EXTENSION,a->extensions,
-                                        i2d_X509_EXTENSION);
+static X509_CRL_METHOD int_crl_meth =
+       {
+       0,
+       0,0,
+       def_crl_lookup,
+       def_crl_verify
+       };
 
-       M_ASN1_I2D_finish();
-       }
+static const X509_CRL_METHOD *default_crl_method = &int_crl_meth;
 
-X509_REVOKED *d2i_X509_REVOKED(X509_REVOKED **a, unsigned char **pp,
-            long length)
-       {
-       M_ASN1_D2I_vars(a,X509_REVOKED *,X509_REVOKED_new);
-
-       M_ASN1_D2I_Init();
-       M_ASN1_D2I_start_sequence();
-       M_ASN1_D2I_get(ret->serialNumber,d2i_ASN1_INTEGER);
-       M_ASN1_D2I_get(ret->revocationDate,d2i_ASN1_TIME);
-       M_ASN1_D2I_get_seq_opt_type(X509_EXTENSION,ret->extensions,
-                                   d2i_X509_EXTENSION,X509_EXTENSION_free);
-       M_ASN1_D2I_Finish(a,X509_REVOKED_free,ASN1_F_D2I_X509_REVOKED);
+/* The X509_CRL_INFO structure needs a bit of customisation.
+ * Since we cache the original encoding the signature wont be affected by
+ * reordering of the revoked field.
+ */
+static int crl_inf_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
+                                                               void *exarg)
+{
+       X509_CRL_INFO *a = (X509_CRL_INFO *)*pval;
+
+       if(!a || !a->revoked) return 1;
+       switch(operation) {
+               /* Just set cmp function here. We don't sort because that
+                * would affect the output of X509_CRL_print().
+                */
+               case ASN1_OP_D2I_POST:
+               (void)sk_X509_REVOKED_set_cmp_func(a->revoked,X509_REVOKED_cmp);
+               break;
        }
-
-int i2d_X509_CRL_INFO(X509_CRL_INFO *a, unsigned char **pp)
+       return 1;
+}
+
+
+ASN1_SEQUENCE_enc(X509_CRL_INFO, enc, crl_inf_cb) = {
+       ASN1_OPT(X509_CRL_INFO, version, ASN1_INTEGER),
+       ASN1_SIMPLE(X509_CRL_INFO, sig_alg, X509_ALGOR),
+       ASN1_SIMPLE(X509_CRL_INFO, issuer, X509_NAME),
+       ASN1_SIMPLE(X509_CRL_INFO, lastUpdate, ASN1_TIME),
+       ASN1_OPT(X509_CRL_INFO, nextUpdate, ASN1_TIME),
+       ASN1_SEQUENCE_OF_OPT(X509_CRL_INFO, revoked, X509_REVOKED),
+       ASN1_EXP_SEQUENCE_OF_OPT(X509_CRL_INFO, extensions, X509_EXTENSION, 0)
+} ASN1_SEQUENCE_END_enc(X509_CRL_INFO, X509_CRL_INFO)
+
+/* The X509_CRL structure needs a bit of customisation. Cache some extensions
+ * and hash of the whole CRL.
+ */
+static int crl_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
+                                                               void *exarg)
        {
-       int v1=0;
-       long l=0;
-       int (*old_cmp)(const X509_REVOKED * const *,
-                       const X509_REVOKED * const *);
-       M_ASN1_I2D_vars(a);
-       
-       old_cmp=sk_X509_REVOKED_set_cmp_func(a->revoked,X509_REVOKED_seq_cmp);
-       sk_X509_REVOKED_sort(a->revoked);
-       sk_X509_REVOKED_set_cmp_func(a->revoked,old_cmp);
-
-       if ((a->version != NULL) && ((l=ASN1_INTEGER_get(a->version)) != 0))
-               {
-               M_ASN1_I2D_len(a->version,i2d_ASN1_INTEGER);
-               }
-       M_ASN1_I2D_len(a->sig_alg,i2d_X509_ALGOR);
-       M_ASN1_I2D_len(a->issuer,i2d_X509_NAME);
-       M_ASN1_I2D_len(a->lastUpdate,i2d_ASN1_TIME);
-       if (a->nextUpdate != NULL)
-               { M_ASN1_I2D_len(a->nextUpdate,i2d_ASN1_TIME); }
-       M_ASN1_I2D_len_SEQUENCE_opt_type(X509_REVOKED,a->revoked,
-                                        i2d_X509_REVOKED);
-       M_ASN1_I2D_len_EXP_SEQUENCE_opt_type(X509_EXTENSION,a->extensions,
-                                            i2d_X509_EXTENSION,0,
-                                            V_ASN1_SEQUENCE,v1);
-
-       M_ASN1_I2D_seq_total();
-
-       if ((a->version != NULL) && (l != 0))
+       X509_CRL *crl = (X509_CRL *)*pval;
+       STACK_OF(X509_EXTENSION) *exts;
+       X509_EXTENSION *ext;
+       int idx;
+
+       switch(operation)
                {
-               M_ASN1_I2D_put(a->version,i2d_ASN1_INTEGER);
+               case ASN1_OP_NEW_POST:
+               crl->idp = NULL;
+               crl->akid = NULL;
+               crl->flags = 0;
+               crl->idp_flags = 0;
+               crl->meth = default_crl_method;
+               crl->meth_data = NULL;
+               break;
+
+               case ASN1_OP_D2I_POST:
+#ifndef OPENSSL_NO_SHA
+               X509_CRL_digest(crl, EVP_sha1(), crl->sha1_hash, NULL);
+#endif
+               crl->idp = X509_CRL_get_ext_d2i(crl,
+                               NID_issuing_distribution_point, NULL, NULL);
+               if (crl->idp)
+                       setup_idp(crl, crl->idp);
+
+               crl->akid = X509_CRL_get_ext_d2i(crl,
+                               NID_authority_key_identifier, NULL, NULL);      
+
+               /* See if we have any unhandled critical CRL extensions and 
+                * indicate this in a flag. We only currently handle IDP so
+                * anything else critical sets the flag.
+                *
+                * This code accesses the X509_CRL structure directly:
+                * applications shouldn't do this.
+                */
+
+               exts = crl->crl->extensions;
+
+               for (idx = 0; idx < sk_X509_EXTENSION_num(exts); idx++)
+                       {
+                       ext = sk_X509_EXTENSION_value(exts, idx);
+                       if (ext->critical > 0)
+                               {
+                               /* We handle IDP now so permit it */
+                               if (OBJ_obj2nid(ext->object) ==
+                                       NID_issuing_distribution_point)
+                                       continue;
+                               crl->flags |= EXFLAG_CRITICAL;
+                               break;
+                               }
+                       }
+               if (crl->meth->crl_init)
+                       {
+                       if (crl->meth->crl_init(crl) == 0)
+                               return 0;
+                       }
+               break;
+
+               case ASN1_OP_FREE_POST:
+               if (crl->meth->crl_free)
+                       {
+                       if (!crl->meth->crl_free(crl))
+                               return 0;
+                       }
+               if (crl->akid)
+                       AUTHORITY_KEYID_free(crl->akid);
+               if (crl->idp)
+                       ISSUING_DIST_POINT_free(crl->idp);
+               break;
                }
-       M_ASN1_I2D_put(a->sig_alg,i2d_X509_ALGOR);
-       M_ASN1_I2D_put(a->issuer,i2d_X509_NAME);
-       M_ASN1_I2D_put(a->lastUpdate,i2d_ASN1_TIME);
-       if (a->nextUpdate != NULL)
-               { M_ASN1_I2D_put(a->nextUpdate,i2d_ASN1_TIME); }
-       M_ASN1_I2D_put_SEQUENCE_opt_type(X509_REVOKED,a->revoked,
-                                        i2d_X509_REVOKED);
-       M_ASN1_I2D_put_EXP_SEQUENCE_opt_type(X509_EXTENSION,a->extensions,
-                                            i2d_X509_EXTENSION,0,
-                                            V_ASN1_SEQUENCE,v1);
-
-       M_ASN1_I2D_finish();
+       return 1;
        }
 
-X509_CRL_INFO *d2i_X509_CRL_INFO(X509_CRL_INFO **a, unsigned char **pp,
-            long length)
-       {
-       int i,ver=0;
-       M_ASN1_D2I_vars(a,X509_CRL_INFO *,X509_CRL_INFO_new);
-
+/* Convert IDP into a more convenient form */
 
-       M_ASN1_D2I_Init();
-       M_ASN1_D2I_start_sequence();
-       M_ASN1_D2I_get_opt(ret->version,d2i_ASN1_INTEGER,V_ASN1_INTEGER);
-       if (ret->version != NULL)
-               ver=ret->version->data[0];
-       
-       if ((ver == 0) && (ret->version != NULL))
+static void setup_idp(X509_CRL *crl, ISSUING_DIST_POINT *idp)
+       {
+       int idp_only = 0;
+       /* Set various flags according to IDP */
+       crl->idp_flags |= IDP_PRESENT;
+       if (idp->onlyuser > 0)
                {
-               M_ASN1_INTEGER_free(ret->version);
-               ret->version=NULL;
+               idp_only++;
+               crl->idp_flags |= IDP_ONLYUSER;
                }
-       M_ASN1_D2I_get(ret->sig_alg,d2i_X509_ALGOR);
-       M_ASN1_D2I_get(ret->issuer,d2i_X509_NAME);
-       M_ASN1_D2I_get(ret->lastUpdate,d2i_ASN1_TIME);
-       /* Manually handle the OPTIONAL ASN1_TIME stuff */
-       /* First try UTCTime */
-       M_ASN1_D2I_get_opt(ret->nextUpdate,d2i_ASN1_UTCTIME, V_ASN1_UTCTIME);
-       /* If that doesn't work try GeneralizedTime */
-       if(!ret->nextUpdate) 
-               M_ASN1_D2I_get_opt(ret->nextUpdate,d2i_ASN1_GENERALIZEDTIME,
-                                                       V_ASN1_GENERALIZEDTIME);
-       if (ret->revoked != NULL)
+       if (idp->onlyCA > 0)
                {
-               while (sk_X509_REVOKED_num(ret->revoked))
-                       X509_REVOKED_free(sk_X509_REVOKED_pop(ret->revoked));
+               idp_only++;
+               crl->idp_flags |= IDP_ONLYCA;
                }
-       M_ASN1_D2I_get_seq_opt_type(X509_REVOKED,ret->revoked,d2i_X509_REVOKED,
-                                   X509_REVOKED_free);
-
-       if (ret->revoked != NULL)
+       if (idp->onlyattr > 0)
                {
-               for (i=0; i<sk_X509_REVOKED_num(ret->revoked); i++)
-                       {
-                       sk_X509_REVOKED_value(ret->revoked,i)->sequence=i;
-                       }
+               idp_only++;
+               crl->idp_flags |= IDP_ONLYATTR;
                }
 
-       if (ret->extensions != NULL)
+       if (idp_only > 1)
+               crl->idp_flags |= IDP_INVALID;
+
+       if (idp->indirectCRL > 0)
+               crl->idp_flags |= IDP_INDIRECT;
+
+       if (idp->onlysomereasons)
                {
-               while (sk_X509_EXTENSION_num(ret->extensions))
-                       X509_EXTENSION_free(
-                       sk_X509_EXTENSION_pop(ret->extensions));
+               crl->idp_flags |= IDP_REASONS;
+               if (idp->onlysomereasons->length > 0)
+                       crl->idp_reasons = idp->onlysomereasons->data[0];
+               if (idp->onlysomereasons->length > 1)
+                       crl->idp_reasons |=
+                               (idp->onlysomereasons->data[1] << 8);
                }
-               
-       M_ASN1_D2I_get_EXP_set_opt_type(X509_EXTENSION,ret->extensions,
-                                       d2i_X509_EXTENSION,
-                                       X509_EXTENSION_free,0,
-                                       V_ASN1_SEQUENCE);
-
-       M_ASN1_D2I_Finish(a,X509_CRL_INFO_free,ASN1_F_D2I_X509_CRL_INFO);
        }
 
-int i2d_X509_CRL(X509_CRL *a, unsigned char **pp)
-       {
-       M_ASN1_I2D_vars(a);
-
-       M_ASN1_I2D_len(a->crl,i2d_X509_CRL_INFO);
-       M_ASN1_I2D_len(a->sig_alg,i2d_X509_ALGOR);
-       M_ASN1_I2D_len(a->signature,i2d_ASN1_BIT_STRING);
+ASN1_SEQUENCE_ref(X509_CRL, crl_cb, CRYPTO_LOCK_X509_CRL) = {
+       ASN1_SIMPLE(X509_CRL, crl, X509_CRL_INFO),
+       ASN1_SIMPLE(X509_CRL, sig_alg, X509_ALGOR),
+       ASN1_SIMPLE(X509_CRL, signature, ASN1_BIT_STRING)
+} ASN1_SEQUENCE_END_ref(X509_CRL, X509_CRL)
 
-       M_ASN1_I2D_seq_total();
+IMPLEMENT_ASN1_FUNCTIONS(X509_REVOKED)
+IMPLEMENT_ASN1_FUNCTIONS(X509_CRL_INFO)
+IMPLEMENT_ASN1_FUNCTIONS(X509_CRL)
+IMPLEMENT_ASN1_DUP_FUNCTION(X509_CRL)
 
-       M_ASN1_I2D_put(a->crl,i2d_X509_CRL_INFO);
-       M_ASN1_I2D_put(a->sig_alg,i2d_X509_ALGOR);
-       M_ASN1_I2D_put(a->signature,i2d_ASN1_BIT_STRING);
+static int X509_REVOKED_cmp(const X509_REVOKED * const *a,
+                       const X509_REVOKED * const *b)
+       {
+       return(ASN1_STRING_cmp(
+               (ASN1_STRING *)(*a)->serialNumber,
+               (ASN1_STRING *)(*b)->serialNumber));
+       }
 
-       M_ASN1_I2D_finish();
+int X509_CRL_add0_revoked(X509_CRL *crl, X509_REVOKED *rev)
+{
+       X509_CRL_INFO *inf;
+       inf = crl->crl;
+       if(!inf->revoked)
+               inf->revoked = sk_X509_REVOKED_new(X509_REVOKED_cmp);
+       if(!inf->revoked || !sk_X509_REVOKED_push(inf->revoked, rev)) {
+               ASN1err(ASN1_F_X509_CRL_ADD0_REVOKED, ERR_R_MALLOC_FAILURE);
+               return 0;
        }
+       inf->enc.modified = 1;
+       return 1;
+}
 
-X509_CRL *d2i_X509_CRL(X509_CRL **a, unsigned char **pp, long length)
+int X509_CRL_verify(X509_CRL *crl, EVP_PKEY *r)
        {
-       M_ASN1_D2I_vars(a,X509_CRL *,X509_CRL_new);
-
-       M_ASN1_D2I_Init();
-       M_ASN1_D2I_start_sequence();
-       M_ASN1_D2I_get(ret->crl,d2i_X509_CRL_INFO);
-       M_ASN1_D2I_get(ret->sig_alg,d2i_X509_ALGOR);
-       M_ASN1_D2I_get(ret->signature,d2i_ASN1_BIT_STRING);
-
-       M_ASN1_D2I_Finish(a,X509_CRL_free,ASN1_F_D2I_X509_CRL);
+       if (crl->meth->crl_verify)
+               return crl->meth->crl_verify(crl, r);
+       return 0;
        }
 
-
-X509_REVOKED *X509_REVOKED_new(void)
+int X509_CRL_get0_by_serial(X509_CRL *crl,
+               X509_REVOKED **ret, ASN1_INTEGER *serial)
        {
-       X509_REVOKED *ret=NULL;
-       ASN1_CTX c;
-
-       M_ASN1_New_Malloc(ret,X509_REVOKED);
-       M_ASN1_New(ret->serialNumber,M_ASN1_INTEGER_new);
-       M_ASN1_New(ret->revocationDate,M_ASN1_UTCTIME_new);
-       ret->extensions=NULL;
-       return(ret);
-       M_ASN1_New_Error(ASN1_F_X509_REVOKED_NEW);
+       if (crl->meth->crl_lookup)
+               return crl->meth->crl_lookup(crl, ret, serial);
+       return 0;
        }
 
-X509_CRL_INFO *X509_CRL_INFO_new(void)
+static int def_crl_verify(X509_CRL *crl, EVP_PKEY *r)
        {
-       X509_CRL_INFO *ret=NULL;
-       ASN1_CTX c;
-
-       M_ASN1_New_Malloc(ret,X509_CRL_INFO);
-       ret->version=NULL;
-       M_ASN1_New(ret->sig_alg,X509_ALGOR_new);
-       M_ASN1_New(ret->issuer,X509_NAME_new);
-       M_ASN1_New(ret->lastUpdate,M_ASN1_UTCTIME_new);
-       ret->nextUpdate=NULL;
-       M_ASN1_New(ret->revoked,sk_X509_REVOKED_new_null);
-       M_ASN1_New(ret->extensions,sk_X509_EXTENSION_new_null);
-       sk_X509_REVOKED_set_cmp_func(ret->revoked,X509_REVOKED_cmp);
-       return(ret);
-       M_ASN1_New_Error(ASN1_F_X509_CRL_INFO_NEW);
+       return(ASN1_item_verify(ASN1_ITEM_rptr(X509_CRL_INFO),
+               crl->sig_alg, crl->signature,crl->crl,r));
        }
 
-X509_CRL *X509_CRL_new(void)
+static int def_crl_lookup(X509_CRL *crl,
+               X509_REVOKED **ret, ASN1_INTEGER *serial)
        {
-       X509_CRL *ret=NULL;
-       ASN1_CTX c;
-
-       M_ASN1_New_Malloc(ret,X509_CRL);
-       ret->references=1;
-       M_ASN1_New(ret->crl,X509_CRL_INFO_new);
-       M_ASN1_New(ret->sig_alg,X509_ALGOR_new);
-       M_ASN1_New(ret->signature,M_ASN1_BIT_STRING_new);
-       return(ret);
-       M_ASN1_New_Error(ASN1_F_X509_CRL_NEW);
+       X509_REVOKED rtmp;
+       int idx;
+       rtmp.serialNumber = serial;
+       /* Sort revoked into serial number order if not already sorted.
+        * Do this under a lock to avoid race condition.
+        */
+       if (!sk_X509_REVOKED_is_sorted(crl->crl->revoked))
+               {
+               CRYPTO_w_lock(CRYPTO_LOCK_X509_CRL);
+               sk_X509_REVOKED_sort(crl->crl->revoked);
+               CRYPTO_w_unlock(CRYPTO_LOCK_X509_CRL);
+               }
+       idx = sk_X509_REVOKED_find(crl->crl->revoked, &rtmp);
+       /* If found assume revoked: want something cleverer than
+        * this to handle entry extensions in V2 CRLs.
+        */
+       if(idx >= 0)
+               {
+               if (ret)
+                       *ret = sk_X509_REVOKED_value(crl->crl->revoked, idx);
+               return 1;
+               }
+       return 0;
        }
 
-void X509_REVOKED_free(X509_REVOKED *a)
+void X509_CRL_set_default_method(const X509_CRL_METHOD *meth)
        {
-       if (a == NULL) return;
-       M_ASN1_INTEGER_free(a->serialNumber);
-       M_ASN1_UTCTIME_free(a->revocationDate);
-       sk_X509_EXTENSION_pop_free(a->extensions,X509_EXTENSION_free);
-       Free(a);
+       if (meth == NULL)
+               default_crl_method = &int_crl_meth;
+       else 
+               default_crl_method = meth;
        }
 
-void X509_CRL_INFO_free(X509_CRL_INFO *a)
+X509_CRL_METHOD *X509_CRL_METHOD_new(
+       int (*crl_init)(X509_CRL *crl),
+       int (*crl_free)(X509_CRL *crl),
+       int (*crl_lookup)(X509_CRL *crl, X509_REVOKED **ret, ASN1_INTEGER *ser),
+       int (*crl_verify)(X509_CRL *crl, EVP_PKEY *pk))
        {
-       if (a == NULL) return;
-       M_ASN1_INTEGER_free(a->version);
-       X509_ALGOR_free(a->sig_alg);
-       X509_NAME_free(a->issuer);
-       M_ASN1_UTCTIME_free(a->lastUpdate);
-       if (a->nextUpdate)
-               M_ASN1_UTCTIME_free(a->nextUpdate);
-       sk_X509_REVOKED_pop_free(a->revoked,X509_REVOKED_free);
-       sk_X509_EXTENSION_pop_free(a->extensions,X509_EXTENSION_free);
-       Free(a);
+       X509_CRL_METHOD *m;
+       m = OPENSSL_malloc(sizeof(X509_CRL_METHOD));
+       if (!m)
+               return NULL;
+       m->crl_init = crl_init;
+       m->crl_free = crl_free;
+       m->crl_lookup = crl_lookup;
+       m->crl_verify = crl_verify;
+       m->flags = X509_CRL_METHOD_DYNAMIC;
+       return m;
        }
 
-void X509_CRL_free(X509_CRL *a)
+void X509_CRL_METHOD_free(X509_CRL_METHOD *m)
        {
-       int i;
-
-       if (a == NULL) return;
-
-       i=CRYPTO_add(&a->references,-1,CRYPTO_LOCK_X509_CRL);
-#ifdef REF_PRINT
-       REF_PRINT("X509_CRL",a);
-#endif
-       if (i > 0) return;
-#ifdef REF_CHECK
-       if (i < 0)
-               {
-               fprintf(stderr,"X509_CRL_free, bad reference count\n");
-               abort();
-               }
-#endif
-
-       X509_CRL_INFO_free(a->crl);
-       X509_ALGOR_free(a->sig_alg);
-       M_ASN1_BIT_STRING_free(a->signature);
-       Free(a);
+       if (!(m->flags & X509_CRL_METHOD_DYNAMIC))
+               return;
+       OPENSSL_free(m);
        }
 
-static int X509_REVOKED_cmp(const X509_REVOKED * const *a,
-                       const X509_REVOKED * const *b)
+void X509_CRL_set_meth_data(X509_CRL *crl, void *dat)
        {
-       return(ASN1_STRING_cmp(
-               (ASN1_STRING *)(*a)->serialNumber,
-               (ASN1_STRING *)(*b)->serialNumber));
+       crl->meth_data = dat;
        }
 
-static int X509_REVOKED_seq_cmp(const X509_REVOKED * const *a,
-                               const X509_REVOKED * const *b)
+void *X509_CRL_get_meth_data(X509_CRL *crl)
        {
-       return((*a)->sequence-(*b)->sequence);
+       return crl->meth_data;
        }
 
 IMPLEMENT_STACK_OF(X509_REVOKED)