In ECPKParameters_print, output the private key length correctly
[openssl.git] / crypto / asn1 / t_pkey.c
index 48414449e5ea865f2e3f7c86754b7adfcae39ac2..06e85f3b4c25f37e505725411cacdbfe85af4f04 100644 (file)
  * copied and put under another distribution licence
  * [including the GNU Public Licence.]
  */
+/* ====================================================================
+ * Copyright 2002 Sun Microsystems, Inc. ALL RIGHTS RESERVED.
+ * Binary polynomial ECC support in OpenSSL originally developed by 
+ * SUN MICROSYSTEMS, INC., and contributed to the OpenSSL project.
+ */
 
 #include <stdio.h>
 #include "cryptlib.h"
+#include <openssl/objects.h>
 #include <openssl/buffer.h>
 #include <openssl/bn.h>
 #ifndef OPENSSL_NO_RSA
 #ifndef OPENSSL_NO_DSA
 #include <openssl/dsa.h>
 #endif
-#ifndef OPENSSL_NO_ECDSA
-#include <openssl/ecdsa.h>
+#ifndef OPENSSL_NO_EC
+#include <openssl/ec.h>
 #endif
 
 static int print(BIO *fp,const char *str,BIGNUM *num,
                unsigned char *buf,int off);
+static int print_bin(BIO *fp, const char *str, const unsigned char *num,
+               size_t len, int off);
 #ifndef OPENSSL_NO_RSA
 #ifndef OPENSSL_NO_FP_API
 int RSA_print_fp(FILE *fp, const RSA *x, int off)
@@ -99,24 +107,44 @@ int RSA_print(BIO *bp, const RSA *x, int off)
        char str[128];
        const char *s;
        unsigned char *m=NULL;
-       int i,ret=0;
-
-       i=RSA_size(x);
-       m=(unsigned char *)OPENSSL_malloc((unsigned int)i+10);
+       int ret=0;
+       size_t buf_len=0, i;
+
+       if (x->n)
+               buf_len = (size_t)BN_num_bytes(x->n);
+       if (x->e)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->e)))
+                       buf_len = i;
+       if (x->d)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->d)))
+                       buf_len = i;
+       if (x->p)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->p)))
+                       buf_len = i;
+       if (x->q)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->q)))
+                       buf_len = i;
+       if (x->dmp1)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->dmp1)))
+                       buf_len = i;
+       if (x->dmq1)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->dmq1)))
+                       buf_len = i;
+       if (x->iqmp)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->iqmp)))
+                       buf_len = i;
+
+       m=(unsigned char *)OPENSSL_malloc(buf_len+10);
        if (m == NULL)
                {
                RSAerr(RSA_F_RSA_PRINT,ERR_R_MALLOC_FAILURE);
                goto err;
                }
 
-       if (off)
-               {
-               if (off > 128) off=128;
-               memset(str,' ',off);
-               }
        if (x->d != NULL)
                {
-               if (off && (BIO_write(bp,str,off) <= 0)) goto err;
+               if(!BIO_indent(bp,off,128))
+                  goto err;
                if (BIO_printf(bp,"Private-Key: (%d bit)\n",BN_num_bits(x->n))
                        <= 0) goto err;
                }
@@ -162,38 +190,36 @@ int DSA_print_fp(FILE *fp, const DSA *x, int off)
 
 int DSA_print(BIO *bp, const DSA *x, int off)
        {
-       char str[128];
        unsigned char *m=NULL;
-       int i,ret=0;
-       BIGNUM *bn=NULL;
-
-       if (x->p != NULL)
-               bn=x->p;
-       else if (x->priv_key != NULL)
-               bn=x->priv_key;
-       else if (x->pub_key != NULL)
-               bn=x->pub_key;
-               
-       /* larger than needed but what the hell :-) */
-       if (bn != NULL)
-               i=BN_num_bytes(bn)*2;
-       else
-               i=256;
-       m=(unsigned char *)OPENSSL_malloc((unsigned int)i+10);
+       int ret=0;
+       size_t buf_len=0,i;
+
+       if (x->p)
+               buf_len = (size_t)BN_num_bytes(x->p);
+       if (x->q)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->q)))
+                       buf_len = i;
+       if (x->g)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->g)))
+                       buf_len = i;
+       if (x->priv_key)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->priv_key)))
+                       buf_len = i;
+       if (x->pub_key)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->pub_key)))
+                       buf_len = i;
+
+       m=(unsigned char *)OPENSSL_malloc(buf_len+10);
        if (m == NULL)
                {
                DSAerr(DSA_F_DSA_PRINT,ERR_R_MALLOC_FAILURE);
                goto err;
                }
 
-       if (off)
-               {
-               if (off > 128) off=128;
-               memset(str,' ',off);
-               }
        if (x->priv_key != NULL)
                {
-               if (off && (BIO_write(bp,str,off) <= 0)) goto err;
+               if(!BIO_indent(bp,off,128))
+                  goto err;
                if (BIO_printf(bp,"Private-Key: (%d bit)\n",BN_num_bits(x->p))
                        <= 0) goto err;
                }
@@ -212,142 +238,328 @@ err:
        }
 #endif /* !OPENSSL_NO_DSA */
 
-#ifndef OPENSSL_NO_ECDSA
+#ifndef OPENSSL_NO_EC
 #ifndef OPENSSL_NO_FP_API
-int ECDSA_print_fp(FILE *fp, const ECDSA *x, int off)
-{
+int ECPKParameters_print_fp(FILE *fp, const EC_GROUP *x, int off)
+       {
        BIO *b;
        int ret;
+
        if ((b=BIO_new(BIO_s_file())) == NULL)
-       {
-               ECDSAerr(ECDSA_F_ECDSA_PRINT_FP, ERR_R_BIO_LIB);
+               {
+               ECerr(EC_F_ECPKPARAMETERS_PRINT_FP,ERR_R_BUF_LIB);
                return(0);
+               }
+       BIO_set_fp(b, fp, BIO_NOCLOSE);
+       ret = ECPKParameters_print(b, x, off);
+       BIO_free(b);
+       return(ret);
        }
+
+int EC_KEY_print_fp(FILE *fp, const EC_KEY *x, int off)
+       {
+       BIO *b;
+       int ret;
+       if ((b=BIO_new(BIO_s_file())) == NULL)
+               {
+               ECerr(EC_F_EC_KEY_PRINT_FP, ERR_R_BIO_LIB);
+               return(0);
+               }
        BIO_set_fp(b, fp, BIO_NOCLOSE);
-       ret = ECDSA_print(b, x, off);
+       ret = EC_KEY_print(b, x, off);
        BIO_free(b);
        return(ret);
-}
+       }
 #endif
 
-int ECDSA_print(BIO *bp, const ECDSA *x, int off)
+int ECPKParameters_print(BIO *bp, const EC_GROUP *x, int off)
        {
-       char str[128];
        unsigned char *buffer=NULL;
-       int     i, buf_len=0, ret=0, reason=ERR_R_BIO_LIB;
-       BIGNUM  *tmp_1=NULL, *tmp_2=NULL, *tmp_3=NULL,
-               *tmp_4=NULL, *tmp_5=NULL, *tmp_6=NULL,
-               *tmp_7=NULL;
+       size_t  buf_len=0, i;
+       int     ret=0, reason=ERR_R_BIO_LIB;
        BN_CTX  *ctx=NULL;
        EC_POINT *point=NULL;
+       BIGNUM  *p=NULL, *a=NULL, *b=NULL, *gen=NULL,
+               *order=NULL, *cofactor=NULL;
+       const unsigned char *seed;
+       size_t  seed_len=0;
+       
+       static const char *gen_compressed = "Generator (compressed):";
+       static const char *gen_uncompressed = "Generator (uncompressed):";
+       static const char *gen_hybrid = "Generator (hybrid):";
  
-       /* TODO: fields other than prime fields */
-       
-       if (!x || !x->group)
-               {
-               reason = ECDSA_R_MISSING_PARAMETERS;
-               goto err;
-               }
-       if ((tmp_1 = BN_new()) == NULL || (tmp_2 = BN_new()) == NULL ||
-               (tmp_3 = BN_new()) == NULL || (ctx = BN_CTX_new()) == NULL ||
-               (tmp_6 = BN_new()) == NULL || (tmp_7 = BN_new()) == NULL)
+       if (!x)
                {
-               reason = ERR_R_MALLOC_FAILURE;
+               reason = ERR_R_PASSED_NULL_PARAMETER;
                goto err;
                }
-       if (!EC_GROUP_get_curve_GFp(x->group, tmp_1, tmp_2, tmp_3, ctx))
+
+       if (EC_GROUP_get_asn1_flag(x))
                {
-               reason = ERR_R_EC_LIB;
-               goto err;
+               /* the curve parameter are given by an asn1 OID */
+               int nid;
+
+               if (!BIO_indent(bp, off, 128))
+                       goto err;
+
+               nid = EC_GROUP_get_nid(x);
+               if (nid == 0)
+                       goto err;
+
+               if (BIO_printf(bp, "ASN1 OID: %s", OBJ_nid2sn(nid)) <= 0)
+                       goto err;
+               if (BIO_printf(bp, "\n") <= 0)
+                       goto err;
                }
-       if ((point = EC_GROUP_get0_generator(x->group)) == NULL)
+       else
                {
-               reason = ERR_R_EC_LIB;
-               goto err;
+               /* explicit parameters */
+               int is_char_two = 0;
+               point_conversion_form_t form;
+               int tmp_nid = EC_METHOD_get_field_type(EC_GROUP_method_of(x));
+
+               if (tmp_nid == NID_X9_62_characteristic_two_field)
+                       is_char_two = 1;
+
+               if ((p = BN_new()) == NULL || (a = BN_new()) == NULL ||
+                       (b = BN_new()) == NULL || (order = BN_new()) == NULL ||
+                       (cofactor = BN_new()) == NULL)
+                       {
+                       reason = ERR_R_MALLOC_FAILURE;
+                       goto err;
+                       }
+
+               if (is_char_two)
+                       {
+                       if (!EC_GROUP_get_curve_GF2m(x, p, a, b, ctx))
+                               {
+                               reason = ERR_R_EC_LIB;
+                               goto err;
+                               }
+                       }
+               else /* prime field */
+                       {
+                       if (!EC_GROUP_get_curve_GFp(x, p, a, b, ctx))
+                               {
+                               reason = ERR_R_EC_LIB;
+                               goto err;
+                               }
+                       }
+
+               if ((point = EC_GROUP_get0_generator(x)) == NULL)
+                       {
+                       reason = ERR_R_EC_LIB;
+                       goto err;
+                       }
+               if (!EC_GROUP_get_order(x, order, NULL) || 
+                       !EC_GROUP_get_cofactor(x, cofactor, NULL))
+                       {
+                       reason = ERR_R_EC_LIB;
+                       goto err;
+                       }
+               
+               form = EC_GROUP_get_point_conversion_form(x);
+
+               if ((gen = EC_POINT_point2bn(x, point, 
+                               form, NULL, ctx)) == NULL)
+                       {
+                       reason = ERR_R_EC_LIB;
+                       goto err;
+                       }
+
+               buf_len = (size_t)BN_num_bytes(p);
+               if (buf_len < (i = (size_t)BN_num_bytes(a)))
+                       buf_len = i;
+               if (buf_len < (i = (size_t)BN_num_bytes(b)))
+                       buf_len = i;
+               if (buf_len < (i = (size_t)BN_num_bytes(gen)))
+                       buf_len = i;
+               if (buf_len < (i = (size_t)BN_num_bytes(order)))
+                       buf_len = i;
+               if (buf_len < (i = (size_t)BN_num_bytes(cofactor))) 
+                       buf_len = i;
+
+               if ((seed = EC_GROUP_get0_seed(x)) != NULL)
+                       seed_len = EC_GROUP_get_seed_len(x);
+
+               buf_len += 10;
+               if ((buffer = OPENSSL_malloc(buf_len)) == NULL)
+                       {
+                       reason = ERR_R_MALLOC_FAILURE;
+                       goto err;
+                       }
+
+               if (!BIO_indent(bp, off, 128))
+                       goto err;
+
+               /* print the 'short name' of the field type */
+               if (BIO_printf(bp, "Field Type: %s\n", OBJ_nid2sn(tmp_nid))
+                       <= 0)
+                       goto err;  
+
+               if (is_char_two)
+                       {
+                       /* print the 'short name' of the base type OID */
+                       int basis_type = EC_GROUP_get_basis_type(x);
+                       if (basis_type == 0)
+                               goto err;
+
+                       if (!BIO_indent(bp, off, 128))
+                               goto err;
+
+                       if (BIO_printf(bp, "Basis Type: %s\n", 
+                               OBJ_nid2sn(basis_type)) <= 0)
+                               goto err;
+
+                       /* print the polynomial */
+                       if ((p != NULL) && !print(bp, "Polynomial:", p, buffer,
+                               off))
+                               goto err;
+                       }
+               else
+                       {
+                       if ((p != NULL) && !print(bp, "Prime:", p, buffer,off))
+                               goto err;
+                       }
+               if ((a != NULL) && !print(bp, "A:   ", a, buffer, off)) 
+                       goto err;
+               if ((b != NULL) && !print(bp, "B:   ", b, buffer, off))
+                       goto err;
+               if (form == POINT_CONVERSION_COMPRESSED)
+                       {
+                       if ((gen != NULL) && !print(bp, gen_compressed, gen,
+                               buffer, off))
+                               goto err;
+                       }
+               else if (form == POINT_CONVERSION_UNCOMPRESSED)
+                       {
+                       if ((gen != NULL) && !print(bp, gen_uncompressed, gen,
+                               buffer, off))
+                               goto err;
+                       }
+               else /* form == POINT_CONVERSION_HYBRID */
+                       {
+                       if ((gen != NULL) && !print(bp, gen_hybrid, gen,
+                               buffer, off))
+                               goto err;
+                       }
+               if ((order != NULL) && !print(bp, "Order: ", order, 
+                       buffer, off)) goto err;
+               if ((cofactor != NULL) && !print(bp, "Cofactor: ", cofactor, 
+                       buffer, off)) goto err;
+               if (seed && !print_bin(bp, "Seed:", seed, seed_len, off))
+                       goto err;
                }
-       if (!EC_GROUP_get_order(x->group, tmp_6, NULL) || 
-            !EC_GROUP_get_cofactor(x->group, tmp_7, NULL))
+       ret=1;
+err:
+       if (!ret)
+               ECerr(EC_F_ECPKPARAMETERS_PRINT, reason);
+       if (p) 
+               BN_free(p);
+       if (a) 
+               BN_free(a);
+       if (b)
+               BN_free(b);
+       if (gen)
+               BN_free(gen);
+       if (order)
+               BN_free(order);
+       if (cofactor)
+               BN_free(cofactor);
+       if (ctx)
+               BN_CTX_free(ctx);
+       if (buffer != NULL) 
+               OPENSSL_free(buffer);
+       return(ret);    
+       }
+
+int EC_KEY_print(BIO *bp, const EC_KEY *x, int off)
+       {
+       unsigned char *buffer=NULL;
+       size_t  buf_len=0, i;
+       int     ret=0, reason=ERR_R_BIO_LIB;
+       BIGNUM  *pub_key=NULL, *order=NULL;
+       BN_CTX  *ctx=NULL;
+       if (!x || !x->group)
                {
-               reason = ERR_R_EC_LIB;
+               reason = ERR_R_PASSED_NULL_PARAMETER;
                goto err;
                }
-       if ((tmp_4 = EC_POINT_point2bn(x->group, point, 
-               ECDSA_get_conversion_form(x), tmp_4, ctx)) == NULL)
+
+       if ((pub_key = EC_POINT_point2bn(x->group, x->pub_key,
+               x->conv_form, NULL, ctx)) == NULL)
                {
                reason = ERR_R_EC_LIB;
                goto err;
                }
-       if ((tmp_5 = EC_POINT_point2bn(x->group, x->pub_key,
-               ECDSA_get_conversion_form(x), tmp_5, ctx)) == NULL)
+
+       buf_len = (size_t)BN_num_bytes(pub_key);
+       if (x->priv_key)
                {
-               reason = ERR_R_EC_LIB;
-               goto err;
+               if ((i = (size_t)BN_num_bytes(x->priv_key)) > buf_len)
+                       buf_len = i;
                }
 
-       buf_len = BN_num_bytes(tmp_1);
-       if (buf_len < (i = BN_num_bytes(tmp_2))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_3))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_4))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_5))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_6))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_7))) buf_len = i;
        buf_len += 10;
        if ((buffer = OPENSSL_malloc(buf_len)) == NULL)
                {
                reason = ERR_R_MALLOC_FAILURE;
                goto err;
                }
-       if (off)
-               {
-               if (off > 128) off=128;
-               memset(str,' ',off);
-               }
+
        if (x->priv_key != NULL)
                {
-               if (off && (BIO_write(bp, str, off) <= 0)) goto err;
-               if (BIO_printf(bp, "Private-Key: (%d bit)\n", BN_num_bits(tmp_1)) <= 0) goto err;
+               if (!BIO_indent(bp, off, 128))
+                       goto err;
+               if ((order = BN_new()) == NULL)
+                       goto err;
+               if (!EC_GROUP_get_order(x->group, order, NULL))
+                       goto err;
+               if (BIO_printf(bp, "Private-Key: (%d bit)\n", 
+                       BN_num_bits(order)) <= 0) goto err;
                }
   
-       if ((x->priv_key != NULL) && !print(bp, "priv:", x->priv_key, buffer, off)) goto err;
-       if ((tmp_5 != NULL) && !print(bp, "pub: ", tmp_5, buffer, off)) goto err;
-       if ((tmp_1 != NULL) && !print(bp, "P:   ", tmp_1, buffer, off)) goto err;
-       if ((tmp_2 != NULL) && !print(bp, "A:   ", tmp_2, buffer, off)) goto err;
-       if ((tmp_3 != NULL) && !print(bp, "B:   ", tmp_3, buffer, off)) goto err;
-       if ((tmp_4 != NULL) && !print(bp, "Gen: ", tmp_4, buffer, off)) goto err;
-       if ((tmp_6 != NULL) && !print(bp, "Order: ", tmp_6, buffer, off)) goto err;
-       if ((tmp_7 != NULL) && !print(bp, "Cofactor: ", tmp_7, buffer, off)) goto err;
+       if ((x->priv_key != NULL) && !print(bp, "priv:", x->priv_key, 
+               buffer, off))
+               goto err;
+       if ((pub_key != NULL) && !print(bp, "pub: ", pub_key,
+               buffer, off))
+               goto err;
+       if (!ECPKParameters_print(bp, x->group, off))
+               goto err;
        ret=1;
 err:
        if (!ret)
-               ECDSAerr(ECDSA_F_ECDSA_PRINT, reason);
-       if (tmp_1) BN_free(tmp_1);
-       if (tmp_2) BN_free(tmp_2);
-       if (tmp_3) BN_free(tmp_3);
-       if (tmp_4) BN_free(tmp_4);
-       if (tmp_5) BN_free(tmp_5);
-       if (tmp_6) BN_free(tmp_6);
-       if (tmp_7) BN_free(tmp_7);
-       if (ctx)   BN_CTX_free(ctx);
-       if (buffer != NULL) OPENSSL_free(buffer);
+               ECerr(EC_F_EC_KEY_PRINT, reason);
+       if (pub_key) 
+               BN_free(pub_key);
+       if (order)
+               BN_free(order);
+       if (ctx)
+               BN_CTX_free(ctx);
+       if (buffer != NULL)
+               OPENSSL_free(buffer);
        return(ret);
        }
-#endif
+#endif /* OPENSSL_NO_EC */
 
 static int print(BIO *bp, const char *number, BIGNUM *num, unsigned char *buf,
             int off)
        {
        int n,i;
-       char str[128];
        const char *neg;
 
        if (num == NULL) return(1);
-       neg=(num->neg)?"-":"";
-       if (off)
+       neg = (BN_get_sign(num))?"-":"";
+       if(!BIO_indent(bp,off,128))
+               return 0;
+       if (BN_is_zero(num))
                {
-               if (off > 128) off=128;
-               memset(str,' ',off);
-               if (BIO_write(bp,str,off) <= 0) return(0);
+               if (BIO_printf(bp, "%s 0\n", number) <= 0)
+                       return 0;
+               return 1;
                }
 
        if (BN_num_bytes(num) <= BN_BYTES)
@@ -372,9 +584,9 @@ static int print(BIO *bp, const char *number, BIGNUM *num, unsigned char *buf,
                        {
                        if ((i%15) == 0)
                                {
-                               str[0]='\n';
-                               memset(&(str[1]),' ',off+4);
-                               if (BIO_write(bp,str,off+1+4) <= 0) return(0);
+                               if(BIO_puts(bp,"\n") <= 0
+                                  || !BIO_indent(bp,off+4,128))
+                                   return 0;
                                }
                        if (BIO_printf(bp,"%02x%s",buf[i],((i+1) == n)?"":":")
                                <= 0) return(0);
@@ -384,6 +596,44 @@ static int print(BIO *bp, const char *number, BIGNUM *num, unsigned char *buf,
        return(1);
        }
 
+static int print_bin(BIO *fp, const char *name, const unsigned char *buf,
+               size_t len, int off)
+       {
+       size_t i;
+       char str[128];
+
+       if (buf == NULL)
+               return 1;
+       if (off)
+               {
+               if (off > 128)
+                       off=128;
+               memset(str,' ',off);
+               if (BIO_write(fp, str, off) <= 0)
+                       return 0;
+               }
+
+       if (BIO_printf(fp,"%s", name) <= 0)
+               return 0;
+
+       for (i=0; i<len; i++)
+               {
+               if ((i%15) == 0)
+                       {
+                       str[0]='\n';
+                       memset(&(str[1]),' ',off+4);
+                       if (BIO_write(fp, str, off+1+4) <= 0)
+                               return 0;
+                       }
+               if (BIO_printf(fp,"%02x%s",buf[i],((i+1) == len)?"":":") <= 0)
+                       return 0;
+               }
+       if (BIO_write(fp,"\n",1) <= 0)
+               return 0;
+
+       return 1;
+       }
+
 #ifndef OPENSSL_NO_DH
 #ifndef OPENSSL_NO_FP_API
 int DHparams_print_fp(FILE *fp, const DH *x)
@@ -406,10 +656,15 @@ int DHparams_print_fp(FILE *fp, const DH *x)
 int DHparams_print(BIO *bp, const DH *x)
        {
        unsigned char *m=NULL;
-       int reason=ERR_R_BUF_LIB,i,ret=0;
-
-       i=BN_num_bytes(x->p);
-       m=(unsigned char *)OPENSSL_malloc((unsigned int)i+10);
+       int reason=ERR_R_BUF_LIB,ret=0;
+       size_t buf_len=0, i;
+
+       if (x->p)
+               buf_len = (size_t)BN_num_bytes(x->p);
+       if (x->g)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->g)))
+                       buf_len = i;
+       m=(unsigned char *)OPENSSL_malloc(buf_len+10);
        if (m == NULL)
                {
                reason=ERR_R_MALLOC_FAILURE;
@@ -459,10 +714,18 @@ int DSAparams_print_fp(FILE *fp, const DSA *x)
 int DSAparams_print(BIO *bp, const DSA *x)
        {
        unsigned char *m=NULL;
-       int reason=ERR_R_BUF_LIB,i,ret=0;
-
-       i=BN_num_bytes(x->p);
-       m=(unsigned char *)OPENSSL_malloc((unsigned int)i+10);
+       int reason=ERR_R_BUF_LIB,ret=0;
+       size_t buf_len=0,i;
+
+       if (x->p)
+               buf_len = (size_t)BN_num_bytes(x->p);
+       if (x->q)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->q)))
+                       buf_len = i;
+       if (x->g)
+               if (buf_len < (i = (size_t)BN_num_bytes(x->g)))
+                       buf_len = i;
+       m=(unsigned char *)OPENSSL_malloc(buf_len+10);
        if (m == NULL)
                {
                reason=ERR_R_MALLOC_FAILURE;
@@ -484,91 +747,58 @@ err:
 
 #endif /* !OPENSSL_NO_DSA */
 
-#ifndef OPENSSL_NO_ECDSA
+#ifndef OPENSSL_NO_EC
 #ifndef OPENSSL_NO_FP_API
-int ECDSAParameters_print_fp(FILE *fp, const ECDSA *x)
+int ECParameters_print_fp(FILE *fp, const EC_KEY *x)
        {
        BIO *b;
        int ret;
  
        if ((b=BIO_new(BIO_s_file())) == NULL)
-       {
-               ECDSAerr(ECDSA_F_ECDSAPARAMETERS_PRINT_FP, ERR_R_BIO_LIB);
+               {
+               ECerr(EC_F_ECPARAMETERS_PRINT_FP, ERR_R_BIO_LIB);
                return(0);
-       }
+               }
        BIO_set_fp(b, fp, BIO_NOCLOSE);
-       ret = ECDSAParameters_print(b, x);
+       ret = ECParameters_print(b, x);
        BIO_free(b);
        return(ret);
        }
 #endif
 
-int ECDSAParameters_print(BIO *bp, const ECDSA *x)
-       {
-       unsigned char *buffer=NULL;
-       int     buf_len;
-       int     reason=ERR_R_EC_LIB, i, ret=0;
-       BIGNUM  *tmp_1=NULL, *tmp_2=NULL, *tmp_3=NULL, *tmp_4=NULL,
-               *tmp_5=NULL, *tmp_6=NULL;
-       BN_CTX  *ctx=NULL;
-       EC_POINT *point=NULL;
+int ECParameters_print(BIO *bp, const EC_KEY *x)
+       {
+       int     reason=ERR_R_EC_LIB, ret=0;
+       BIGNUM  *order=NULL;
  
-       /* TODO: fields other than prime fields */
-       if (!x || !x->group)
-       {
-               reason = ECDSA_R_MISSING_PARAMETERS;
+       if (!x || !x->group)
+               {
+               reason = ERR_R_PASSED_NULL_PARAMETER;;
                goto err;
-       }
-       if ((tmp_1 = BN_new()) == NULL || (tmp_2 = BN_new()) == NULL ||
-          (tmp_3 = BN_new()) == NULL || (tmp_5 = BN_new()) == NULL ||
-           (tmp_6 = BN_new()) == NULL || (ctx = BN_CTX_new()) == NULL)
-       {
+               }
+
+       if ((order = BN_new()) == NULL)
+               {
                reason = ERR_R_MALLOC_FAILURE;
                goto err;
-       }
-       if (!EC_GROUP_get_curve_GFp(x->group, tmp_1, tmp_2, tmp_3, ctx)) goto err;
-       if ((point = EC_GROUP_get0_generator(x->group)) == NULL) goto err;
-       if (!EC_GROUP_get_order(x->group, tmp_5, ctx)) goto err;
-       if (!EC_GROUP_get_cofactor(x->group, tmp_6, ctx)) goto err;     
+               }
 
-       if ((tmp_4 = EC_POINT_point2bn(x->group, point, 
-               ECDSA_get_conversion_form(x), NULL, ctx)) == NULL)
+       if (!EC_GROUP_get_order(x->group, order, NULL))
                {
                reason = ERR_R_EC_LIB;
                goto err;
                }
-
-       buf_len = BN_num_bytes(tmp_1);
-       if (buf_len < (i = BN_num_bytes(tmp_2))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_3))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_4))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_5))) buf_len = i;
-       if (buf_len < (i = BN_num_bytes(tmp_6))) buf_len = i;
-       buf_len += 10;
-       if ((buffer = OPENSSL_malloc(buf_len)) == NULL)
-       {
-               reason=ERR_R_MALLOC_FAILURE;
-               goto err;
-       }
  
-       if (BIO_printf(bp, "ECDSA-Parameters: (%d bit)\n", BN_num_bits(tmp_1)) <= 0) goto err;
-       if (!print(bp, "Prime p:", tmp_1, buffer, 4)) goto err;
-       if (!print(bp, "Curve a:", tmp_2, buffer, 4)) goto err;
-       if (!print(bp, "Curve b:", tmp_3, buffer, 4)) goto err;
-       if (!print(bp, "Generator (compressed):", tmp_4, buffer, 4)) goto err; 
-       if (!print(bp, "Order:", tmp_5, buffer, 4)) goto err;
-       if (!print(bp, "Cofactor:", tmp_6, buffer, 4)) goto err;
+       if (BIO_printf(bp, "ECDSA-Parameters: (%d bit)\n", 
+               BN_num_bits(order)) <= 0)
+               goto err;
+       if (!ECPKParameters_print(bp, x->group, 4))
+               goto err;
        ret=1;
 err:
-       if (tmp_1)  BN_free(tmp_1);
-       if (tmp_2)  BN_free(tmp_2);
-       if (tmp_3)  BN_free(tmp_3);
-       if (tmp_4)  BN_free(tmp_4);
-       if (tmp_5)  BN_free(tmp_5);
-       if (tmp_6)  BN_free(tmp_6);
-       if (ctx)    BN_CTX_free(ctx);
-       if (buffer) OPENSSL_free(buffer);
-       ECDSAerr(ECDSA_F_ECDSAPARAMETERS_PRINT, reason);
+       if (order)
+               BN_free(order);
+       ECerr(EC_F_ECPARAMETERS_PRINT, reason);
        return(ret);
        }