- fix coverity issues 966593-966596

[openssl.git] / crypto / LPdir_win.c

diff --git a/crypto/LPdir_win.c b/crypto/LPdir_win.c
index 06948f7adc1833763fb724617a7061ad5b4c9bc8..702dbc730f62ffcdcaf85c02c6e7b235b3913f69 100644 (file)
--- a/crypto/LPdir_win.c
+++ b/crypto/LPdir_win.c
@@ -1,4 +1,4 @@
-/* $LP: LPlib/source/LPdir_win.c,v 1.5 2004/07/20 22:39:13 _cvs_levitte Exp $ */
+/* $LP: LPlib/source/LPdir_win.c,v 1.10 2004/08/26 13:36:05 _cvs_levitte Exp $ */
 /*
  * Copyright (c) 2004, Richard Levitte <richard@levitte.org>
  * All rights reserved.
@@ -11,18 +11,18 @@
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
+ * 
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include <windows.h>
 #include <tchar.h>
@@ -30,11 +30,20 @@
 #include "LPdir.h"
 #endif
 
-/* It seems like WinCE doesn't always have the "normal" mapping
-   macros.  We're opting for the UNICODE ones. */
+/* We're most likely overcautious here, but let's reserve for
+    broken WinCE headers and explicitly opt for UNICODE call.
+    Keep in mind that our WinCE builds are compiled with -DUNICODE
+    [as well as -D_UNICODE]. */
 #if defined(LP_SYS_WINCE) && !defined(FindFirstFile)
 # define FindFirstFile FindFirstFileW
 #endif
+#if defined(LP_SYS_WINCE) && !defined(FindFirstFile)
+# define FindNextFile FindNextFileW
+#endif
+
+#ifndef NAME_MAX
+#define NAME_MAX 255
+#endif
 
 struct LP_dir_context_st
 {
@@ -45,8 +54,6 @@ struct LP_dir_context_st
 
 const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
 {
-  struct dirent *direntry = NULL;
-
   if (ctx == NULL || directory == NULL)
     {
       errno = EINVAL;
@@ -67,9 +74,10 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
       if (sizeof(TCHAR) != sizeof(char))
        {
          TCHAR *wdir = NULL;
-         size_t index = 0,len = strlen(direcory);
+         /* len_0 denotes string length *with* trailing 0 */ 
+         size_t index = 0,len_0 = strlen(directory) + 1;
 
-         wdir = (TCHAR *)malloc((len + 1) * sizeof(TCHAR));
+         wdir = (TCHAR *)malloc(len_0 * sizeof(TCHAR));
          if (wdir == NULL)
            {
              free(*ctx);
@@ -79,9 +87,9 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
            }
 
 #ifdef LP_MULTIBYTE_AVAILABLE
-         if (!MultiByteToWideChar(CP_ACP, 0, directory, len, wdir, len + 1))
+         if (!MultiByteToWideChar(CP_ACP, 0, directory, len_0, (WCHAR *)wdir, len_0))
 #endif
-           for (index = 0; index < strlen(directory) + 1; index++)
+           for (index = 0; index < len_0; index++)
              wdir[index] = (TCHAR)directory[index];
 
          (*ctx)->handle = FindFirstFile(wdir, &(*ctx)->ctx);
@@ -89,7 +97,7 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
          free(wdir);
        }
       else
-       (*ctx)->handle = FindFirstFile(directory, &(*ctx)->ctx);
+       (*ctx)->handle = FindFirstFile((TCHAR *)directory, &(*ctx)->ctx);
 
       if ((*ctx)->handle == INVALID_HANDLE_VALUE)
        {
@@ -101,7 +109,7 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
     }
   else
     {
-      if (FindNextFile((*ctx)->handle, (*ctx)->ctx) == FALSE)
+      if (FindNextFile((*ctx)->handle, &(*ctx)->ctx) == FALSE)
        {
          return 0;
        }
@@ -110,20 +118,20 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
   if (sizeof(TCHAR) != sizeof(char))
     {
       TCHAR *wdir = (*ctx)->ctx.cFileName;
-      size_t index, len;
+      size_t index, len_0 = 0;
 
-      for (len = 0; wdir[len] && len < (sizeof((*ctx)->entry_name) - 1);)
-       len++;
+      while (wdir[len_0] && len_0 < (sizeof((*ctx)->entry_name) - 1)) len_0++;
+      len_0++;
 
 #ifdef LP_MULTIBYTE_AVAILABLE
-      if (!WideCharToMultiByte(CP_ACP, 0, wdir, len, (*ctx)->entry_name,
-                              sizeof((*ctx)->entry_name) - 1, NULL, 0))
+      if (!WideCharToMultiByte(CP_ACP, 0, (WCHAR *)wdir, len_0, (*ctx)->entry_name,
+                              sizeof((*ctx)->entry_name), NULL, 0))
 #endif
-       for (index = 0; index < len; index++)
+       for (index = 0; index < len_0; index++)
          (*ctx)->entry_name[index] = (char)wdir[index];
     }
   else
-    strncpy((*ctx)->entry_name, (*ctx)->ctx.cFileName,
+    strncpy((*ctx)->entry_name, (const char *)(*ctx)->ctx.cFileName,
            sizeof((*ctx)->entry_name)-1);
 
   (*ctx)->entry_name[sizeof((*ctx)->entry_name)-1] = '\0';