Typo.
[openssl.git] / apps / req.c
index 429eb9d4a0e781768bb91579d73ca2d7a3ba7bd3..e69d451f2f015cb8ad710526cdf3612e57e49635 100644 (file)
  * [including the GNU Public Licence.]
  */
 
+/* Until the key-gen callbacks are modified to use newer prototypes, we allow
+ * deprecated functions for openssl-internal code */
+#ifdef OPENSSL_NO_DEPRECATED
+#undef OPENSSL_NO_DEPRECATED
+#endif
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <time.h>
 #include <openssl/x509v3.h>
 #include <openssl/objects.h>
 #include <openssl/pem.h>
-#include <openssl/engine.h>
+#include <openssl/bn.h>
+#ifndef OPENSSL_NO_RSA
+#include <openssl/rsa.h>
+#endif
+#ifndef OPENSSL_NO_DSA
+#include <openssl/dsa.h>
+#endif
 
 #define SECTION                "req"
 
@@ -85,6 +97,7 @@
 #define V3_EXTENSIONS  "x509_extensions"
 #define REQ_EXTENSIONS "req_extensions"
 #define STRING_MASK    "string_mask"
+#define UTF8_IN                "utf8"
 
 #define DEFAULT_KEY_LENGTH     512
 #define MIN_KEY_LENGTH         384
  * -rand file(s) - load the file(s) into the PRNG.
  * -newkey     - make a key and a request.
  * -modulus    - print RSA modulus.
+ * -pubkey     - output Public Key.
  * -x509       - output a self signed X509 structure instead.
  * -asn1-kludge        - output new certificate request in a format that some CA's
  *               require.  This format is wrong
  */
 
-static int make_REQ(X509_REQ *req,EVP_PKEY *pkey,char *dn,int attribs);
-static int build_subject(X509_REQ *req, char *subj);
+static int make_REQ(X509_REQ *req,EVP_PKEY *pkey,char *dn,int mutlirdn,
+               int attribs,unsigned long chtype);
+static int build_subject(X509_REQ *req, char *subj, unsigned long chtype,
+               int multirdn);
 static int prompt_info(X509_REQ *req,
                STACK_OF(CONF_VALUE) *dn_sk, char *dn_sect,
-               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs);
+               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs,
+               unsigned long chtype);
 static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *sk,
-                               STACK_OF(CONF_VALUE) *attr, int attribs);
-static int add_attribute_object(X509_REQ *req, char *text,
-                               char *def, char *value, int nid, int min,
-                               int max);
-static int add_DN_object(X509_NAME *n, char *text, char *def, char *value,
-       int nid,int min,int max);
-#ifndef OPENSSL_NO_RSA
-static void MS_CALLBACK req_cb(int p,int n,void *arg);
-#endif
-static int req_check_len(int len,int min,int max);
-static int check_end(char *str, char *end);
+                               STACK_OF(CONF_VALUE) *attr, int attribs,
+                               unsigned long chtype);
+static int add_attribute_object(X509_REQ *req, char *text, const char *def,
+                               char *value, int nid, int n_min,
+                               int n_max, unsigned long chtype);
+static int add_DN_object(X509_NAME *n, char *text, const char *def, char *value,
+       int nid,int n_min,int n_max, unsigned long chtype, int mval);
+static int genpkey_cb(EVP_PKEY_CTX *ctx);
+static int req_check_len(int len,int n_min,int n_max);
+static int check_end(const char *str, const char *end);
+static EVP_PKEY_CTX *set_keygen_ctx(BIO *err, const char *gstr,
+                                       long *pkeylen, const char **palgnam,
+                                       ENGINE *e);
 #ifndef MONOLITH
 static char *default_config_file=NULL;
-static LHASH *config=NULL;
 #endif
-static LHASH *req_conf=NULL;
+static CONF *req_conf=NULL;
 static int batch=0;
 
-#define TYPE_RSA       1
-#define TYPE_DSA       2
-#define TYPE_DH                3
-
 int MAIN(int, char **);
 
 int MAIN(int argc, char **argv)
@@ -147,17 +161,25 @@ int MAIN(int argc, char **argv)
 #ifndef OPENSSL_NO_DSA
        DSA *dsa_params=NULL;
 #endif
-       unsigned long nmflag = 0;
+#ifndef OPENSSL_NO_ECDSA
+       EC_KEY *ec_params = NULL;
+#endif
+       unsigned long nmflag = 0, reqflag = 0;
        int ex=1,x509=0,days=30;
        X509 *x509ss=NULL;
        X509_REQ *req=NULL;
+       EVP_PKEY_CTX *genctx = NULL;
+       const char *keyalgstr;
        EVP_PKEY *pkey=NULL;
-       int i,badops=0,newreq=0,newkey= -1,verbose=0,pkey_type=TYPE_RSA;
+       int i=0,badops=0,newreq=0,verbose=0,pkey_type=EVP_PKEY_RSA;
+       long newkey = -1;
        BIO *in=NULL,*out=NULL;
        int informat,outformat,verify=0,noout=0,text=0,keyform=FORMAT_PEM;
-       int nodes=0,kludge=0,newhdr=0,subject=0;
+       int nodes=0,kludge=0,newhdr=0,subject=0,pubkey=0;
        char *infile,*outfile,*prog,*keyfile=NULL,*template=NULL,*keyout=NULL;
+#ifndef OPENSSL_NO_ENGINE
        char *engine=NULL;
+#endif
        char *extensions = NULL;
        char *req_exts = NULL;
        const EVP_CIPHER *cipher=NULL;
@@ -168,9 +190,12 @@ int MAIN(int argc, char **argv)
        char *passin = NULL, *passout = NULL;
        char *p;
        char *subj = NULL;
-       const EVP_MD *md_alg=NULL,*digest=EVP_md5();
+       int multirdn = 0;
+       const EVP_MD *md_alg=NULL,*digest=NULL;
+       unsigned long chtype = MBSTRING_ASC;
 #ifndef MONOLITH
-       MS_STATIC char config_name[256];
+       char *to_free;
+       long errline;
 #endif
 
        req_conf = NULL;
@@ -203,16 +228,22 @@ int MAIN(int argc, char **argv)
                        if (--argc < 1) goto bad;
                        outformat=str2fmt(*(++argv));
                        }
+#ifndef OPENSSL_NO_ENGINE
                else if (strcmp(*argv,"-engine") == 0)
                        {
                        if (--argc < 1) goto bad;
                        engine= *(++argv);
                        }
+#endif
                else if (strcmp(*argv,"-key") == 0)
                        {
                        if (--argc < 1) goto bad;
                        keyfile= *(++argv);
                        }
+               else if (strcmp(*argv,"-pubkey") == 0)
+                       {
+                       pubkey=1;
+                       }
                else if (strcmp(*argv,"-new") == 0)
                        {
                        newreq=1;
@@ -259,70 +290,33 @@ int MAIN(int argc, char **argv)
                        }
                else if (strcmp(*argv,"-newkey") == 0)
                        {
-                       int is_numeric;
 
-                       if (--argc < 1) goto bad;
-                       p= *(++argv);
-                       is_numeric = p[0] >= '0' && p[0] <= '9';
-                       if (strncmp("rsa:",p,4) == 0 || is_numeric)
-                               {
-                               pkey_type=TYPE_RSA;
-                               if(!is_numeric)
-                                   p+=4;
-                               newkey= atoi(p);
-                               }
-                       else
-#ifndef OPENSSL_NO_DSA
-                               if (strncmp("dsa:",p,4) == 0)
-                               {
-                               X509 *xtmp=NULL;
-                               EVP_PKEY *dtmp;
+                       if (--argc < 1)
+                               goto bad;
 
-                               pkey_type=TYPE_DSA;
-                               p+=4;
-                               if ((in=BIO_new_file(p,"r")) == NULL)
-                                       {
-                                       perror(p);
-                                       goto end;
-                                       }
-                               if ((dsa_params=PEM_read_bio_DSAparams(in,NULL,NULL,NULL)) == NULL)
-                                       {
-                                       ERR_clear_error();
-                                       (void)BIO_reset(in);
-                                       if ((xtmp=PEM_read_bio_X509(in,NULL,NULL,NULL)) == NULL)
-                                               {
-                                               BIO_printf(bio_err,"unable to load DSA parameters from file\n");
-                                               goto end;
-                                               }
-
-                                       dtmp=X509_get_pubkey(xtmp);
-                                       if (dtmp->type == EVP_PKEY_DSA)
-                                               dsa_params=DSAparams_dup(dtmp->pkey.dsa);
-                                       EVP_PKEY_free(dtmp);
-                                       X509_free(xtmp);
-                                       if (dsa_params == NULL)
-                                               {
-                                               BIO_printf(bio_err,"Certificate does not contain DSA parameters\n");
-                                               goto end;
-                                               }
-                                       }
-                               BIO_free(in);
-                               newkey=BN_num_bits(dsa_params->p);
-                               in=NULL;
+                       genctx = set_keygen_ctx(bio_err, *(++argv), &newkey,
+                                                       &keyalgstr, e);
+
+                       if (!genctx)
+                               goto bad;
+
+                       newreq=1;
+                       }
+               else if (strcmp(*argv,"-pkeyopt") == 0)
+                       {
+                       if (--argc < 1)
+                               goto bad;
+                       if (!genctx)
+                               {
+                               BIO_puts(bio_err, "No keytype specified\n");
+                               goto bad;
                                }
-                       else 
-#endif
-#ifndef OPENSSL_NO_DH
-                               if (strncmp("dh:",p,4) == 0)
+                       else if (pkey_ctrl_string(genctx, *(++argv)) <= 0)
                                {
-                               pkey_type=TYPE_DH;
-                               p+=3;
+                               BIO_puts(bio_err, "parameter setting error\n");
+                               ERR_print_errors(bio_err);
+                               goto end;
                                }
-                       else
-#endif
-                               pkey_type=TYPE_RSA;
-
-                       newreq=1;
                        }
                else if (strcmp(*argv,"-batch") == 0)
                        batch=1;
@@ -338,11 +332,18 @@ int MAIN(int argc, char **argv)
                        noout=1;
                else if (strcmp(*argv,"-verbose") == 0)
                        verbose=1;
+               else if (strcmp(*argv,"-utf8") == 0)
+                       chtype = MBSTRING_UTF8;
                else if (strcmp(*argv,"-nameopt") == 0)
                        {
                        if (--argc < 1) goto bad;
                        if (!set_name_ex(&nmflag, *(++argv))) goto bad;
                        }
+               else if (strcmp(*argv,"-reqopt") == 0)
+                       {
+                       if (--argc < 1) goto bad;
+                       if (!set_cert_ex(&reqflag, *(++argv))) goto bad;
+                       }
                else if (strcmp(*argv,"-subject") == 0)
                        subject=1;
                else if (strcmp(*argv,"-text") == 0)
@@ -358,6 +359,8 @@ int MAIN(int argc, char **argv)
                        if (--argc < 1) goto bad;
                        subj= *(++argv);
                        }
+               else if (strcmp(*argv,"-multivalue-rdn") == 0)
+                       multirdn=1;
                else if (strcmp(*argv,"-days") == 0)
                        {
                        if (--argc < 1) goto bad;
@@ -405,11 +408,14 @@ bad:
                BIO_printf(bio_err," -in arg        input file\n");
                BIO_printf(bio_err," -out arg       output file\n");
                BIO_printf(bio_err," -text          text form of request\n");
+               BIO_printf(bio_err," -pubkey        output public key\n");
                BIO_printf(bio_err," -noout         do not output REQ\n");
                BIO_printf(bio_err," -verify        verify signature on REQ\n");
                BIO_printf(bio_err," -modulus       RSA modulus\n");
                BIO_printf(bio_err," -nodes         don't encrypt the output key\n");
+#ifndef OPENSSL_NO_ENGINE
                BIO_printf(bio_err," -engine e      use engine e, possibly a hardware device\n");
+#endif
                BIO_printf(bio_err," -subject       output the request's subject\n");
                BIO_printf(bio_err," -passin        private key password source\n");
                BIO_printf(bio_err," -key file      use the private key contained in file\n");
@@ -420,9 +426,13 @@ bad:
                BIO_printf(bio_err,"                the random number generator\n");
                BIO_printf(bio_err," -newkey rsa:bits generate a new RSA key of 'bits' in size\n");
                BIO_printf(bio_err," -newkey dsa:file generate a new DSA key, parameters taken from CA in 'file'\n");
-               BIO_printf(bio_err," -[digest]      Digest to sign with (md5, sha1, md2, mdc2)\n");
+#ifndef OPENSSL_NO_ECDSA
+               BIO_printf(bio_err," -newkey ec:file generate a new EC key, parameters taken from CA in 'file'\n");
+#endif
+               BIO_printf(bio_err," -[digest]      Digest to sign with (md5, sha1, md2, mdc2, md4)\n");
                BIO_printf(bio_err," -config file   request template file.\n");
                BIO_printf(bio_err," -subj arg      set or modify request subject\n");
+               BIO_printf(bio_err," -multivalue-rdn enable support for multivalued RDNs\n");
                BIO_printf(bio_err," -new           new request.\n");
                BIO_printf(bio_err," -batch         do not ask anything during request generation\n");
                BIO_printf(bio_err," -x509          output a x509 structure instead of a cert. req.\n");
@@ -433,6 +443,9 @@ bad:
                BIO_printf(bio_err,"                have been reported as requiring\n");
                BIO_printf(bio_err," -extensions .. specify certificate extension section (override value in config file)\n");
                BIO_printf(bio_err," -reqexts ..    specify request extension section (override value in config file)\n");
+               BIO_printf(bio_err," -utf8          input characters are UTF8 (default ASCII)\n");
+               BIO_printf(bio_err," -nameopt arg    - various certificate name options\n");
+               BIO_printf(bio_err," -reqopt arg    - various request text options\n\n");
                goto end;
                }
 
@@ -448,25 +461,21 @@ bad:
        if (p == NULL)
                p=getenv("SSLEAY_CONF");
        if (p == NULL)
-               {
-               strcpy(config_name,X509_get_default_cert_area());
-#ifndef OPENSSL_SYS_VMS
-               strcat(config_name,"/");
-#endif
-               strcat(config_name,OPENSSL_CONF);
-               p=config_name;
-               }
+               p=to_free=make_config_name();
        default_config_file=p;
-       config=CONF_load(config,p,NULL);
+       config=NCONF_new(NULL);
+       i=NCONF_load(config, p, &errline);
 #endif
 
        if (template != NULL)
                {
-               long errline;
+               long errline = -1;
 
-               BIO_printf(bio_err,"Using configuration from %s\n",template);
-               req_conf=CONF_load(NULL,template,&errline);
-               if (req_conf == NULL)
+               if( verbose )
+                       BIO_printf(bio_err,"Using configuration from %s\n",template);
+               req_conf=NCONF_new(NULL);
+               i=NCONF_load(req_conf,template,&errline);
+               if (i == 0)
                        {
                        BIO_printf(bio_err,"error on line %ld of %s\n",errline,template);
                        goto end;
@@ -475,17 +484,23 @@ bad:
        else
                {
                req_conf=config;
-               BIO_printf(bio_err,"Using configuration from %s\n",
-                       default_config_file);
+
                if (req_conf == NULL)
                        {
-                       BIO_printf(bio_err,"Unable to load config info\n");
+                       BIO_printf(bio_err,"Unable to load config info from %s\n", default_config_file);
+                       if (newreq)
+                               goto end;
                        }
+               else if( verbose )
+                       BIO_printf(bio_err,"Using configuration from %s\n",
+                       default_config_file);
                }
 
        if (req_conf != NULL)
                {
-               p=CONF_get_string(req_conf,NULL,"oid_file");
+               if (!load_config(bio_err, req_conf))
+                       goto end;
+               p=NCONF_get_string(req_conf,NULL,"oid_file");
                if (p == NULL)
                        ERR_clear_error();
                if (p != NULL)
@@ -511,7 +526,7 @@ bad:
 
        if (md_alg == NULL)
                {
-               p=CONF_get_string(req_conf,SECTION,"default_md");
+               p=NCONF_get_string(req_conf,SECTION,"default_md");
                if (p == NULL)
                        ERR_clear_error();
                if (p != NULL)
@@ -523,7 +538,7 @@ bad:
 
        if (!extensions)
                {
-               extensions = CONF_get_string(req_conf, SECTION, V3_EXTENSIONS);
+               extensions = NCONF_get_string(req_conf, SECTION, V3_EXTENSIONS);
                if (!extensions)
                        ERR_clear_error();
                }
@@ -531,8 +546,8 @@ bad:
                /* Check syntax of file */
                X509V3_CTX ctx;
                X509V3_set_ctx_test(&ctx);
-               X509V3_set_conf_lhash(&ctx, req_conf);
-               if(!X509V3_EXT_add_conf(req_conf, &ctx, extensions, NULL)) {
+               X509V3_set_nconf(&ctx, req_conf);
+               if(!X509V3_EXT_add_nconf(req_conf, &ctx, extensions, NULL)) {
                        BIO_printf(bio_err,
                         "Error Loading extension section %s\n", extensions);
                        goto end;
@@ -541,19 +556,19 @@ bad:
 
        if(!passin)
                {
-               passin = CONF_get_string(req_conf, SECTION, "input_password");
+               passin = NCONF_get_string(req_conf, SECTION, "input_password");
                if (!passin)
                        ERR_clear_error();
                }
        
        if(!passout)
                {
-               passout = CONF_get_string(req_conf, SECTION, "output_password");
+               passout = NCONF_get_string(req_conf, SECTION, "output_password");
                if (!passout)
                        ERR_clear_error();
                }
 
-       p = CONF_get_string(req_conf, SECTION, STRING_MASK);
+       p = NCONF_get_string(req_conf, SECTION, STRING_MASK);
        if (!p)
                ERR_clear_error();
 
@@ -562,9 +577,19 @@ bad:
                goto end;
        }
 
+       if (chtype != MBSTRING_UTF8)
+               {
+               p = NCONF_get_string(req_conf, SECTION, UTF8_IN);
+               if (!p)
+                       ERR_clear_error();
+               else if (!strcmp(p, "yes"))
+                       chtype = MBSTRING_UTF8;
+               }
+
+
        if(!req_exts)
                {
-               req_exts = CONF_get_string(req_conf, SECTION, REQ_EXTENSIONS);
+               req_exts = NCONF_get_string(req_conf, SECTION, REQ_EXTENSIONS);
                if (!req_exts)
                        ERR_clear_error();
                }
@@ -572,8 +597,8 @@ bad:
                /* Check syntax of file */
                X509V3_CTX ctx;
                X509V3_set_ctx_test(&ctx);
-               X509V3_set_conf_lhash(&ctx, req_conf);
-               if(!X509V3_EXT_add_conf(req_conf, &ctx, req_exts, NULL)) {
+               X509V3_set_nconf(&ctx, req_conf);
+               if(!X509V3_EXT_add_nconf(req_conf, &ctx, req_exts, NULL)) {
                        BIO_printf(bio_err,
                         "Error Loading request extension section %s\n",
                                                                req_exts);
@@ -586,27 +611,13 @@ bad:
        if ((in == NULL) || (out == NULL))
                goto end;
 
-       if (engine != NULL)
-               {
-               if((e = ENGINE_by_id(engine)) == NULL)
-                       {
-                       BIO_printf(bio_err,"invalid engine \"%s\"\n",
-                               engine);
-                       goto end;
-                       }
-               if(!ENGINE_set_default(e, ENGINE_METHOD_ALL))
-                       {
-                       BIO_printf(bio_err,"can't use that engine\n");
-                       goto end;
-                       }
-               BIO_printf(bio_err,"engine \"%s\" set.\n", engine);
-               /* Free our "structural" reference. */
-               ENGINE_free(e);
-               }
+#ifndef OPENSSL_NO_ENGINE
+        e = setup_engine(bio_err, engine, 0);
+#endif
 
        if (keyfile != NULL)
                {
-               pkey = load_key(bio_err, keyfile, keyform, NULL, e,
+               pkey = load_key(bio_err, keyfile, keyform, 0, passin, e,
                        "Private Key");
                if (!pkey)
                        {
@@ -614,9 +625,10 @@ bad:
                           message */
                        goto end;
                        }
-               if (EVP_PKEY_type(pkey->type) == EVP_PKEY_DSA)
+               if (EVP_PKEY_type(pkey->type) == EVP_PKEY_DSA || 
+                       EVP_PKEY_type(pkey->type) == EVP_PKEY_EC)
                        {
-                       char *randfile = CONF_get_string(req_conf,SECTION,"RANDFILE");
+                       char *randfile = NCONF_get_string(req_conf,SECTION,"RANDFILE");
                        if (randfile == NULL)
                                ERR_clear_error();
                        app_RAND_load_file(randfile, bio_err, 0);
@@ -625,7 +637,7 @@ bad:
 
        if (newreq && (pkey == NULL))
                {
-               char *randfile = CONF_get_string(req_conf,SECTION,"RANDFILE");
+               char *randfile = NCONF_get_string(req_conf,SECTION,"RANDFILE");
                if (randfile == NULL)
                        ERR_clear_error();
                app_RAND_load_file(randfile, bio_err, 0);
@@ -634,48 +646,45 @@ bad:
        
                if (newkey <= 0)
                        {
-                       newkey=(int)CONF_get_number(req_conf,SECTION,BITS);
-                       if (newkey <= 0)
+                       if (!NCONF_get_number(req_conf,SECTION,BITS, &newkey))
                                newkey=DEFAULT_KEY_LENGTH;
                        }
 
-               if (newkey < MIN_KEY_LENGTH)
+               if (newkey < MIN_KEY_LENGTH && (pkey_type == EVP_PKEY_RSA || pkey_type == EVP_PKEY_DSA))
                        {
                        BIO_printf(bio_err,"private key length is too short,\n");
-                       BIO_printf(bio_err,"it needs to be at least %d bits, not %d\n",MIN_KEY_LENGTH,newkey);
+                       BIO_printf(bio_err,"it needs to be at least %d bits, not %ld\n",MIN_KEY_LENGTH,newkey);
                        goto end;
                        }
-               BIO_printf(bio_err,"Generating a %d bit %s private key\n",
-                       newkey,(pkey_type == TYPE_RSA)?"RSA":"DSA");
 
-               if ((pkey=EVP_PKEY_new()) == NULL) goto end;
-
-#ifndef OPENSSL_NO_RSA
-               if (pkey_type == TYPE_RSA)
+               if (!genctx)
                        {
-                       if (!EVP_PKEY_assign_RSA(pkey,
-                               RSA_generate_key(newkey,0x10001,
-                                       req_cb,bio_err)))
+                       genctx = set_keygen_ctx(bio_err, NULL, &newkey,
+                                                       &keyalgstr, e);
+                       if (!genctx)
                                goto end;
                        }
-               else
-#endif
-#ifndef OPENSSL_NO_DSA
-                       if (pkey_type == TYPE_DSA)
+
+               BIO_printf(bio_err,"Generating a %ld bit %s private key\n",
+                               newkey, keyalgstr);
+
+               EVP_PKEY_CTX_set_cb(genctx, genpkey_cb);
+               EVP_PKEY_CTX_set_app_data(genctx, bio_err);
+
+               if (EVP_PKEY_keygen(genctx, &pkey) <= 0)
                        {
-                       if (!DSA_generate_key(dsa_params)) goto end;
-                       if (!EVP_PKEY_assign_DSA(pkey,dsa_params)) goto end;
-                       dsa_params=NULL;
+                       BIO_puts(bio_err, "Error Generating Key\n");
+                       goto end;
                        }
-#endif
 
-               app_RAND_write_file(randfile, bio_err);
+               EVP_PKEY_CTX_free(genctx);
+               genctx = NULL;
 
-               if (pkey == NULL) goto end;
+               app_RAND_write_file(randfile, bio_err);
 
                if (keyout == NULL)
                        {
-                       keyout=CONF_get_string(req_conf,SECTION,KEYFILE);
+                       keyout=NCONF_get_string(req_conf,SECTION,KEYFILE);
                        if (keyout == NULL)
                                ERR_clear_error();
                        }
@@ -701,11 +710,11 @@ bad:
                                }
                        }
 
-               p=CONF_get_string(req_conf,SECTION,"encrypt_rsa_key");
+               p=NCONF_get_string(req_conf,SECTION,"encrypt_rsa_key");
                if (p == NULL)
                        {
                        ERR_clear_error();
-                       p=CONF_get_string(req_conf,SECTION,"encrypt_key");
+                       p=NCONF_get_string(req_conf,SECTION,"encrypt_key");
                        if (p == NULL)
                                ERR_clear_error();
                        }
@@ -770,10 +779,7 @@ loop:
                        BIO_printf(bio_err,"you need to specify a private key\n");
                        goto end;
                        }
-#ifndef OPENSSL_NO_DSA
-               if (pkey->type == EVP_PKEY_DSA)
-                       digest=EVP_dss1();
-#endif
+
                if (req == NULL)
                        {
                        req=X509_REQ_new();
@@ -782,7 +788,7 @@ loop:
                                goto end;
                                }
 
-                       i=make_REQ(req,pkey,subj,!x509);
+                       i=make_REQ(req,pkey,subj,multirdn,!x509, chtype);
                        subj=NULL; /* done processing '-subj' option */
                        if ((kludge > 0) && !sk_X509_ATTRIBUTE_num(req->req_info->attributes))
                                {
@@ -802,30 +808,33 @@ loop:
                        if ((x509ss=X509_new()) == NULL) goto end;
 
                        /* Set version to V3 */
-                       if(!X509_set_version(x509ss, 2)) goto end;
+                       if(extensions && !X509_set_version(x509ss, 2)) goto end;
                        if (serial)
-                               X509_set_serialNumber(x509ss, serial);
+                               {
+                               if (!X509_set_serialNumber(x509ss, serial)) goto end;
+                               }
                        else
-                               ASN1_INTEGER_set(X509_get_serialNumber(x509ss),0L);
-
-                       X509_set_issuer_name(x509ss,
-                               X509_REQ_get_subject_name(req));
-                       X509_gmtime_adj(X509_get_notBefore(x509ss),0);
-                       X509_gmtime_adj(X509_get_notAfter(x509ss),
-                               (long)60*60*24*days);
-                       X509_set_subject_name(x509ss,
-                               X509_REQ_get_subject_name(req));
+                               {
+                               if (!rand_serial(NULL,
+                                       X509_get_serialNumber(x509ss)))
+                                               goto end;
+                               }
+
+                       if (!X509_set_issuer_name(x509ss, X509_REQ_get_subject_name(req))) goto end;
+                       if (!X509_gmtime_adj(X509_get_notBefore(x509ss),0)) goto end;
+                       if (!X509_gmtime_adj(X509_get_notAfter(x509ss), (long)60*60*24*days)) goto end;
+                       if (!X509_set_subject_name(x509ss, X509_REQ_get_subject_name(req))) goto end;
                        tmppkey = X509_REQ_get_pubkey(req);
-                       X509_set_pubkey(x509ss,tmppkey);
+                       if (!tmppkey || !X509_set_pubkey(x509ss,tmppkey)) goto end;
                        EVP_PKEY_free(tmppkey);
 
                        /* Set up V3 context struct */
 
                        X509V3_set_ctx(&ext_ctx, x509ss, x509ss, NULL, NULL, 0);
-                       X509V3_set_conf_lhash(&ext_ctx, req_conf);
+                       X509V3_set_nconf(&ext_ctx, req_conf);
 
                        /* Add extensions */
-                       if(extensions && !X509V3_EXT_add_conf(req_conf, 
+                       if(extensions && !X509V3_EXT_add_nconf(req_conf, 
                                        &ext_ctx, extensions, x509ss))
                                {
                                BIO_printf(bio_err,
@@ -835,7 +844,10 @@ loop:
                                }
                        
                        if (!(i=X509_sign(x509ss,pkey,digest)))
+                               {
+                               ERR_print_errors(bio_err);
                                goto end;
+                               }
                        }
                else
                        {
@@ -844,10 +856,10 @@ loop:
                        /* Set up V3 context struct */
 
                        X509V3_set_ctx(&ext_ctx, NULL, NULL, req, NULL, 0);
-                       X509V3_set_conf_lhash(&ext_ctx, req_conf);
+                       X509V3_set_nconf(&ext_ctx, req_conf);
 
                        /* Add extensions */
-                       if(req_exts && !X509V3_EXT_REQ_add_conf(req_conf, 
+                       if(req_exts && !X509V3_EXT_REQ_add_nconf(req_conf, 
                                        &ext_ctx, req_exts, req))
                                {
                                BIO_printf(bio_err,
@@ -856,7 +868,10 @@ loop:
                                goto end;
                                }
                        if (!(i=X509_REQ_sign(req,pkey,digest)))
+                               {
+                               ERR_print_errors(bio_err);
                                goto end;
+                               }
                        }
                }
 
@@ -874,7 +889,7 @@ loop:
                        print_name(bio_err, "old subject=", X509_REQ_get_subject_name(req), nmflag);
                        }
 
-               if (build_subject(req, subj) == 0)
+               if (build_subject(req, subj, chtype, multirdn) == 0)
                        {
                        BIO_printf(bio_err, "ERROR: cannot modify subject\n");
                        ex=1;
@@ -913,12 +928,13 @@ loop:
                else if (i == 0)
                        {
                        BIO_printf(bio_err,"verify failure\n");
+                       ERR_print_errors(bio_err);
                        }
                else /* if (i > 0) */
                        BIO_printf(bio_err,"verify OK\n");
                }
 
-       if (noout && !text && !modulus && !subject)
+       if (noout && !text && !modulus && !subject && !pubkey)
                {
                ex=0;
                goto end;
@@ -947,12 +963,26 @@ loop:
                        }
                }
 
+       if (pubkey)
+               {
+               EVP_PKEY *tpubkey; 
+               tpubkey=X509_REQ_get_pubkey(req);
+               if (tpubkey == NULL)
+                       {
+                       BIO_printf(bio_err,"Error getting public key\n");
+                       ERR_print_errors(bio_err);
+                       goto end;
+                       }
+               PEM_write_bio_PUBKEY(out, tpubkey);
+               EVP_PKEY_free(tpubkey);
+               }
+
        if (text)
                {
                if (x509)
-                       X509_print(out,x509ss);
+                       X509_print_ex(out, x509ss, nmflag, reqflag);
                else    
-                       X509_REQ_print(out,req);
+                       X509_REQ_print_ex(out, req, nmflag, reqflag);
                }
 
        if(subject) 
@@ -965,24 +995,25 @@ loop:
 
        if (modulus)
                {
-               EVP_PKEY *pubkey;
+               EVP_PKEY *tpubkey;
 
                if (x509)
-                       pubkey=X509_get_pubkey(x509ss);
+                       tpubkey=X509_get_pubkey(x509ss);
                else
-                       pubkey=X509_REQ_get_pubkey(req);
-               if (pubkey == NULL)
+                       tpubkey=X509_REQ_get_pubkey(req);
+               if (tpubkey == NULL)
                        {
                        fprintf(stdout,"Modulus=unavailable\n");
                        goto end; 
                        }
                fprintf(stdout,"Modulus=");
 #ifndef OPENSSL_NO_RSA
-               if (pubkey->type == EVP_PKEY_RSA)
-                       BN_print(out,pubkey->pkey.rsa->n);
+               if (EVP_PKEY_base_id(tpubkey) == EVP_PKEY_RSA)
+                       BN_print(out,tpubkey->pkey.rsa->n);
                else
 #endif
                        fprintf(stdout,"Wrong Algorithm type");
+               EVP_PKEY_free(tpubkey);
                fprintf(stdout,"\n");
                }
 
@@ -1021,14 +1052,20 @@ loop:
                }
        ex=0;
 end:
+#ifndef MONOLITH
+       if(to_free)
+               OPENSSL_free(to_free);
+#endif
        if (ex)
                {
                ERR_print_errors(bio_err);
                }
-       if ((req_conf != NULL) && (req_conf != config)) CONF_free(req_conf);
+       if ((req_conf != NULL) && (req_conf != config)) NCONF_free(req_conf);
        BIO_free(in);
        BIO_free_all(out);
        EVP_PKEY_free(pkey);
+       if (genctx)
+               EVP_PKEY_CTX_free(genctx);
        X509_REQ_free(req);
        X509_free(x509ss);
        ASN1_INTEGER_free(serial);
@@ -1038,36 +1075,41 @@ end:
 #ifndef OPENSSL_NO_DSA
        if (dsa_params != NULL) DSA_free(dsa_params);
 #endif
-       EXIT(ex);
+#ifndef OPENSSL_NO_ECDSA
+       if (ec_params != NULL) EC_KEY_free(ec_params);
+#endif
+       apps_shutdown();
+       OPENSSL_EXIT(ex);
        }
 
-static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
+static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int multirdn,
+                       int attribs, unsigned long chtype)
        {
        int ret=0,i;
        char no_prompt = 0;
        STACK_OF(CONF_VALUE) *dn_sk, *attr_sk = NULL;
        char *tmp, *dn_sect,*attr_sect;
 
-       tmp=CONF_get_string(req_conf,SECTION,PROMPT);
+       tmp=NCONF_get_string(req_conf,SECTION,PROMPT);
        if (tmp == NULL)
                ERR_clear_error();
        if((tmp != NULL) && !strcmp(tmp, "no")) no_prompt = 1;
 
-       dn_sect=CONF_get_string(req_conf,SECTION,DISTINGUISHED_NAME);
+       dn_sect=NCONF_get_string(req_conf,SECTION,DISTINGUISHED_NAME);
        if (dn_sect == NULL)
                {
                BIO_printf(bio_err,"unable to find '%s' in config\n",
                        DISTINGUISHED_NAME);
                goto err;
                }
-       dn_sk=CONF_get_section(req_conf,dn_sect);
+       dn_sk=NCONF_get_section(req_conf,dn_sect);
        if (dn_sk == NULL)
                {
                BIO_printf(bio_err,"unable to get '%s' section\n",dn_sect);
                goto err;
                }
 
-       attr_sect=CONF_get_string(req_conf,SECTION,ATTRIBUTES);
+       attr_sect=NCONF_get_string(req_conf,SECTION,ATTRIBUTES);
        if (attr_sect == NULL)
                {
                ERR_clear_error();              
@@ -1075,7 +1117,7 @@ static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
                }
        else
                {
-               attr_sk=CONF_get_section(req_conf,attr_sect);
+               attr_sk=NCONF_get_section(req_conf,attr_sect);
                if (attr_sk == NULL)
                        {
                        BIO_printf(bio_err,"unable to get '%s' section\n",attr_sect);
@@ -1087,81 +1129,39 @@ static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
        if (!X509_REQ_set_version(req,0L)) goto err; /* version 1 */
 
        if (no_prompt) 
-               i = auto_info(req, dn_sk, attr_sk, attribs);
+               i = auto_info(req, dn_sk, attr_sk, attribs, chtype);
        else 
                {
                if (subj)
-                       i = build_subject(req, subj);
+                       i = build_subject(req, subj, chtype, multirdn);
                else
-                       i = prompt_info(req, dn_sk, dn_sect, attr_sk, attr_sect, attribs);
+                       i = prompt_info(req, dn_sk, dn_sect, attr_sk, attr_sect, attribs, chtype);
                }
        if(!i) goto err;
 
-       X509_REQ_set_pubkey(req,pkey);
+       if (!X509_REQ_set_pubkey(req,pkey)) goto err;
 
        ret=1;
 err:
        return(ret);
        }
 
-static int build_subject(X509_REQ *req, char *subject)
+/*
+ * subject is expected to be in the format /type0=value0/type1=value1/type2=...
+ * where characters may be escaped by \
+ */
+static int build_subject(X509_REQ *req, char *subject, unsigned long chtype, int multirdn)
        {
-       X509_NAME *n = NULL;
-
-       int i, nid, ne_num=0;
-
-       char *ne_name = NULL;
-       char *ne_value = NULL;
-
-       char *tmp = NULL;
-       char *p[2];
-
-       char *str_list[256];
-       
-       p[0] = ",/";
-        p[1] = "=";
-
-       n = X509_NAME_new();
-
-       tmp = strtok(subject, p[0]);
-       while((tmp != NULL) && (ne_num < (sizeof str_list/sizeof *str_list)))
-               {
-               char *token = tmp;
-
-               while (token[0] == ' ')
-                       token++;
-               str_list[ne_num] = token;
-
-               tmp = strtok(NULL, p[0]);
-               ne_num++;
-               }
+       X509_NAME *n;
 
-       for(i = 0; i < ne_num; i++)
-               {
-               ne_name  = strtok(str_list[i], p[1]);
-               ne_value = strtok(NULL, p[1]);
-
-               if ((nid=OBJ_txt2nid(ne_name)) == NID_undef)
-                       {
-                       BIO_printf(bio_err, "Subject Attribute %s has no known NID, skipped\n", ne_name);
-                       continue;
-                       }
-
-               if (ne_value == NULL)
-                       {
-                       BIO_printf(bio_err, "No value provided for Subject Attribute %s, skipped\n", ne_name);
-                       continue;
-                       }
-
-               if (!X509_NAME_add_entry_by_NID(n, nid, MBSTRING_ASC, (unsigned char*)ne_value, -1,-1,0))
-                       {
-                       X509_NAME_free(n);
-                       return 0;
-                       }
-               }
+       if (!(n = parse_name(subject, chtype, multirdn)))
+               return 0;
 
        if (!X509_REQ_set_subject_name(req, n))
+               {
+               X509_NAME_free(n);
                return 0;
+               }
        X509_NAME_free(n);
        return 1;
 }
@@ -1169,13 +1169,16 @@ static int build_subject(X509_REQ *req, char *subject)
 
 static int prompt_info(X509_REQ *req,
                STACK_OF(CONF_VALUE) *dn_sk, char *dn_sect,
-               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs)
+               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs,
+               unsigned long chtype)
        {
        int i;
        char *p,*q;
        char buf[100];
-       int nid,min,max;
-       char *type,*def,*value;
+       int nid, mval;
+       long n_min,n_max;
+       char *type, *value;
+       const char *def;
        CONF_VALUE *v;
        X509_NAME *subj;
        subj = X509_REQ_get_subject_name(req);
@@ -1216,30 +1219,51 @@ start:          for (;;)
                                        if(*p) type = p;
                                        break;
                                }
+                       if (*type == '+')
+                               {
+                               mval = -1;
+                               type++;
+                               }
+                       else
+                               mval = 0;
                        /* If OBJ not recognised ignore it */
                        if ((nid=OBJ_txt2nid(type)) == NID_undef) goto start;
-                       sprintf(buf,"%s_default",v->name);
-                       if ((def=CONF_get_string(req_conf,dn_sect,buf)) == NULL)
+                       if (BIO_snprintf(buf,sizeof buf,"%s_default",v->name)
+                               >= (int)sizeof(buf))
+                          {
+                          BIO_printf(bio_err,"Name '%s' too long\n",v->name);
+                          return 0;
+                          }
+
+                       if ((def=NCONF_get_string(req_conf,dn_sect,buf)) == NULL)
                                {
                                ERR_clear_error();
                                def="";
                                }
                                
-                       sprintf(buf,"%s_value",v->name);
-                       if ((value=CONF_get_string(req_conf,dn_sect,buf)) == NULL)
+                       BIO_snprintf(buf,sizeof buf,"%s_value",v->name);
+                       if ((value=NCONF_get_string(req_conf,dn_sect,buf)) == NULL)
                                {
                                ERR_clear_error();
                                value=NULL;
                                }
 
-                       sprintf(buf,"%s_min",v->name);
-                       min=(int)CONF_get_number(req_conf,dn_sect,buf);
+                       BIO_snprintf(buf,sizeof buf,"%s_min",v->name);
+                       if (!NCONF_get_number(req_conf,dn_sect,buf, &n_min))
+                               {
+                               ERR_clear_error();
+                               n_min = -1;
+                               }
 
-                       sprintf(buf,"%s_max",v->name);
-                       max=(int)CONF_get_number(req_conf,dn_sect,buf);
+                       BIO_snprintf(buf,sizeof buf,"%s_max",v->name);
+                       if (!NCONF_get_number(req_conf,dn_sect,buf, &n_max))
+                               {
+                               ERR_clear_error();
+                               n_max = -1;
+                               }
 
                        if (!add_DN_object(subj,v->value,def,value,nid,
-                               min,max))
+                               n_min,n_max, chtype, mval))
                                return 0;
                        }
                if (X509_NAME_entry_count(subj) == 0)
@@ -1269,8 +1293,14 @@ start2:                  for (;;)
                                if ((nid=OBJ_txt2nid(type)) == NID_undef)
                                        goto start2;
 
-                               sprintf(buf,"%s_default",type);
-                               if ((def=CONF_get_string(req_conf,attr_sect,buf))
+                               if (BIO_snprintf(buf,sizeof buf,"%s_default",type)
+                                       >= (int)sizeof(buf))
+                                  {
+                                  BIO_printf(bio_err,"Name '%s' too long\n",v->name);
+                                  return 0;
+                                  }
+
+                               if ((def=NCONF_get_string(req_conf,attr_sect,buf))
                                        == NULL)
                                        {
                                        ERR_clear_error();
@@ -1278,22 +1308,24 @@ start2:                 for (;;)
                                        }
                                
                                
-                               sprintf(buf,"%s_value",type);
-                               if ((value=CONF_get_string(req_conf,attr_sect,buf))
+                               BIO_snprintf(buf,sizeof buf,"%s_value",type);
+                               if ((value=NCONF_get_string(req_conf,attr_sect,buf))
                                        == NULL)
                                        {
                                        ERR_clear_error();
                                        value=NULL;
                                        }
 
-                               sprintf(buf,"%s_min",type);
-                               min=(int)CONF_get_number(req_conf,attr_sect,buf);
+                               BIO_snprintf(buf,sizeof buf,"%s_min",type);
+                               if (!NCONF_get_number(req_conf,attr_sect,buf, &n_min))
+                                       n_min = -1;
 
-                               sprintf(buf,"%s_max",type);
-                               max=(int)CONF_get_number(req_conf,attr_sect,buf);
+                               BIO_snprintf(buf,sizeof buf,"%s_max",type);
+                               if (!NCONF_get_number(req_conf,attr_sect,buf, &n_max))
+                                       n_max = -1;
 
                                if (!add_attribute_object(req,
-                                       v->value,def,value,nid,min,max))
+                                       v->value,def,value,nid,n_min,n_max, chtype))
                                        return 0;
                                }
                        }
@@ -1309,7 +1341,7 @@ start2:                   for (;;)
        }
 
 static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
-                       STACK_OF(CONF_VALUE) *attr_sk, int attribs)
+                       STACK_OF(CONF_VALUE) *attr_sk, int attribs, unsigned long chtype)
        {
        int i;
        char *p,*q;
@@ -1321,6 +1353,7 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
 
        for (i = 0; i < sk_CONF_VALUE_num(dn_sk); i++)
                {
+               int mval;
                v=sk_CONF_VALUE_value(dn_sk,i);
                p=q=NULL;
                type=v->name;
@@ -1337,8 +1370,19 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
                                if(*p) type = p;
                                break;
                        }
-               if (!X509_NAME_add_entry_by_txt(subj,type, MBSTRING_ASC,
-                               (unsigned char *) v->value,-1,-1,0)) return 0;
+#ifndef CHARSET_EBCDIC
+               if (*p == '+')
+#else
+               if (*p == os_toascii['+'])
+#endif
+                       {
+                       p++;
+                       mval = -1;
+                       }
+               else
+                       mval = 0;
+               if (!X509_NAME_add_entry_by_txt(subj,type, chtype,
+                               (unsigned char *) v->value,-1,-1,mval)) return 0;
 
                }
 
@@ -1352,7 +1396,7 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
                        for (i = 0; i < sk_CONF_VALUE_num(attr_sk); i++)
                                {
                                v=sk_CONF_VALUE_value(attr_sk,i);
-                               if(!X509_REQ_add1_attr_by_txt(req, v->name, MBSTRING_ASC,
+                               if(!X509_REQ_add1_attr_by_txt(req, v->name, chtype,
                                        (unsigned char *)v->value, -1)) return 0;
                                }
                        }
@@ -1360,8 +1404,8 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
        }
 
 
-static int add_DN_object(X509_NAME *n, char *text, char *def, char *value,
-            int nid, int min, int max)
+static int add_DN_object(X509_NAME *n, char *text, const char *def, char *value,
+            int nid, int n_min, int n_max, unsigned long chtype, int mval)
        {
        int i,ret=0;
        MS_STATIC char buf[1024];
@@ -1370,8 +1414,8 @@ start:
        (void)BIO_flush(bio_err);
        if(value != NULL)
                {
-               strcpy(buf,value);
-               strcat(buf,"\n");
+               BUF_strlcpy(buf,value,sizeof buf);
+               BUF_strlcat(buf,"\n",sizeof buf);
                BIO_printf(bio_err,"%s\n",value);
                }
        else
@@ -1379,7 +1423,7 @@ start:
                buf[0]='\0';
                if (!batch)
                        {
-                       fgets(buf,1024,stdin);
+                       fgets(buf,sizeof buf,stdin);
                        }
                else
                        {
@@ -1393,8 +1437,8 @@ start:
                {
                if ((def == NULL) || (def[0] == '\0'))
                        return(1);
-               strcpy(buf,def);
-               strcat(buf,"\n");
+               BUF_strlcpy(buf,def,sizeof buf);
+               BUF_strlcat(buf,"\n",sizeof buf);
                }
        else if ((buf[0] == '.') && (buf[1] == '\n')) return(1);
 
@@ -1408,17 +1452,17 @@ start:
 #ifdef CHARSET_EBCDIC
        ebcdic2ascii(buf, buf, i);
 #endif
-       if(!req_check_len(i, min, max)) goto start;
-       if (!X509_NAME_add_entry_by_NID(n,nid, MBSTRING_ASC,
-                               (unsigned char *) buf, -1,-1,0)) goto err;
+       if(!req_check_len(i, n_min, n_max)) goto start;
+       if (!X509_NAME_add_entry_by_NID(n,nid, chtype,
+                               (unsigned char *) buf, -1,-1,mval)) goto err;
        ret=1;
 err:
        return(ret);
        }
 
-static int add_attribute_object(X509_REQ *req, char *text,
-                               char *def, char *value, int nid, int min,
-                               int max)
+static int add_attribute_object(X509_REQ *req, char *text, const char *def,
+                               char *value, int nid, int n_min,
+                               int n_max, unsigned long chtype)
        {
        int i;
        static char buf[1024];
@@ -1428,8 +1472,8 @@ start:
        (void)BIO_flush(bio_err);
        if (value != NULL)
                {
-               strcpy(buf,value);
-               strcat(buf,"\n");
+               BUF_strlcpy(buf,value,sizeof buf);
+               BUF_strlcat(buf,"\n",sizeof buf);
                BIO_printf(bio_err,"%s\n",value);
                }
        else
@@ -1437,7 +1481,7 @@ start:
                buf[0]='\0';
                if (!batch)
                        {
-                       fgets(buf,1024,stdin);
+                       fgets(buf,sizeof buf,stdin);
                        }
                else
                        {
@@ -1451,8 +1495,8 @@ start:
                {
                if ((def == NULL) || (def[0] == '\0'))
                        return(1);
-               strcpy(buf,def);
-               strcat(buf,"\n");
+               BUF_strlcpy(buf,def,sizeof buf);
+               BUF_strlcat(buf,"\n",sizeof buf);
                }
        else if ((buf[0] == '.') && (buf[1] == '\n')) return(1);
 
@@ -1466,9 +1510,9 @@ start:
 #ifdef CHARSET_EBCDIC
        ebcdic2ascii(buf, buf, i);
 #endif
-       if(!req_check_len(i, min, max)) goto start;
+       if(!req_check_len(i, n_min, n_max)) goto start;
 
-       if(!X509_REQ_add1_attr_by_NID(req, nid, MBSTRING_ASC,
+       if(!X509_REQ_add1_attr_by_NID(req, nid, chtype,
                                        (unsigned char *)buf, -1)) {
                BIO_printf(bio_err, "Error adding attribute\n");
                ERR_print_errors(bio_err);
@@ -1480,46 +1524,195 @@ err:
        return(0);
        }
 
-#ifndef OPENSSL_NO_RSA
-static void MS_CALLBACK req_cb(int p, int n, void *arg)
+static int req_check_len(int len, int n_min, int n_max)
        {
-       char c='*';
-
-       if (p == 0) c='.';
-       if (p == 1) c='+';
-       if (p == 2) c='*';
-       if (p == 3) c='\n';
-       BIO_write((BIO *)arg,&c,1);
-       (void)BIO_flush((BIO *)arg);
-#ifdef LINT
-       p=n;
-#endif
-       }
-#endif
-
-static int req_check_len(int len, int min, int max)
-       {
-       if (len < min)
+       if ((n_min > 0) && (len < n_min))
                {
-               BIO_printf(bio_err,"string is too short, it needs to be at least %d bytes long\n",min);
+               BIO_printf(bio_err,"string is too short, it needs to be at least %d bytes long\n",n_min);
                return(0);
                }
-       if ((max != 0) && (len > max))
+       if ((n_max >= 0) && (len > n_max))
                {
-               BIO_printf(bio_err,"string is too long, it needs to be less than  %d bytes long\n",max);
+               BIO_printf(bio_err,"string is too long, it needs to be less than  %d bytes long\n",n_max);
                return(0);
                }
        return(1);
        }
 
 /* Check if the end of a string matches 'end' */
-static int check_end(char *str, char *end)
+static int check_end(const char *str, const char *end)
 {
        int elen, slen; 
-       char *tmp;
+       const char *tmp;
        elen = strlen(end);
        slen = strlen(str);
        if(elen > slen) return 1;
        tmp = str + slen - elen;
        return strcmp(tmp, end);
 }
+
+static EVP_PKEY_CTX *set_keygen_ctx(BIO *err, const char *gstr,
+                                       long *pkeylen, const char **palgnam,
+                                       ENGINE *e)
+       {
+       EVP_PKEY_CTX *gctx = NULL;
+       EVP_PKEY *param = NULL;
+       long keylen = -1;
+       int pkey_type = -1;
+       BIO *pbio = NULL;
+       const char *paramfile = NULL;
+
+       if (gstr == NULL)
+               {
+               pkey_type = EVP_PKEY_RSA;
+               keylen = *pkeylen;
+               }
+       else if (gstr[0] >= '0' && gstr[0] <= '9')
+               {
+               pkey_type = EVP_PKEY_RSA;
+               keylen = atol(gstr);
+               *pkeylen = keylen;
+               }
+       else if (!strncmp(gstr, "param:", 6))
+               paramfile = gstr + 6;
+       else
+               {
+               const char *p = strchr(gstr, ':');
+               int len;
+               const EVP_PKEY_ASN1_METHOD *ameth;
+
+               if (p)
+                       len = p - gstr;
+               else
+                       len = strlen(gstr);
+
+               ameth = EVP_PKEY_asn1_find_str(gstr, len);
+
+               if (!ameth)
+                       {
+                       BIO_printf(err, "Unknown algorithm %.*s\n", len, gstr);
+                       return NULL;
+                       }
+
+               EVP_PKEY_asn1_get0_info(NULL, &pkey_type, NULL, NULL, NULL,
+                                               ameth);
+               if (pkey_type == EVP_PKEY_RSA)
+                       {
+                       if (p)
+                               {
+                               keylen = atol(p + 1);
+                               *pkeylen = keylen;
+                               }
+                       }
+               else if (p)
+                       paramfile = p + 1;
+               }
+
+       if (paramfile)
+               {
+               pbio = BIO_new_file(paramfile, "r");
+               if (!pbio)
+                       {
+                       BIO_printf(err, "Can't open parameter file %s\n",
+                                       paramfile);
+                       return NULL;
+                       }
+               param = PEM_read_bio_Parameters(pbio, NULL);
+
+               if (!param)
+                       {
+                       X509 *x;
+                       BIO_reset(pbio);
+                       x = PEM_read_bio_X509(pbio, NULL, NULL, NULL);
+                       if (x)
+                               {
+                               param = X509_get_pubkey(x);
+                               X509_free(x);
+                               }
+                       }
+
+               BIO_free(pbio);
+
+               if (!param)
+                       {
+                       BIO_printf(err, "Error reading parameter file %s\n",
+                                       paramfile);
+                       return NULL;
+                       }
+               if (pkey_type == -1)
+                       pkey_type = EVP_PKEY_id(param);
+               else if (pkey_type != EVP_PKEY_base_id(param))
+                       {
+                       BIO_printf(err, "Key Type does not match parameters\n");
+                       EVP_PKEY_free(param);
+                       return NULL;
+                       }
+               }
+
+       if (palgnam)
+               {
+               const EVP_PKEY_ASN1_METHOD *ameth;
+               ameth = EVP_PKEY_asn1_find(pkey_type);
+               if (!ameth)
+                       {
+                       BIO_puts(err, "Internal error: can't find key algorithm\n");
+                       return NULL;
+                       }
+               EVP_PKEY_asn1_get0_info(NULL, NULL, NULL, NULL, palgnam,
+                                               ameth);
+               }
+
+       if (param)
+               {
+               gctx = EVP_PKEY_CTX_new(param, e);
+               *pkeylen = EVP_PKEY_bits(param);
+               EVP_PKEY_free(param);
+               }
+       else
+               gctx = EVP_PKEY_CTX_new_id(pkey_type, e);
+
+       if (!gctx)
+               {
+               BIO_puts(err, "Error allocating keygen context\n");
+               ERR_print_errors(err);
+               return NULL;
+               }
+
+       if (EVP_PKEY_keygen_init(gctx) <= 0)
+               {
+               BIO_puts(err, "Error initializing keygen context\n");
+               ERR_print_errors(err);
+               return NULL;
+               }
+
+       if ((pkey_type == EVP_PKEY_RSA) && (keylen != -1))
+               {
+               if (EVP_PKEY_CTX_set_rsa_keygen_bits(gctx, keylen) <= 0)
+                       {
+                       BIO_puts(err, "Error setting RSA keysize\n");
+                       ERR_print_errors(err);
+                       EVP_PKEY_CTX_free(gctx);
+                       return NULL;
+                       }
+               }
+
+       return gctx;
+       }
+
+static int genpkey_cb(EVP_PKEY_CTX *ctx)
+       {
+       char c='*';
+       BIO *b = EVP_PKEY_CTX_get_app_data(ctx);
+       int p;
+       p = EVP_PKEY_CTX_get_keygen_info(ctx, 0);
+       if (p == 0) c='.';
+       if (p == 1) c='+';
+       if (p == 2) c='*';
+       if (p == 3) c='\n';
+       BIO_write(b,&c,1);
+       (void)BIO_flush(b);
+#ifdef LINT
+       p=n;
+#endif
+       return 1;
+       }