Fix email address delete code.
[openssl.git] / apps / req.c
index 429eb9d4a0e781768bb91579d73ca2d7a3ba7bd3..dc08d6d7a559c0237e7f1cc58cae8d862b79fb7c 100644 (file)
@@ -73,7 +73,6 @@
 #include <openssl/x509v3.h>
 #include <openssl/objects.h>
 #include <openssl/pem.h>
-#include <openssl/engine.h>
 
 #define SECTION                "req"
 
@@ -85,6 +84,7 @@
 #define V3_EXTENSIONS  "x509_extensions"
 #define REQ_EXTENSIONS "req_extensions"
 #define STRING_MASK    "string_mask"
+#define UTF8_IN                "utf8"
 
 #define DEFAULT_KEY_LENGTH     512
 #define MIN_KEY_LENGTH         384
  *               require.  This format is wrong
  */
 
-static int make_REQ(X509_REQ *req,EVP_PKEY *pkey,char *dn,int attribs);
-static int build_subject(X509_REQ *req, char *subj);
+static int make_REQ(X509_REQ *req,EVP_PKEY *pkey,char *dn,int attribs,
+               unsigned long chtype);
+static int build_subject(X509_REQ *req, char *subj, unsigned long chtype);
 static int prompt_info(X509_REQ *req,
                STACK_OF(CONF_VALUE) *dn_sk, char *dn_sect,
-               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs);
+               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs,
+               unsigned long chtype);
 static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *sk,
-                               STACK_OF(CONF_VALUE) *attr, int attribs);
+                               STACK_OF(CONF_VALUE) *attr, int attribs,
+                               unsigned long chtype);
 static int add_attribute_object(X509_REQ *req, char *text,
-                               char *def, char *value, int nid, int min,
-                               int max);
+                               char *def, char *value, int nid, int n_min,
+                               int n_max, unsigned long chtype);
 static int add_DN_object(X509_NAME *n, char *text, char *def, char *value,
-       int nid,int min,int max);
+       int nid,int n_min,int n_max, unsigned long chtype);
 #ifndef OPENSSL_NO_RSA
 static void MS_CALLBACK req_cb(int p,int n,void *arg);
 #endif
-static int req_check_len(int len,int min,int max);
+static int req_check_len(int len,int n_min,int n_max);
 static int check_end(char *str, char *end);
 #ifndef MONOLITH
 static char *default_config_file=NULL;
-static LHASH *config=NULL;
+static CONF *config=NULL;
 #endif
-static LHASH *req_conf=NULL;
+static CONF *req_conf=NULL;
 static int batch=0;
 
 #define TYPE_RSA       1
@@ -152,7 +155,8 @@ int MAIN(int argc, char **argv)
        X509 *x509ss=NULL;
        X509_REQ *req=NULL;
        EVP_PKEY *pkey=NULL;
-       int i,badops=0,newreq=0,newkey= -1,verbose=0,pkey_type=TYPE_RSA;
+       int i=0,badops=0,newreq=0,verbose=0,pkey_type=TYPE_RSA;
+       long newkey = -1;
        BIO *in=NULL,*out=NULL;
        int informat,outformat,verify=0,noout=0,text=0,keyform=FORMAT_PEM;
        int nodes=0,kludge=0,newhdr=0,subject=0;
@@ -169,6 +173,7 @@ int MAIN(int argc, char **argv)
        char *p;
        char *subj = NULL;
        const EVP_MD *md_alg=NULL,*digest=EVP_md5();
+       unsigned long chtype = MBSTRING_ASC;
 #ifndef MONOLITH
        MS_STATIC char config_name[256];
 #endif
@@ -338,6 +343,8 @@ int MAIN(int argc, char **argv)
                        noout=1;
                else if (strcmp(*argv,"-verbose") == 0)
                        verbose=1;
+               else if (strcmp(*argv,"-utf8") == 0)
+                       chtype = MBSTRING_UTF8;
                else if (strcmp(*argv,"-nameopt") == 0)
                        {
                        if (--argc < 1) goto bad;
@@ -420,7 +427,7 @@ bad:
                BIO_printf(bio_err,"                the random number generator\n");
                BIO_printf(bio_err," -newkey rsa:bits generate a new RSA key of 'bits' in size\n");
                BIO_printf(bio_err," -newkey dsa:file generate a new DSA key, parameters taken from CA in 'file'\n");
-               BIO_printf(bio_err," -[digest]      Digest to sign with (md5, sha1, md2, mdc2)\n");
+               BIO_printf(bio_err," -[digest]      Digest to sign with (md5, sha1, md2, mdc2, md4)\n");
                BIO_printf(bio_err," -config file   request template file.\n");
                BIO_printf(bio_err," -subj arg      set or modify request subject\n");
                BIO_printf(bio_err," -new           new request.\n");
@@ -433,6 +440,7 @@ bad:
                BIO_printf(bio_err,"                have been reported as requiring\n");
                BIO_printf(bio_err," -extensions .. specify certificate extension section (override value in config file)\n");
                BIO_printf(bio_err," -reqexts ..    specify request extension section (override value in config file)\n");
+               BIO_printf(bio_err," -utf8          input characters are UTF8 (default ASCII)\n");
                goto end;
                }
 
@@ -457,7 +465,8 @@ bad:
                p=config_name;
                }
        default_config_file=p;
-       config=CONF_load(config,p,NULL);
+       config=NCONF_new(NULL);
+       i=NCONF_load(config, p);
 #endif
 
        if (template != NULL)
@@ -465,8 +474,9 @@ bad:
                long errline;
 
                BIO_printf(bio_err,"Using configuration from %s\n",template);
-               req_conf=CONF_load(NULL,template,&errline);
-               if (req_conf == NULL)
+               req_conf=NCONF_new(NULL);
+               i=NCONF_load(req_conf,template,&errline);
+               if (i == 0)
                        {
                        BIO_printf(bio_err,"error on line %ld of %s\n",errline,template);
                        goto end;
@@ -485,7 +495,7 @@ bad:
 
        if (req_conf != NULL)
                {
-               p=CONF_get_string(req_conf,NULL,"oid_file");
+               p=NCONF_get_string(req_conf,NULL,"oid_file");
                if (p == NULL)
                        ERR_clear_error();
                if (p != NULL)
@@ -511,7 +521,7 @@ bad:
 
        if (md_alg == NULL)
                {
-               p=CONF_get_string(req_conf,SECTION,"default_md");
+               p=NCONF_get_string(req_conf,SECTION,"default_md");
                if (p == NULL)
                        ERR_clear_error();
                if (p != NULL)
@@ -523,7 +533,7 @@ bad:
 
        if (!extensions)
                {
-               extensions = CONF_get_string(req_conf, SECTION, V3_EXTENSIONS);
+               extensions = NCONF_get_string(req_conf, SECTION, V3_EXTENSIONS);
                if (!extensions)
                        ERR_clear_error();
                }
@@ -531,8 +541,8 @@ bad:
                /* Check syntax of file */
                X509V3_CTX ctx;
                X509V3_set_ctx_test(&ctx);
-               X509V3_set_conf_lhash(&ctx, req_conf);
-               if(!X509V3_EXT_add_conf(req_conf, &ctx, extensions, NULL)) {
+               X509V3_set_nconf(&ctx, req_conf);
+               if(!X509V3_EXT_add_nconf(req_conf, &ctx, extensions, NULL)) {
                        BIO_printf(bio_err,
                         "Error Loading extension section %s\n", extensions);
                        goto end;
@@ -541,19 +551,19 @@ bad:
 
        if(!passin)
                {
-               passin = CONF_get_string(req_conf, SECTION, "input_password");
+               passin = NCONF_get_string(req_conf, SECTION, "input_password");
                if (!passin)
                        ERR_clear_error();
                }
        
        if(!passout)
                {
-               passout = CONF_get_string(req_conf, SECTION, "output_password");
+               passout = NCONF_get_string(req_conf, SECTION, "output_password");
                if (!passout)
                        ERR_clear_error();
                }
 
-       p = CONF_get_string(req_conf, SECTION, STRING_MASK);
+       p = NCONF_get_string(req_conf, SECTION, STRING_MASK);
        if (!p)
                ERR_clear_error();
 
@@ -562,9 +572,19 @@ bad:
                goto end;
        }
 
+       if (chtype != MBSTRING_UTF8)
+               {
+               p = NCONF_get_string(req_conf, SECTION, UTF8_IN);
+               if (!p)
+                       ERR_clear_error();
+               else if (!strcmp(p, "yes"))
+                       chtype = MBSTRING_UTF8;
+               }
+
+
        if(!req_exts)
                {
-               req_exts = CONF_get_string(req_conf, SECTION, REQ_EXTENSIONS);
+               req_exts = NCONF_get_string(req_conf, SECTION, REQ_EXTENSIONS);
                if (!req_exts)
                        ERR_clear_error();
                }
@@ -572,8 +592,8 @@ bad:
                /* Check syntax of file */
                X509V3_CTX ctx;
                X509V3_set_ctx_test(&ctx);
-               X509V3_set_conf_lhash(&ctx, req_conf);
-               if(!X509V3_EXT_add_conf(req_conf, &ctx, req_exts, NULL)) {
+               X509V3_set_nconf(&ctx, req_conf);
+               if(!X509V3_EXT_add_nconf(req_conf, &ctx, req_exts, NULL)) {
                        BIO_printf(bio_err,
                         "Error Loading request extension section %s\n",
                                                                req_exts);
@@ -586,27 +606,11 @@ bad:
        if ((in == NULL) || (out == NULL))
                goto end;
 
-       if (engine != NULL)
-               {
-               if((e = ENGINE_by_id(engine)) == NULL)
-                       {
-                       BIO_printf(bio_err,"invalid engine \"%s\"\n",
-                               engine);
-                       goto end;
-                       }
-               if(!ENGINE_set_default(e, ENGINE_METHOD_ALL))
-                       {
-                       BIO_printf(bio_err,"can't use that engine\n");
-                       goto end;
-                       }
-               BIO_printf(bio_err,"engine \"%s\" set.\n", engine);
-               /* Free our "structural" reference. */
-               ENGINE_free(e);
-               }
+        e = setup_engine(bio_err, engine, 0);
 
        if (keyfile != NULL)
                {
-               pkey = load_key(bio_err, keyfile, keyform, NULL, e,
+               pkey = load_key(bio_err, keyfile, keyform, passin, e,
                        "Private Key");
                if (!pkey)
                        {
@@ -616,7 +620,7 @@ bad:
                        }
                if (EVP_PKEY_type(pkey->type) == EVP_PKEY_DSA)
                        {
-                       char *randfile = CONF_get_string(req_conf,SECTION,"RANDFILE");
+                       char *randfile = NCONF_get_string(req_conf,SECTION,"RANDFILE");
                        if (randfile == NULL)
                                ERR_clear_error();
                        app_RAND_load_file(randfile, bio_err, 0);
@@ -625,7 +629,7 @@ bad:
 
        if (newreq && (pkey == NULL))
                {
-               char *randfile = CONF_get_string(req_conf,SECTION,"RANDFILE");
+               char *randfile = NCONF_get_string(req_conf,SECTION,"RANDFILE");
                if (randfile == NULL)
                        ERR_clear_error();
                app_RAND_load_file(randfile, bio_err, 0);
@@ -634,8 +638,7 @@ bad:
        
                if (newkey <= 0)
                        {
-                       newkey=(int)CONF_get_number(req_conf,SECTION,BITS);
-                       if (newkey <= 0)
+                       if (!NCONF_get_number(req_conf,SECTION,BITS, &newkey))
                                newkey=DEFAULT_KEY_LENGTH;
                        }
 
@@ -675,7 +678,7 @@ bad:
 
                if (keyout == NULL)
                        {
-                       keyout=CONF_get_string(req_conf,SECTION,KEYFILE);
+                       keyout=NCONF_get_string(req_conf,SECTION,KEYFILE);
                        if (keyout == NULL)
                                ERR_clear_error();
                        }
@@ -701,11 +704,11 @@ bad:
                                }
                        }
 
-               p=CONF_get_string(req_conf,SECTION,"encrypt_rsa_key");
+               p=NCONF_get_string(req_conf,SECTION,"encrypt_rsa_key");
                if (p == NULL)
                        {
                        ERR_clear_error();
-                       p=CONF_get_string(req_conf,SECTION,"encrypt_key");
+                       p=NCONF_get_string(req_conf,SECTION,"encrypt_key");
                        if (p == NULL)
                                ERR_clear_error();
                        }
@@ -782,7 +785,7 @@ loop:
                                goto end;
                                }
 
-                       i=make_REQ(req,pkey,subj,!x509);
+                       i=make_REQ(req,pkey,subj,!x509, chtype);
                        subj=NULL; /* done processing '-subj' option */
                        if ((kludge > 0) && !sk_X509_ATTRIBUTE_num(req->req_info->attributes))
                                {
@@ -822,10 +825,10 @@ loop:
                        /* Set up V3 context struct */
 
                        X509V3_set_ctx(&ext_ctx, x509ss, x509ss, NULL, NULL, 0);
-                       X509V3_set_conf_lhash(&ext_ctx, req_conf);
+                       X509V3_set_nconf(&ext_ctx, req_conf);
 
                        /* Add extensions */
-                       if(extensions && !X509V3_EXT_add_conf(req_conf, 
+                       if(extensions && !X509V3_EXT_add_nconf(req_conf, 
                                        &ext_ctx, extensions, x509ss))
                                {
                                BIO_printf(bio_err,
@@ -844,10 +847,10 @@ loop:
                        /* Set up V3 context struct */
 
                        X509V3_set_ctx(&ext_ctx, NULL, NULL, req, NULL, 0);
-                       X509V3_set_conf_lhash(&ext_ctx, req_conf);
+                       X509V3_set_nconf(&ext_ctx, req_conf);
 
                        /* Add extensions */
-                       if(req_exts && !X509V3_EXT_REQ_add_conf(req_conf, 
+                       if(req_exts && !X509V3_EXT_REQ_add_nconf(req_conf, 
                                        &ext_ctx, req_exts, req))
                                {
                                BIO_printf(bio_err,
@@ -874,7 +877,7 @@ loop:
                        print_name(bio_err, "old subject=", X509_REQ_get_subject_name(req), nmflag);
                        }
 
-               if (build_subject(req, subj) == 0)
+               if (build_subject(req, subj, chtype) == 0)
                        {
                        BIO_printf(bio_err, "ERROR: cannot modify subject\n");
                        ex=1;
@@ -913,6 +916,7 @@ loop:
                else if (i == 0)
                        {
                        BIO_printf(bio_err,"verify failure\n");
+                       ERR_print_errors(bio_err);
                        }
                else /* if (i > 0) */
                        BIO_printf(bio_err,"verify OK\n");
@@ -1025,7 +1029,7 @@ end:
                {
                ERR_print_errors(bio_err);
                }
-       if ((req_conf != NULL) && (req_conf != config)) CONF_free(req_conf);
+       if ((req_conf != NULL) && (req_conf != config)) NCONF_free(req_conf);
        BIO_free(in);
        BIO_free_all(out);
        EVP_PKEY_free(pkey);
@@ -1038,36 +1042,38 @@ end:
 #ifndef OPENSSL_NO_DSA
        if (dsa_params != NULL) DSA_free(dsa_params);
 #endif
+       apps_shutdown();
        EXIT(ex);
        }
 
-static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
+static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs,
+                       unsigned long chtype)
        {
        int ret=0,i;
        char no_prompt = 0;
        STACK_OF(CONF_VALUE) *dn_sk, *attr_sk = NULL;
        char *tmp, *dn_sect,*attr_sect;
 
-       tmp=CONF_get_string(req_conf,SECTION,PROMPT);
+       tmp=NCONF_get_string(req_conf,SECTION,PROMPT);
        if (tmp == NULL)
                ERR_clear_error();
        if((tmp != NULL) && !strcmp(tmp, "no")) no_prompt = 1;
 
-       dn_sect=CONF_get_string(req_conf,SECTION,DISTINGUISHED_NAME);
+       dn_sect=NCONF_get_string(req_conf,SECTION,DISTINGUISHED_NAME);
        if (dn_sect == NULL)
                {
                BIO_printf(bio_err,"unable to find '%s' in config\n",
                        DISTINGUISHED_NAME);
                goto err;
                }
-       dn_sk=CONF_get_section(req_conf,dn_sect);
+       dn_sk=NCONF_get_section(req_conf,dn_sect);
        if (dn_sk == NULL)
                {
                BIO_printf(bio_err,"unable to get '%s' section\n",dn_sect);
                goto err;
                }
 
-       attr_sect=CONF_get_string(req_conf,SECTION,ATTRIBUTES);
+       attr_sect=NCONF_get_string(req_conf,SECTION,ATTRIBUTES);
        if (attr_sect == NULL)
                {
                ERR_clear_error();              
@@ -1075,7 +1081,7 @@ static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
                }
        else
                {
-               attr_sk=CONF_get_section(req_conf,attr_sect);
+               attr_sk=NCONF_get_section(req_conf,attr_sect);
                if (attr_sk == NULL)
                        {
                        BIO_printf(bio_err,"unable to get '%s' section\n",attr_sect);
@@ -1087,13 +1093,13 @@ static int make_REQ(X509_REQ *req, EVP_PKEY *pkey, char *subj, int attribs)
        if (!X509_REQ_set_version(req,0L)) goto err; /* version 1 */
 
        if (no_prompt) 
-               i = auto_info(req, dn_sk, attr_sk, attribs);
+               i = auto_info(req, dn_sk, attr_sk, attribs, chtype);
        else 
                {
                if (subj)
-                       i = build_subject(req, subj);
+                       i = build_subject(req, subj, chtype);
                else
-                       i = prompt_info(req, dn_sk, dn_sect, attr_sk, attr_sect, attribs);
+                       i = prompt_info(req, dn_sk, dn_sect, attr_sk, attr_sect, attribs, chtype);
                }
        if(!i) goto err;
 
@@ -1104,7 +1110,7 @@ err:
        return(ret);
        }
 
-static int build_subject(X509_REQ *req, char *subject)
+static int build_subject(X509_REQ *req, char *subject, unsigned long chtype)
        {
        X509_NAME *n = NULL;
 
@@ -1153,7 +1159,7 @@ static int build_subject(X509_REQ *req, char *subject)
                        continue;
                        }
 
-               if (!X509_NAME_add_entry_by_NID(n, nid, MBSTRING_ASC, (unsigned char*)ne_value, -1,-1,0))
+               if (!X509_NAME_add_entry_by_NID(n, nid, chtype, (unsigned char*)ne_value, -1,-1,0))
                        {
                        X509_NAME_free(n);
                        return 0;
@@ -1169,12 +1175,14 @@ static int build_subject(X509_REQ *req, char *subject)
 
 static int prompt_info(X509_REQ *req,
                STACK_OF(CONF_VALUE) *dn_sk, char *dn_sect,
-               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs)
+               STACK_OF(CONF_VALUE) *attr_sk, char *attr_sect, int attribs,
+               unsigned long chtype)
        {
        int i;
        char *p,*q;
        char buf[100];
-       int nid,min,max;
+       int nid;
+       long n_min,n_max;
        char *type,*def,*value;
        CONF_VALUE *v;
        X509_NAME *subj;
@@ -1219,27 +1227,29 @@ start:          for (;;)
                        /* If OBJ not recognised ignore it */
                        if ((nid=OBJ_txt2nid(type)) == NID_undef) goto start;
                        sprintf(buf,"%s_default",v->name);
-                       if ((def=CONF_get_string(req_conf,dn_sect,buf)) == NULL)
+                       if ((def=NCONF_get_string(req_conf,dn_sect,buf)) == NULL)
                                {
                                ERR_clear_error();
                                def="";
                                }
                                
                        sprintf(buf,"%s_value",v->name);
-                       if ((value=CONF_get_string(req_conf,dn_sect,buf)) == NULL)
+                       if ((value=NCONF_get_string(req_conf,dn_sect,buf)) == NULL)
                                {
                                ERR_clear_error();
                                value=NULL;
                                }
 
                        sprintf(buf,"%s_min",v->name);
-                       min=(int)CONF_get_number(req_conf,dn_sect,buf);
+                       if (!NCONF_get_number(req_conf,dn_sect,buf, &n_min))
+                               n_min = -1;
 
                        sprintf(buf,"%s_max",v->name);
-                       max=(int)CONF_get_number(req_conf,dn_sect,buf);
+                       if (!NCONF_get_number(req_conf,dn_sect,buf, &n_max))
+                               n_max = -1;
 
                        if (!add_DN_object(subj,v->value,def,value,nid,
-                               min,max))
+                               n_min,n_max, chtype))
                                return 0;
                        }
                if (X509_NAME_entry_count(subj) == 0)
@@ -1270,7 +1280,7 @@ start2:                   for (;;)
                                        goto start2;
 
                                sprintf(buf,"%s_default",type);
-                               if ((def=CONF_get_string(req_conf,attr_sect,buf))
+                               if ((def=NCONF_get_string(req_conf,attr_sect,buf))
                                        == NULL)
                                        {
                                        ERR_clear_error();
@@ -1279,7 +1289,7 @@ start2:                   for (;;)
                                
                                
                                sprintf(buf,"%s_value",type);
-                               if ((value=CONF_get_string(req_conf,attr_sect,buf))
+                               if ((value=NCONF_get_string(req_conf,attr_sect,buf))
                                        == NULL)
                                        {
                                        ERR_clear_error();
@@ -1287,13 +1297,15 @@ start2:                 for (;;)
                                        }
 
                                sprintf(buf,"%s_min",type);
-                               min=(int)CONF_get_number(req_conf,attr_sect,buf);
+                               if (!NCONF_get_number(req_conf,attr_sect,buf, &n_min))
+                                       n_min = -1;
 
                                sprintf(buf,"%s_max",type);
-                               max=(int)CONF_get_number(req_conf,attr_sect,buf);
+                               if (!NCONF_get_number(req_conf,attr_sect,buf, &n_max))
+                                       n_max = -1;
 
                                if (!add_attribute_object(req,
-                                       v->value,def,value,nid,min,max))
+                                       v->value,def,value,nid,n_min,n_max, chtype))
                                        return 0;
                                }
                        }
@@ -1309,7 +1321,7 @@ start2:                   for (;;)
        }
 
 static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
-                       STACK_OF(CONF_VALUE) *attr_sk, int attribs)
+                       STACK_OF(CONF_VALUE) *attr_sk, int attribs, unsigned long chtype)
        {
        int i;
        char *p,*q;
@@ -1337,7 +1349,7 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
                                if(*p) type = p;
                                break;
                        }
-               if (!X509_NAME_add_entry_by_txt(subj,type, MBSTRING_ASC,
+               if (!X509_NAME_add_entry_by_txt(subj,type, chtype,
                                (unsigned char *) v->value,-1,-1,0)) return 0;
 
                }
@@ -1352,7 +1364,7 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
                        for (i = 0; i < sk_CONF_VALUE_num(attr_sk); i++)
                                {
                                v=sk_CONF_VALUE_value(attr_sk,i);
-                               if(!X509_REQ_add1_attr_by_txt(req, v->name, MBSTRING_ASC,
+                               if(!X509_REQ_add1_attr_by_txt(req, v->name, chtype,
                                        (unsigned char *)v->value, -1)) return 0;
                                }
                        }
@@ -1361,7 +1373,7 @@ static int auto_info(X509_REQ *req, STACK_OF(CONF_VALUE) *dn_sk,
 
 
 static int add_DN_object(X509_NAME *n, char *text, char *def, char *value,
-            int nid, int min, int max)
+            int nid, int n_min, int n_max, unsigned long chtype)
        {
        int i,ret=0;
        MS_STATIC char buf[1024];
@@ -1408,8 +1420,8 @@ start:
 #ifdef CHARSET_EBCDIC
        ebcdic2ascii(buf, buf, i);
 #endif
-       if(!req_check_len(i, min, max)) goto start;
-       if (!X509_NAME_add_entry_by_NID(n,nid, MBSTRING_ASC,
+       if(!req_check_len(i, n_min, n_max)) goto start;
+       if (!X509_NAME_add_entry_by_NID(n,nid, chtype,
                                (unsigned char *) buf, -1,-1,0)) goto err;
        ret=1;
 err:
@@ -1417,8 +1429,8 @@ err:
        }
 
 static int add_attribute_object(X509_REQ *req, char *text,
-                               char *def, char *value, int nid, int min,
-                               int max)
+                               char *def, char *value, int nid, int n_min,
+                               int n_max, unsigned long chtype)
        {
        int i;
        static char buf[1024];
@@ -1466,9 +1478,9 @@ start:
 #ifdef CHARSET_EBCDIC
        ebcdic2ascii(buf, buf, i);
 #endif
-       if(!req_check_len(i, min, max)) goto start;
+       if(!req_check_len(i, n_min, n_max)) goto start;
 
-       if(!X509_REQ_add1_attr_by_NID(req, nid, MBSTRING_ASC,
+       if(!X509_REQ_add1_attr_by_NID(req, nid, chtype,
                                        (unsigned char *)buf, -1)) {
                BIO_printf(bio_err, "Error adding attribute\n");
                ERR_print_errors(bio_err);
@@ -1497,16 +1509,16 @@ static void MS_CALLBACK req_cb(int p, int n, void *arg)
        }
 #endif
 
-static int req_check_len(int len, int min, int max)
+static int req_check_len(int len, int n_min, int n_max)
        {
-       if (len < min)
+       if ((n_min > 0) && (len < n_min))
                {
-               BIO_printf(bio_err,"string is too short, it needs to be at least %d bytes long\n",min);
+               BIO_printf(bio_err,"string is too short, it needs to be at least %d bytes long\n",n_min);
                return(0);
                }
-       if ((max != 0) && (len > max))
+       if ((n_max >= 0) && (len > n_max))
                {
-               BIO_printf(bio_err,"string is too long, it needs to be less than  %d bytes long\n",max);
+               BIO_printf(bio_err,"string is too long, it needs to be less than  %d bytes long\n",n_max);
                return(0);
                }
        return(1);