From d6399c85b62e8300ae19cdc243d0b6a2696724bb Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Thu, 15 Nov 2018 14:50:52 +0000 Subject: [PATCH] Fix shlibloadtest to properly execute the dso_ref test Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/7983) --- test/shlibloadtest.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/test/shlibloadtest.c b/test/shlibloadtest.c index 53714aa125..5e4e4ca8db 100644 --- a/test/shlibloadtest.c +++ b/test/shlibloadtest.c @@ -117,6 +117,7 @@ static int test_lib(void) switch (test_type) { case JUST_CRYPTO: + case DSO_REFTEST: if (!TEST_true(shlib_load(path_crypto, &cryptolib))) goto end; break; @@ -130,10 +131,6 @@ static int test_lib(void) || !TEST_true(shlib_load(path_crypto, &cryptolib))) goto end; break; - case DSO_REFTEST: - if (!TEST_true(shlib_load(path_crypto, &cryptolib))) - goto end; - break; } if (test_type != JUST_CRYPTO && test_type != DSO_REFTEST) { @@ -205,6 +202,7 @@ static int test_lib(void) switch (test_type) { case JUST_CRYPTO: + case DSO_REFTEST: if (!TEST_true(shlib_close(cryptolib))) goto end; break; @@ -218,10 +216,6 @@ static int test_lib(void) || !TEST_true(shlib_close(cryptolib))) goto end; break; - case DSO_REFTEST: - if (!TEST_true(shlib_close(cryptolib))) - goto end; - break; } result = 1; @@ -242,7 +236,7 @@ int setup_tests(void) } else if (strcmp(p, "-just_crypto") == 0) { test_type = JUST_CRYPTO; } else if (strcmp(p, "-dso_ref") == 0) { - test_type = JUST_CRYPTO; + test_type = DSO_REFTEST; } else { TEST_error("Unrecognised argument"); return 0; -- 2.34.1