Fix the checks of EVP_PKEY_param_check

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/18424)

diff --git a/apps/dhparam.c b/apps/dhparam.c
index 764f7929d462e4f269606105ab90b0dbcb603815..c1d7168a6089d223912f4c0376972cbb67108e1a 100644 (file)
--- a/apps/dhparam.c
+++ b/apps/dhparam.c
@@ -329,7 +329,7 @@ int dhparam_main(int argc, char **argv)
             BIO_printf(bio_err, "Error, failed to check DH parameters\n");
             goto end;
         }
-        if (!EVP_PKEY_param_check(ctx)) {
+        if (EVP_PKEY_param_check(ctx) <= 0) {
             BIO_printf(bio_err, "Error, invalid parameters generated\n");
             goto end;
         }

diff --git a/apps/ecparam.c b/apps/ecparam.c
index 7ee19349dc4cb7ab6bbb8407c7ff4d8ab2f7d78c..608014be8f13e470bdebd219bdaa79781c1353e8 100644 (file)
--- a/apps/ecparam.c
+++ b/apps/ecparam.c
@@ -283,7 +283,7 @@ int ecparam_main(int argc, char **argv)
                 goto end;
         }
         pctx = EVP_PKEY_CTX_new_from_pkey(NULL, params_key, NULL);
-        if (pctx == NULL || !EVP_PKEY_param_check(pctx)) {
+        if (pctx == NULL || EVP_PKEY_param_check(pctx) <= 0) {
             BIO_printf(bio_err, "failed\n");
             goto end;
         }