Fix a return value bug in apps/speed.c
authorPaul Yang <kaishen.yy@antfin.com>
Mon, 30 Sep 2019 03:33:24 +0000 (11:33 +0800)
committerPaul Yang <kaishen.yy@antfin.com>
Mon, 30 Sep 2019 05:39:06 +0000 (13:39 +0800)
Those functions returns less than and equal to 0 to indicate an error
occured.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/10054)

apps/speed.c

index 59594f0e4966ac08f13cd0267be74336891428ea..33f77d3b2c01c6e3b11ebf7a919ec8463d9e8e02 100644 (file)
@@ -3249,8 +3249,8 @@ int speed_main(int argc, char **argv)
 
             if ((ed_pctx = EVP_PKEY_CTX_new_id(test_ed_curves[testnum].nid, NULL))
                     == NULL
-                || !EVP_PKEY_keygen_init(ed_pctx)
-                || !EVP_PKEY_keygen(ed_pctx, &ed_pkey)) {
+                || EVP_PKEY_keygen_init(ed_pctx) <= 0
+                || EVP_PKEY_keygen(ed_pctx, &ed_pkey) <= 0) {
                 st = 0;
                 EVP_PKEY_CTX_free(ed_pctx);
                 break;