apps.c: fix error messages (newline and needless text) in load_key_certs_crls()
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Thu, 3 Aug 2023 14:52:49 +0000 (16:52 +0200)
committerDr. David von Oheimb <dev@ddvo.net>
Tue, 5 Sep 2023 19:11:02 +0000 (21:11 +0200)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21659)

(cherry picked from commit 81d037b8adb0232c8a4d4654f79c883dafb102bc)

apps/lib/apps.c

index bbaecb8c724dcd44ae60189f7952c23dcfd48364..9d65333ec4ba0fcb96e90c4332338d2289febfa5 100644 (file)
@@ -940,7 +940,7 @@ int load_key_certs_crls(const char *uri, int format, int maybe_stdin,
         BIO *bio;
 
         if (!maybe_stdin) {
-            BIO_printf(bio_err, "No filename or uri specified for loading");
+            BIO_printf(bio_err, "No filename or uri specified for loading\n");
             goto end;
         }
         uri = "<stdin>";
@@ -956,10 +956,8 @@ int load_key_certs_crls(const char *uri, int format, int maybe_stdin,
         ctx = OSSL_STORE_open_ex(uri, libctx, propq, get_ui_method(), &uidata,
                                  params, NULL, NULL);
     }
-    if (ctx == NULL) {
-        BIO_printf(bio_err, "Could not open file or uri for loading");
+    if (ctx == NULL)
         goto end;
-    }
     if (expect > 0 && !OSSL_STORE_expect(ctx, expect))
         goto end;