TEST: Cleanup test recipes
authorRichard Levitte <levitte@openssl.org>
Wed, 10 Mar 2021 21:24:11 +0000 (22:24 +0100)
committerRichard Levitte <levitte@openssl.org>
Sat, 27 Mar 2021 08:03:55 +0000 (09:03 +0100)
Name mixups cleared, and a few more test case result files that
arent't removed, making forensics on failed tests easier.

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14505)

70 files changed:
test/recipes/02-test_internal_keymgmt.t
test/recipes/04-test_pem_reading.t [moved from test/recipes/04-test_pem.t with 100% similarity]
test/recipes/04-test_pem_reading_data/NOTES.txt [moved from test/recipes/04-test_pem_data/NOTES.txt with 100% similarity]
test/recipes/04-test_pem_reading_data/beermug.pem [moved from test/recipes/04-test_pem_data/beermug.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-1023line.pem [moved from test/recipes/04-test_pem_data/cert-1023line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-1024line.pem [moved from test/recipes/04-test_pem_data/cert-1024line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-1025line.pem [moved from test/recipes/04-test_pem_data/cert-1025line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-254-chars-at-the-end.pem [moved from test/recipes/04-test_pem_data/cert-254-chars-at-the-end.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-254-chars-in-the-middle.pem [moved from test/recipes/04-test_pem_data/cert-254-chars-in-the-middle.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-255line.pem [moved from test/recipes/04-test_pem_data/cert-255line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-256line.pem [moved from test/recipes/04-test_pem_data/cert-256line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-257line.pem [moved from test/recipes/04-test_pem_data/cert-257line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-blankline.pem [moved from test/recipes/04-test_pem_data/cert-blankline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-bom.pem [moved from test/recipes/04-test_pem_data/cert-bom.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-comment.pem [moved from test/recipes/04-test_pem_data/cert-comment.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-earlypad.pem [moved from test/recipes/04-test_pem_data/cert-earlypad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-extrapad.pem [moved from test/recipes/04-test_pem_data/cert-extrapad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-infixwhitespace.pem [moved from test/recipes/04-test_pem_data/cert-infixwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-junk.pem [moved from test/recipes/04-test_pem_data/cert-junk.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-leadingwhitespace.pem [moved from test/recipes/04-test_pem_data/cert-leadingwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-longline.pem [moved from test/recipes/04-test_pem_data/cert-longline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-misalignedpad.pem [moved from test/recipes/04-test_pem_data/cert-misalignedpad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-onecolumn.pem [moved from test/recipes/04-test_pem_data/cert-onecolumn.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-oneline-multiple-of-254.pem [moved from test/recipes/04-test_pem_data/cert-oneline-multiple-of-254.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-oneline.pem [moved from test/recipes/04-test_pem_data/cert-oneline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-shortandlongline.pem [moved from test/recipes/04-test_pem_data/cert-shortandlongline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-shortline.pem [moved from test/recipes/04-test_pem_data/cert-shortline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-threecolumn.pem [moved from test/recipes/04-test_pem_data/cert-threecolumn.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert-trailingwhitespace.pem [moved from test/recipes/04-test_pem_data/cert-trailingwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/cert.pem [moved from test/recipes/04-test_pem_data/cert.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/csr.pem [moved from test/recipes/04-test_pem_data/csr.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-1023line.pem [moved from test/recipes/04-test_pem_data/dsa-1023line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-1024line.pem [moved from test/recipes/04-test_pem_data/dsa-1024line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-1025line.pem [moved from test/recipes/04-test_pem_data/dsa-1025line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-255line.pem [moved from test/recipes/04-test_pem_data/dsa-255line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-256line.pem [moved from test/recipes/04-test_pem_data/dsa-256line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-257line.pem [moved from test/recipes/04-test_pem_data/dsa-257line.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-blankline.pem [moved from test/recipes/04-test_pem_data/dsa-blankline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-comment.pem [moved from test/recipes/04-test_pem_data/dsa-comment.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-corruptedheader.pem [moved from test/recipes/04-test_pem_data/dsa-corruptedheader.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-corruptiv.pem [moved from test/recipes/04-test_pem_data/dsa-corruptiv.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-earlypad.pem [moved from test/recipes/04-test_pem_data/dsa-earlypad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-extrapad.pem [moved from test/recipes/04-test_pem_data/dsa-extrapad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-infixwhitespace.pem [moved from test/recipes/04-test_pem_data/dsa-infixwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-junk.pem [moved from test/recipes/04-test_pem_data/dsa-junk.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-leadingwhitespace.pem [moved from test/recipes/04-test_pem_data/dsa-leadingwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-longline.pem [moved from test/recipes/04-test_pem_data/dsa-longline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-misalignedpad.pem [moved from test/recipes/04-test_pem_data/dsa-misalignedpad.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-onecolumn.pem [moved from test/recipes/04-test_pem_data/dsa-onecolumn.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-oneline.pem [moved from test/recipes/04-test_pem_data/dsa-oneline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-onelineheader.pem [moved from test/recipes/04-test_pem_data/dsa-onelineheader.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-shortandlongline.pem [moved from test/recipes/04-test_pem_data/dsa-shortandlongline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-shortline.pem [moved from test/recipes/04-test_pem_data/dsa-shortline.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-threecolumn.pem [moved from test/recipes/04-test_pem_data/dsa-threecolumn.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa-trailingwhitespace.pem [moved from test/recipes/04-test_pem_data/dsa-trailingwhitespace.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsa.pem [moved from test/recipes/04-test_pem_data/dsa.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/dsaparam.pem [moved from test/recipes/04-test_pem_data/dsaparam.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/key.pem [moved from test/recipes/04-test_pem_data/key.pem with 100% similarity]
test/recipes/04-test_pem_reading_data/wellknown [moved from test/recipes/04-test_pem_data/wellknown with 100% similarity]
test/recipes/06-test_rdrand_sanity.t [moved from test/recipes/06-test-rdrand.t with 100% similarity]
test/recipes/20-test_mac.t
test/recipes/25-test_eai_data.t
test/recipes/65-test_cmp_hdr.t
test/recipes/65-test_cmp_status.t
test/recipes/70-test_sslvertol.t
test/recipes/71-test_ssl_ctx.t
test/recipes/90-test_tls13encryption.t
test/recipes/90-test_tls13secrets.t
test/recipes/95-test_external_gost_engine.t
test/recipes/95-test_external_pyca.t

index f7b2eb3f1c73466473dd4fe85b8d0dbe2e67b4b4..2f78ed5ae495cfa2fb6fe0fcbba369578bdda85e 100644 (file)
@@ -11,7 +11,7 @@ use OpenSSL::Test qw(:DEFAULT bldtop_dir);
 use OpenSSL::Test::Simple;
 use OpenSSL::Test::Utils;
 
-setup("test_internal_provider");
+setup("test_internal_keymgmt");
 
 $ENV{OPENSSL_MODULES} = bldtop_dir("test");
 
index b6a8078763e44376a146f5492a619616f3ba9af7..ee5f77d361ef8380f8cf74d56e0ddf3ad1749575 100644 (file)
@@ -190,10 +190,9 @@ sub comparefile {
     my $buffer;
     my $BUFSIZE = 1024;
     read($out, $buffer, $BUFSIZE) or die "unable to read";
-    # Not unlinking $outfile
-
     my $line = uc unpack("H*", $buffer);
     close($out);
+    # Not unlinking $outfile
 
     if ($line eq $expect) {
         return 1;
index 9b42229e94960a2b287586fb566411ccee64e9f2..a314538e855c94d2465118a65f160b5081e73b77 100644 (file)
@@ -32,16 +32,21 @@ my $utf8_pem  = srctop_file($folder, "utf8_leaf.pem");
 my $ascii_chain_pem = srctop_file($folder, "ascii_chain.pem");
 my $utf8_chain_pem  = srctop_file($folder, "utf8_chain.pem");
 
-my $out = "san.tmp";
-
+my $out;
+my $outcnt = 0;
+sub outname {
+    $outcnt++;
+    return "sanout-$outcnt.tmp";
+}
+
+$out = outname();
 ok(run(app(["openssl", "x509", "-ext", "subjectAltName", "-in", $ascii_pem, "-noout", "-out", $out])));
 is(cmp_text($out, srctop_file($folder, "san.ascii")), 0, 'Comparing othername for ASCII domain');
 
+$out = outname();
 ok(run(app(["openssl", "x509", "-ext", "subjectAltName", "-in", $utf8_pem, "-noout", "-out", $out])));
 is(cmp_text($out, srctop_file($folder, "san.utf8")), 0, 'Comparing othername for IDN domain');
 
-unlink $out;
-
 ok(run(app(["openssl", "verify", "-nameopt", "utf8", "-no_check_time", "-verify_email", "学生\@elementary.school.example.com", "-CAfile", $ascii_chain_pem, $ascii_pem])));
 ok(run(app(["openssl", "verify", "-nameopt", "utf8", "-no_check_time", "-verify_email", "医生\@大学.example.com", "-CAfile", $utf8_chain_pem, $utf8_pem])));
 
index e013a6d82056067e84c6ae05f35c7e397a057ff2..9acb784d7e439f84b077fccce5bdb807d26a80d9 100644 (file)
@@ -12,7 +12,7 @@ use strict;
 use OpenSSL::Test qw/:DEFAULT data_file/;
 use OpenSSL::Test::Utils;
 
-setup("test_cmp_lib");
+setup("test_cmp_hdr");
 
 plan skip_all => "This test is not supported in a no-cmp build"
     if disabled("cmp");
index 6a0a0c06b62891b8b940bb4bd354cc799d8601e5..23f833f695a4a590877a5b3219fac8f112d72530 100644 (file)
@@ -12,7 +12,7 @@ use strict;
 use OpenSSL::Test qw/:DEFAULT data_file/;
 use OpenSSL::Test::Utils;
 
-setup("test_cmp_lib");
+setup("test_cmp_status");
 
 plan skip_all => "This test is not supported in a no-cmp build"
     if disabled("cmp");
index 775cf6df6724d770d53c7c4961fdff3e43334e2d..b254597c31262b96deba06e2780b31e52e05b29f 100644 (file)
@@ -11,7 +11,7 @@ use OpenSSL::Test qw/:DEFAULT cmdstr srctop_file bldtop_dir/;
 use OpenSSL::Test::Utils;
 use TLSProxy::Proxy;
 
-my $test_name = "test_sslextension";
+my $test_name = "test_sslvertol";
 setup($test_name);
 
 plan skip_all => "TLSProxy isn't usable on $^O"
index 6d5fc7a33813638d542c454f09f22af6742ec86f..a9af0ac0789ff9b51d9c8d8f18c401f7eb3a9c4c 100644 (file)
@@ -10,7 +10,7 @@ use strict;
 use warnings;
 use OpenSSL::Test;
 
-setup("ssl_ctx_test");
+setup("test_ssl_ctx");
 
 plan tests => 1;
 ok(run(test(["ssl_ctx_test"])));
index 7e4037e508f37bd93836fc543aed3ff409f887eb..06b33229d4b70d6c73103a72ed31720ffd1c284a 100644 (file)
@@ -9,7 +9,7 @@
 use OpenSSL::Test;
 use OpenSSL::Test::Utils;
 
-my $test_name = "tls13encryption";
+my $test_name = "test_tls13encryption";
 setup($test_name);
 
 plan skip_all => "$test_name is not supported in this build"
index 0adef9a9f59c85ae0fc3160552f867da14944bc9..72bb60fdb14d2e34740593b0b52517559e7eed77 100644 (file)
@@ -9,7 +9,7 @@
 use OpenSSL::Test;
 use OpenSSL::Test::Utils;
 
-my $test_name = "tls13secrets";
+my $test_name = "test_tls13secrets";
 setup($test_name);
 
 plan skip_all => "$test_name is not supported in this build"
index 204f78a928304e09c288617bd9096dfbaf7186fb..07097d3ef974f8538a02e39b1bee1fb39729ba99 100644 (file)
@@ -11,7 +11,7 @@ use OpenSSL::Test;
 use OpenSSL::Test::Utils;
 use OpenSSL::Test qw/:DEFAULT bldtop_file data_file srctop_file cmdstr/;
 
-setup("test_external");
+setup("test_external_gost_engine");
 
 plan skip_all => "No external tests in this configuration"
     if disabled("external-tests");
index 1eae23557f10e2acdda4962d8f80fc6bc021968b..5460d4987e4ff5b8b43eb0048f01d09f7694c256 100644 (file)
@@ -11,7 +11,7 @@ use OpenSSL::Test;
 use OpenSSL::Test::Utils;
 use OpenSSL::Test qw/:DEFAULT bldtop_file data_file srctop_file cmdstr/;
 
-setup("test_external");
+setup("test_external_pyca");
 
 plan skip_all => "No external tests in this configuration"
     if disabled("external-tests");