Ensure we raise SSLfatal on error
authorMatt Caswell <matt@openssl.org>
Thu, 22 Oct 2020 12:53:27 +0000 (13:53 +0100)
committerBenjamin Kaduk <bkaduk@akamai.com>
Mon, 26 Oct 2020 16:07:20 +0000 (09:07 -0700)
We were missing a call to SSLfatal. A comment claimed that we had already
called it - but that is incorrect.

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from https://github.com/openssl/openssl/pull/13229)

ssl/statem/statem_srvr.c

index 81cea6db3733880b44217e558b2b1d2911cb595d..033a640edd3f51ddeb57b4b1a72c28421202498a 100644 (file)
@@ -2588,7 +2588,7 @@ int tls_construct_server_key_exchange(SSL *s, WPACKET *pkt)
 
         s->s3.tmp.pkey = ssl_generate_pkey(s, pkdhp);
         if (s->s3.tmp.pkey == NULL) {
-            /* SSLfatal() already called */
+            SSLfatal(s, SSL_AD_INTERNAL_ERROR, 0, ERR_R_INTERNAL_ERROR);
             goto err;
         }