Another occurance of possible valgrind/purify "uninitialized memory"

complaint related to the PRNG: with PURIFY policy don't feed uninitialized
memory into the PRNG.

Submitted by: Bodo Moeller <bmoeller@openssl.org> :-)

diff --git a/crypto/rand/randfile.c b/crypto/rand/randfile.c
index cec5880a8f477805578b00a9967deb527125d99d..9b739f17e0ba6c2b1b57fe5e9654c718115de2a8 100644 (file)
--- a/crypto/rand/randfile.c
+++ b/crypto/rand/randfile.c
@@ -127,7 +127,11 @@ int RAND_load_file(const char *file, long bytes)
                i=fread(buf,1,n,in);
                if (i <= 0) break;
                /* even if n != i, use the full array */
+#ifdef PURIFY
+               RAND_add(buf,i,(double)i);
+#else
                RAND_add(buf,n,(double)i);
+#endif
                ret+=i;
                if (bytes > 0)
                        {