projects
/
openssl.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
be54ad8
)
Coverity: fix 1506297: negative returns
author
Pauli
<pauli@openssl.org>
Fri, 17 Jun 2022 01:02:52 +0000
(11:02 +1000)
committer
Pauli
<pauli@openssl.org>
Fri, 1 Jul 2022 06:36:21 +0000
(16:36 +1000)
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18587)
crypto/dsa/dsa_ameth.c
patch
|
blob
|
history
diff --git
a/crypto/dsa/dsa_ameth.c
b/crypto/dsa/dsa_ameth.c
index 1da67485e82007b271d84ee27a225196dff69972..482b9e1e0aa72ff5fc6e28595e3829842e43ff6d 100644
(file)
--- a/
crypto/dsa/dsa_ameth.c
+++ b/
crypto/dsa/dsa_ameth.c
@@
-198,6
+198,11
@@
static int dsa_priv_encode(PKCS8_PRIV_KEY_INFO *p8, const EVP_PKEY *pkey)
ASN1_STRING_clear_free(prkey);
+ if (dplen <= 0) {
+ ERR_raise(ERR_LIB_DSA, DSA_R_BN_ERROR);
+ goto err;
+ }
+
if (!PKCS8_pkey_set0(p8, OBJ_nid2obj(NID_dsa), 0,
V_ASN1_SEQUENCE, params, dp, dplen)) {
OPENSSL_clear_free(dp, dplen);