Resolve a stack set-up race condition (if the list of compression

methods isn't presorted, it will be sorted on first read).

Submitted by: Adam Langley

diff --git a/CHANGES b/CHANGES
index ab83fa21d2b8853c35beb6598b60f636c09f0116..a453a7bf8dad12f35605633eee6cb33db2535486 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -487,6 +487,9 @@
 
  Changes between 1.0.0e and 1.0.0f [xx XXX xxxx]
 
+  *) Fix ssl_ciph.c set-up race.
+     [Adam Langley (Google)]
+
   *) Fix spurious failures in ecdsatest.c.
      [Emilia Käsper (Google)]
 
@@ -1414,6 +1417,9 @@
   
  Changes between 0.9.8r and 0.9.8s [xx XXX xxxx]
 
+  *) Fix ssl_ciph.c set-up race.
+     [Adam Langley (Google)]
+
   *) Fix spurious failures in ecdsatest.c.
      [Emilia Käsper (Google)]
 

diff --git a/ssl/ssl_ciph.c b/ssl/ssl_ciph.c
index c03f02974859aa696921c31843b108dcc36359e4..ac643c928c390c60337e1d4d2ad53cb4cad59ce6 100644 (file)
--- a/ssl/ssl_ciph.c
+++ b/ssl/ssl_ciph.c
@@ -470,6 +470,7 @@ static void load_builtin_compressions(void)
                                                sk_SSL_COMP_push(ssl_comp_methods,comp);
                                                }
                                        }
+                                       sk_SSL_COMP_sort(ssl_comp_methods);
                                }
                        MemCheck_on();
                        }