Remove redundant check from tls1_get_curvelist
authorMatt Caswell <matt@openssl.org>
Mon, 9 Nov 2015 16:37:33 +0000 (16:37 +0000)
committerMatt Caswell <matt@openssl.org>
Mon, 9 Nov 2015 23:07:57 +0000 (23:07 +0000)
commit6329b6092b28b656be8a1e4a8363d2e3bcc32053
tree0efcf435a51855c4264dac744a7a7784321c899f
parent55646005a9ce3c85e394c6afae5f6ed6045494c6
Remove redundant check from tls1_get_curvelist

The function tls1_get_curvelist() has an explicit check to see if s->cert
is NULL or not. However the check appears *after* calling the tls1_suiteb
macro which derefs s->cert. In reality s->cert can never be NULL because
it is created in SSL_new(). If the malloc fails then the SSL_new call fails
and no SSL object is created.

Reviewed-by: Tim Hudson <tjh@openssl.org>
ssl/t1_lib.c