Remove a reachable assert from ssl3_write_bytes
authorMatt Caswell <matt@openssl.org>
Fri, 30 Oct 2015 17:01:01 +0000 (17:01 +0000)
committerMatt Caswell <matt@openssl.org>
Mon, 2 Nov 2015 14:29:37 +0000 (14:29 +0000)
commit1c2e5d560d5143d8fc1cf7e6b598199201e60a45
treec3ac20e6c28ac81451930194095eb4b461c54883
parent6929b4477b83c8e759ccc5dbc9483095e1c5a146
Remove a reachable assert from ssl3_write_bytes

A buggy application that call SSL_write with a different length after a
NBIO event could cause an OPENSSL_assert to be reached. The assert is not
actually necessary because there was an explicit check a little further
down that would catch this scenario. Therefore remove the assert an move
the check a little higher up.

Reviewed-by: Rich Salz <rsalz@openssl.org>
ssl/record/rec_layer_s3.c