tools.git
11 months agorelease-tools/stage-release.sh: Add a run of 'do-copyright-year'
Richard Levitte [Fri, 19 May 2023 09:33:59 +0000 (11:33 +0200)]
release-tools/stage-release.sh: Add a run of 'do-copyright-year'

We did this as a manual step when the release staging script was in another
repository.

Now that they are in the same repository (in the same directory, even!),
there's no reason not to run 'do-copyright-year' automatically.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/144)

11 months agoInclude the original HEAD in the porcelain output
Richard Levitte [Tue, 18 Apr 2023 13:58:48 +0000 (15:58 +0200)]
Include the original HEAD in the porcelain output

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/stage-release.sh: Use 'type -p' and realpath to find $0
Richard Levitte [Tue, 18 Apr 2023 08:17:58 +0000 (10:17 +0200)]
release-tools/stage-release.sh: Use 'type -p' and realpath to find $0

This allows the release-aux directory to be found, even when a symbolic
link to this script is used.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/stage-release.sh: Add --unsigned
Richard Levitte [Tue, 18 Apr 2023 08:15:35 +0000 (10:15 +0200)]
release-tools/stage-release.sh: Add --unsigned

This allows staging to produce unsigned files, and to add an annotated
but unsigned tag.  The signing can be done later, when promoting a staged
release to an actual release.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/stage-release.sh: Add a metadata file among the release files
Richard Levitte [Mon, 17 Apr 2023 12:57:28 +0000 (14:57 +0200)]
release-tools/stage-release.sh: Add a metadata file among the release files

This file contains shell variable assignments with diverse data that may
serve other release scripts.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoClarify that the release script only stages the release files
Richard Levitte [Mon, 17 Apr 2023 06:32:35 +0000 (08:32 +0200)]
Clarify that the release script only stages the release files

This renames release-tools/release.sh to release-tools/stage-release.sh,
and modifies the option --upload-address to --staging-address.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease.sh: Add --clean-worktree, --branch_fmt and --tag-fmt
Richard Levitte [Fri, 14 Apr 2023 10:31:11 +0000 (12:31 +0200)]
release.sh: Add --clean-worktree, --branch_fmt and --tag-fmt

This needed quite a bit of rearrangement to make sense.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease.sh: Also present the uploaded/to be uploaded files with --porcelain
Richard Levitte [Fri, 14 Apr 2023 09:35:32 +0000 (11:35 +0200)]
release.sh: Also present the uploaded/to be uploaded files with --porcelain

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease.sh: Add --quiet and --porcelain
Richard Levitte [Fri, 14 Apr 2023 09:10:07 +0000 (11:10 +0200)]
release.sh: Add --quiet and --porcelain

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoWhen checking for make update changes, only check tracked files
Richard Levitte [Mon, 3 Apr 2023 06:54:42 +0000 (08:54 +0200)]
When checking for make update changes, only check tracked files

Sometimes, 'make update' leaves behind files that aren't tracked, and this
shouldn't cause trying to add an extra commit.  However, we only checked
with 'git status --porcelain', which does list untracked files.  This can
cause release failure, so we add a few more options so git status doesn't
report on these files that should be ignored.

This also includes a documenting comment for a piece of the scripts that's
potentially confusing without the explanation.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoAdapt release-tools/release.sh for pre-3.0 versions
Richard Levitte [Thu, 30 Mar 2023 11:53:51 +0000 (13:53 +0200)]
Adapt release-tools/release.sh for pre-3.0 versions

There are small differences, such as some make targets not existing,
the method for creating tarballs being different in 1.0.2, ...

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoAdd an option to specify the upload address
Richard Levitte [Thu, 30 Mar 2023 10:11:34 +0000 (12:11 +0200)]
Add an option to specify the upload address

Both local directory and several forms of SCP/SFTP addresses are supported.
For the SCP/SFTP form, it is always translated to be usable with SFTP.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoAdapt documentation for the new release script, and clean up
Richard Levitte [Tue, 28 Mar 2023 06:38:21 +0000 (08:38 +0200)]
Adapt documentation for the new release script, and clean up

release-tools/release.sh and associated files should now be a good enough
replacement of release-tools/mkrelease.pl and associated files.
Therefore, HOWTO-make-a-release.md is adapted to only refer to the new
script, and release-tools/mkrelease.pl and associated files are removed.

Someone might want to ask, why shell scripts rather than perl?
The reasoning is that the OpenSSL team does most if not all its development
on Unix-like systems, and the release script is essentially a wrapper around
diverse shell commands anyway, it therefore seems sensible to use the shell
language.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/release.sh et al: introduce RELEASE_FILES and use it
Richard Levitte [Tue, 28 Mar 2023 05:46:32 +0000 (07:46 +0200)]
release-tools/release.sh et al: introduce RELEASE_FILES and use it

This is a variable that holds a list of files other than the version file,
that need to be touched up with release information.  This variable is set
by the version functions, as the files are varied, depending on the versio
scheme and series.

We also add the fixup files for all possible release files.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/release.sh et al: introduce FULL_VERSION and use it
Richard Levitte [Tue, 28 Mar 2023 05:43:41 +0000 (07:43 +0200)]
release-tools/release.sh et al: introduce FULL_VERSION and use it

This is a convenience variable, combined from $VERSION, $_PRE_RELEASE_TAG
and $_BUILD_METADATA.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoAdapt release-tools/release.sh for a life outside of the OpenSSL work tree
Richard Levitte [Tue, 28 Mar 2023 05:19:59 +0000 (07:19 +0200)]
Adapt release-tools/release.sh for a life outside of the OpenSSL work tree

This makes use of the VERSION_FILE variable that is delivered by
release-tools/release-aux/release-version-fn.sh

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoAdapt release-tools/release-aux/release-version-fn.sh for pre-3.0 versions
Richard Levitte [Tue, 28 Mar 2023 05:15:04 +0000 (07:15 +0200)]
Adapt release-tools/release-aux/release-version-fn.sh for pre-3.0 versions

This also adds a test script release-tools/release-aux/test_suite.sh, to
check that all these functions behave as expected.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agorelease-tools/release-aux/ documentation updates and small fixes
Richard Levitte [Tue, 28 Mar 2023 04:43:10 +0000 (06:43 +0200)]
release-tools/release-aux/ documentation updates and small fixes

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

11 months agoImport openssl/openssl's dev/release.sh and accompanying files
Richard Levitte [Fri, 24 Mar 2023 13:02:47 +0000 (14:02 +0100)]
Import openssl/openssl's dev/release.sh and accompanying files

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/140)

12 months agoDon't cross-post security advisories to oss-security
Matt Caswell [Thu, 23 Mar 2023 13:34:01 +0000 (13:34 +0000)]
Don't cross-post security advisories to oss-security

We should send any security advisory to oss-security separately and not
cross-post it with our own lists.

We also change the text to say that security advisories should be sent to
support-announce regardless of whether a premium release has been affected.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/139)

12 months agoAdd fuzz-corpora to review-tools
Tomas Mraz [Tue, 2 May 2023 18:44:11 +0000 (20:44 +0200)]
Add fuzz-corpora to review-tools

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/143)

12 months agopick-to-branch: warn if target remote is not in github.openssl.org
Dr. David von Oheimb [Thu, 20 Apr 2023 13:07:02 +0000 (15:07 +0200)]
pick-to-branch: warn if target remote is not in github.openssl.org

Fixes #141

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/142)

13 months agoUpdate the release HOWTO following the 3.1 release
Matt Caswell [Tue, 14 Mar 2023 14:25:55 +0000 (14:25 +0000)]
Update the release HOWTO following the 3.1 release

We now need to upload the release files to the "Releases" section of
github - so we update the HOWTO instructions accordingly.
This also fixes a minor error that was spotted during the release.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/128)

14 months agoUpdate README
zengwei2000 [Wed, 22 Feb 2023 01:10:44 +0000 (01:10 +0000)]
Update README

CLA: trivial
fix typo

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/137)

15 months agoAdd oss-security to the lists that receive advisory details
Matt Caswell [Wed, 8 Feb 2023 11:14:56 +0000 (11:14 +0000)]
Add oss-security to the lists that receive advisory details

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/135)

17 months agopick-to-branch: fix exit message by making variable name consistent
Dr. David von Oheimb [Thu, 8 Dec 2022 10:31:44 +0000 (11:31 +0100)]
pick-to-branch: fix exit message by making variable name consistent

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/133)

17 months agoghmerge: support handling conflicts on interactive rebase
Dr. David von Oheimb [Thu, 24 Nov 2022 21:28:28 +0000 (22:28 +0100)]
ghmerge: support handling conflicts on interactive rebase

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/132)

18 months agoCover the premium release as well
Richard Levitte [Fri, 21 Oct 2022 15:54:59 +0000 (17:54 +0200)]
Cover the premium release as well

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/130)

18 months agoUpdates of things that have aged
Richard Levitte [Fri, 21 Oct 2022 15:52:14 +0000 (17:52 +0200)]
Updates of things that have aged

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/130)

18 months agoreview-tools/opensslpull: add 3.1
Richard Levitte [Wed, 26 Oct 2022 12:09:17 +0000 (14:09 +0200)]
review-tools/opensslpull: add 3.1

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/131)

18 months agoghmerge: support handling conflicts on --cherry-pick
Dr. David von Oheimb [Wed, 19 Oct 2022 18:34:04 +0000 (20:34 +0200)]
ghmerge: support handling conflicts on --cherry-pick

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/129)

18 months agoThe command to freeze the repository isn't quite right, fix it
Richard Levitte [Tue, 11 Oct 2022 07:20:41 +0000 (09:20 +0200)]
The command to freeze the repository isn't quite right, fix it

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/128)

19 months agoghmerge and pick-to-branch: improve hints on how to handle conflicts
Dr. David von Oheimb [Sat, 24 Sep 2022 15:34:55 +0000 (17:34 +0200)]
ghmerge and pick-to-branch: improve hints on how to handle conflicts

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/126)

19 months ago3.0.0 is out so don't special case things as being deferred
Mark J. Cox [Mon, 14 Mar 2022 12:42:36 +0000 (12:42 +0000)]
3.0.0 is out so don't special case things as being deferred

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/127)

19 months agogmerge and pick-to-branch: further tweak output
Dr. David von Oheimb [Tue, 8 Mar 2022 16:30:27 +0000 (17:30 +0100)]
gmerge and pick-to-branch: further tweak output

Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/111)

20 months agoModify mkrelease.pl to have a different announce text for premium releases
Richard Levitte [Fri, 29 Jul 2022 11:38:13 +0000 (13:38 +0200)]
Modify mkrelease.pl to have a different announce text for premium releases

^CT-142 Closed

22 months agoHOWTO-make-a-release.md:take into account the moved secadv files
Richard Levitte [Fri, 10 Jun 2022 15:06:06 +0000 (17:06 +0200)]
HOWTO-make-a-release.md:take into account the moved secadv files

This includes vulnerabilities.xml and all of secadv/*

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/120)

22 months agoHOWTO-make-a-release.md: take into account the moved newsflash.txt
Richard Levitte [Fri, 10 Jun 2022 06:11:31 +0000 (08:11 +0200)]
HOWTO-make-a-release.md: take into account the moved newsflash.txt

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/120)

22 months agoUpdate HOWTO-make-a-release.md to refer to OpenSSL's Github instance
Richard Levitte [Fri, 10 Jun 2022 05:35:46 +0000 (07:35 +0200)]
Update HOWTO-make-a-release.md to refer to OpenSSL's Github instance

openssl-git@git.openssl.org:openssl.git is no more.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/119)

23 months agoDrop release-tools/README.md
Richard Levitte [Fri, 10 Jun 2022 05:01:20 +0000 (07:01 +0200)]
Drop release-tools/README.md

We have HOWTO-make-a-release.md, which is a more up to date version of
the same information.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/118)

23 months agoUpdate addrev to allow self-review on release
Hugo Landau [Fri, 13 May 2022 12:42:59 +0000 (13:42 +0100)]
Update addrev to allow self-review on release

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/117)

2 years agoThe web repo is governed by the OMC...
Richard Levitte [Mon, 4 Apr 2022 19:38:30 +0000 (21:38 +0200)]
The web repo is governed by the OMC...

... and should therefore require a minimum of one OMC member reviewing.

In a similar vein, we also specify that the tools repo is governed by
the OTC.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/114)

2 years agoDepending on the repo, authors may still count as a reviewer
Richard Levitte [Mon, 4 Apr 2022 19:37:19 +0000 (21:37 +0200)]
Depending on the repo, authors may still count as a reviewer

For the main repo, the author is never counted as a reviewer.
For the web and tools repos, the author is counted.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/114)

2 years agoAllow Release line to be added to all commits touched by addrev
Hugo Landau [Tue, 26 Apr 2022 06:03:26 +0000 (07:03 +0100)]
Allow Release line to be added to all commits touched by addrev

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/web/pull/115)

2 years agoSupport release review requirement bypass for 1.1.1/1.0.2
Hugo Landau [Fri, 22 Apr 2022 13:46:16 +0000 (14:46 +0100)]
Support release review requirement bypass for 1.1.1/1.0.2

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/web/pull/115)

2 years agopick-to-branch: Allow fixing trivial conflicts when cherry-picking
Tomas Mraz [Mon, 14 Mar 2022 14:22:39 +0000 (15:22 +0100)]
pick-to-branch: Allow fixing trivial conflicts when cherry-picking

Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/110)

2 years agoAdd the tool for GH openssl-machine to ping and close stale PRs
Mark J. Cox [Mon, 14 Mar 2022 11:09:50 +0000 (11:09 +0000)]
Add the tool for GH openssl-machine to ping and close stale PRs

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/108)

2 years agoDon't add the author to the unknown reviewers list
Matt Caswell [Tue, 8 Mar 2022 14:08:56 +0000 (14:08 +0000)]
Don't add the author to the unknown reviewers list

If the author is a known reviewer, don't add them to the unknown reviewers
list.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/107)

2 years agoghmerge: The default remote is on github.openssl.org
Tomas Mraz [Fri, 3 Dec 2021 11:51:56 +0000 (12:51 +0100)]
ghmerge: The default remote is on github.openssl.org

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/103)

2 years agoDon't let addrev count the author as a reviewer
Matt Caswell [Mon, 21 Feb 2022 11:34:35 +0000 (11:34 +0000)]
Don't let addrev count the author as a reviewer

As per the latest policy change the author is no longer counted as a
reviewer, so we ensure addrev disallows this.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/105)

2 years agopick-to-branch: restrict 'git pull --ff-only' to target branch
Dr. David von Oheimb [Fri, 26 Nov 2021 14:14:52 +0000 (15:14 +0100)]
pick-to-branch: restrict 'git pull --ff-only' to target branch

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/101)

2 years agopick-to-branch: allow 'h' or 'HEAD' as first argument, which leads to using the maste...
Dr. David von Oheimb [Fri, 26 Nov 2021 13:47:06 +0000 (14:47 +0100)]
pick-to-branch: allow 'h' or 'HEAD' as first argument, which leads to using the master HEAD

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/101)

2 years agopick-to-branch: restore to original commit HEAD of target on error/abort
Dr. David von Oheimb [Fri, 26 Nov 2021 13:34:01 +0000 (14:34 +0100)]
pick-to-branch: restore to original commit HEAD of target on error/abort

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/101)

2 years agopick-to-branch: rename 'branch' to 'target' for clarity
Dr. David von Oheimb [Fri, 26 Nov 2021 11:04:39 +0000 (12:04 +0100)]
pick-to-branch: rename 'branch' to 'target' for clarity

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/101)

2 years agopick-to-branch: improve user guidance and streamline interaction
Dr. David von Oheimb [Fri, 26 Nov 2021 11:00:02 +0000 (12:00 +0100)]
pick-to-branch: improve user guidance and streamline interaction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/101)

2 years agoghmerge: support stopping rebase for adaptations
Dr. David von Oheimb [Fri, 26 Nov 2021 14:21:58 +0000 (15:21 +0100)]
ghmerge: support stopping rebase for adaptations

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/102)

2 years agopick-to-branch: Allow cherry-picking multiple commits at once
Tomas Mraz [Mon, 22 Nov 2021 14:25:49 +0000 (15:25 +0100)]
pick-to-branch: Allow cherry-picking multiple commits at once

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from https://github.com/openssl/tools/pull/100)

2 years agopick-to-branch: Improve fix of behavior on failed cherry-pick
Dr. David von Oheimb [Wed, 17 Nov 2021 13:38:19 +0000 (14:38 +0100)]
pick-to-branch: Improve fix of behavior on failed cherry-pick

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/99)

2 years agopick-to-branch: make sure that local branch is up-to-date
Dr. David von Oheimb [Mon, 8 Nov 2021 11:52:31 +0000 (12:52 +0100)]
pick-to-branch: make sure that local branch is up-to-date

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/98)

2 years agopick-to-branch: revert cherry-pick if aborted by user
Dr. David von Oheimb [Mon, 8 Nov 2021 11:46:35 +0000 (12:46 +0100)]
pick-to-branch: revert cherry-pick if aborted by user

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/98)

2 years agoghmerge: restore to original commit HEAD of target on error/abort
Dr. David von Oheimb [Mon, 22 Nov 2021 12:37:50 +0000 (13:37 +0100)]
ghmerge: restore to original commit HEAD of target on error/abort

Also add an empty line before the git log output for readability.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/97)

2 years agoghmerge: correct assignment to WORK_USED
Dr. David von Oheimb [Mon, 22 Nov 2021 11:52:44 +0000 (12:52 +0100)]
ghmerge: correct assignment to WORK_USED

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/97)

2 years agoghmerge: Rename --ref to --target for clarity
Dr. David von Oheimb [Mon, 22 Nov 2021 11:31:18 +0000 (12:31 +0100)]
ghmerge: Rename --ref to --target for clarity

We are keeping --ref for backward compat.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/97)

2 years agoghmerge: extend --cherry-pick with the number of commits to pick
Dr. David von Oheimb [Wed, 17 Nov 2021 13:14:36 +0000 (14:14 +0100)]
ghmerge: extend --cherry-pick with the number of commits to pick

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/97)

2 years agoghmerge: Fix behavior on failed cherry-pick, rebase, and pull
Dr. David von Oheimb [Mon, 25 Oct 2021 12:45:17 +0000 (14:45 +0200)]
ghmerge: Fix behavior on failed cherry-pick, rebase, and pull

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/97)

2 years agopick-to-branch: fix inferring the id from master branch
Tomas Mraz [Fri, 5 Nov 2021 15:51:50 +0000 (16:51 +0100)]
pick-to-branch: fix inferring the id from master branch

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from https://github.com/openssl/tools/pull/96)

2 years agoMake it more explicit how to push tags
Matt Caswell [Wed, 25 Aug 2021 08:46:14 +0000 (09:46 +0100)]
Make it more explicit how to push tags

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/90)

2 years agopick-to-branch: Further improve user guidance on commit id
Dr. David von Oheimb [Mon, 25 Oct 2021 08:01:19 +0000 (10:01 +0200)]
pick-to-branch: Further improve user guidance on commit id

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agopick-to-branch: Fix behavior on failed cherry-pick
Dr. David von Oheimb [Mon, 25 Oct 2021 07:47:18 +0000 (09:47 +0200)]
pick-to-branch: Fix behavior on failed cherry-pick

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agopick-to-branch: Improve diagnostics on bad target branch
Dr. David von Oheimb [Mon, 25 Oct 2021 07:36:51 +0000 (09:36 +0200)]
pick-to-branch: Improve diagnostics on bad target branch

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agopick-to-branch: Fix the case that commit id is derived from HEAD of master
Dr. David von Oheimb [Sat, 23 Oct 2021 11:10:41 +0000 (13:10 +0200)]
pick-to-branch: Fix the case that commit id is derived from HEAD of master

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agopick-to-branch: Preserve current branch and its state if it is not the target
Dr. David von Oheimb [Sat, 23 Oct 2021 10:49:30 +0000 (12:49 +0200)]
pick-to-branch: Preserve current branch and its state if it is not the target

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agopick-to-branch: Improve user guidance
Dr. David von Oheimb [Sat, 23 Oct 2021 10:32:35 +0000 (12:32 +0200)]
pick-to-branch: Improve user guidance

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/95)

2 years agoghmerge: Avoid checking out ref branch if not needed
Dr. David von Oheimb [Thu, 7 Oct 2021 14:00:40 +0000 (16:00 +0200)]
ghmerge: Avoid checking out ref branch if not needed

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/94)

2 years agoghmerge: Improve robustness and clarity regarding which ref branch is used
Dr. David von Oheimb [Thu, 7 Oct 2021 13:54:44 +0000 (15:54 +0200)]
ghmerge: Improve robustness and clarity regarding which ref branch is used

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/94)

2 years agoghmerge: Correct saving and restoring original state
Dr. David von Oheimb [Thu, 7 Oct 2021 13:43:21 +0000 (15:43 +0200)]
ghmerge: Correct saving and restoring original state

Also properly catch the error that copy-of-... already exists

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/94)

2 years agoRemove run-checker completely as it is not used anymore
Tomas Mraz [Thu, 2 Sep 2021 12:04:36 +0000 (14:04 +0200)]
Remove run-checker completely as it is not used anymore

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/93)

2 years agorun-checker: remove the fuzzing builds
Pauli [Fri, 27 Aug 2021 04:25:14 +0000 (14:25 +1000)]
run-checker: remove the fuzzing builds

Not to be merged until after openssl/openssl#16438 is merged and working.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/91)

2 years agoUpdate tools scripts to know about 3.0
Pauli [Tue, 31 Aug 2021 23:08:21 +0000 (09:08 +1000)]
Update tools scripts to know about 3.0

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/92)

2 years agoSend release emails from the owner of the signing key
Matt Caswell [Fri, 21 May 2021 09:18:18 +0000 (10:18 +0100)]
Send release emails from the owner of the signing key

Announcement emails should be sent from the email account of the owner of
the signing key, otherwise some email clients will fail to verify the key
correctly.

A longer term solution will be to have a separate release signing key.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/89)

2 years agorun-checker: reduce the number of builds
Pauli [Wed, 12 May 2021 01:25:35 +0000 (11:25 +1000)]
run-checker: reduce the number of builds

With the addition of most run-checker jobs to GitHub Actions, there is no need
to continue running these jobs ourselves.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/87)

3 years agorun-checker: add more builds with FIPS enabled and other disabled.
Pauli [Sat, 1 May 2021 03:47:11 +0000 (13:47 +1000)]
run-checker: add more builds with FIPS enabled and other disabled.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/85)

3 years agorun-checker: disable debug flag for builds
Pauli [Tue, 4 May 2021 08:14:32 +0000 (18:14 +1000)]
run-checker: disable debug flag for builds

It is more representative of reality.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/tools/pull/86)

3 years agoAdd additional run-checker no-XXX options.
Pauli [Thu, 29 Apr 2021 23:56:39 +0000 (09:56 +1000)]
Add additional run-checker no-XXX options.

There were a number of options missing:

    no-autoload-config
    no-buildtest-c++
    no-bulk
    no-cmp
    no-ktls
    no-module
    no-padlockeng
    no-pinshared
    no-secure-memory
    no-siv
    no-uplink
    enable-acvp-tests
    enable-fips
    enable-fips no-fips-securitychecks

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/84)

3 years agoghmerge: Rebase PR on top of master
Tomas Mraz [Wed, 28 Apr 2021 09:24:42 +0000 (11:24 +0200)]
ghmerge: Rebase PR on top of master

ghmerge rebased the newer commits from master on top of PR first
which does not do much sense. Do it the other way around.

Also allow fixing eventual trivial rebase conflicts in the
background.

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/tools/pull/83)

3 years agorelease-tools: Separate do-release.pl docs from mkrelease.pl docs
Richard Levitte [Tue, 17 Nov 2020 10:28:23 +0000 (11:28 +0100)]
release-tools: Separate do-release.pl docs from mkrelease.pl docs

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/74)

3 years agoNew releasing instructions, HOWTO-make-a-release.md
Richard Levitte [Tue, 17 Nov 2020 10:53:30 +0000 (11:53 +0100)]
New releasing instructions, HOWTO-make-a-release.md

README.md in $TOOLS/release-tools/ isn't obvious to discover.  It has
also aged considerably, at least in terms of OpenSSL 3.0, so needs a
serious update.

Co-authored-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/75)

3 years agoAdd a run-checker job that uses the no-cached-fetch option.
Pauli [Wed, 10 Feb 2021 12:09:19 +0000 (22:09 +1000)]
Add a run-checker job that uses the no-cached-fetch option.

This cannot be merged until after #14126 is.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/82)

3 years agoaddrev: Silence the git filter-branch warning message
Tomas Mraz [Thu, 7 Jan 2021 09:01:04 +0000 (10:01 +0100)]
addrev: Silence the git filter-branch warning message

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/tools/pull/81)

3 years agoghmerge: Pass --tools and --web to addrev
Tomas Mraz [Tue, 8 Dec 2020 15:51:04 +0000 (16:51 +0100)]
ghmerge: Pass --tools and --web to addrev

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from https://github.com/openssl/tools/pull/80)

3 years agoAdd a check for no-legacy to run-checker
Matt Caswell [Wed, 2 Dec 2020 13:32:58 +0000 (13:32 +0000)]
Add a check for no-legacy to run-checker

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/tools/pull/78)

3 years agoaddrev: Remove tabs by space chars
Dr. David von Oheimb [Thu, 3 Dec 2020 12:59:25 +0000 (13:59 +0100)]
addrev: Remove tabs by space chars

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/79)

3 years agoaddrev: Fix regression on parsing bare prnum; correct help output
Dr. David von Oheimb [Thu, 3 Dec 2020 11:55:19 +0000 (12:55 +0100)]
addrev: Fix regression on parsing bare prnum; correct help output

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/79)

3 years agoghmerge: Make pulling the latest REMOTE/REF work als for non-default REF
Dr. David von Oheimb [Wed, 2 Dec 2020 16:22:14 +0000 (17:22 +0100)]
ghmerge: Make pulling the latest REMOTE/REF work als for non-default REF

This avoids potential git errors such as:

You asked to pull from the remote 'upstream', but did not specify
a branch. Because this is not the default configured remote
for your current branch, you must specify a branch on the command line.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/79)

3 years agoghmerge: improve doc of --remote and --ref options
Dr. David von Oheimb [Thu, 19 Nov 2020 10:21:04 +0000 (11:21 +0100)]
ghmerge: improve doc of --remote and --ref options

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/79)

3 years agoaddrev: re-enable use of singe-character review names
Dr. David von Oheimb [Thu, 19 Nov 2020 09:35:28 +0000 (10:35 +0100)]
addrev: re-enable use of singe-character review names

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/79)

3 years agoEnsure sanitizer builds use no-asm
Matt Caswell [Tue, 1 Dec 2020 14:49:50 +0000 (14:49 +0000)]
Ensure sanitizer builds use no-asm

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/77)

3 years agoFix regression from latest addrev change
Tomas Mraz [Wed, 18 Nov 2020 15:48:48 +0000 (16:48 +0100)]
Fix regression from latest addrev change

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/tools/pull/76)

3 years agoAdd a note about closing the github advisory
Matt Caswell [Tue, 21 Apr 2020 14:29:24 +0000 (15:29 +0100)]
Add a note about closing the github advisory

If we've used a private github fork then we should close the advisory
and fork after the release is done.

Reviewed-by: Mark J. Cox <mark@awe.com>
(Merged from https://github.com/openssl/tools/pull/65)

3 years ago[run-checker]: default to 4 parallel test jobs
Nicola Tuveri [Thu, 2 Jul 2020 14:25:56 +0000 (17:25 +0300)]
[run-checker]: default to 4 parallel test jobs

<https://github.com/openssl/openssl/pull/12326> added support for
running the tests in parallel. The default is still to run them
sequentially.

This alters run-checker so that it defaults to 4 test jobs in parallel,
which seems a safe assumption given we are already using 4 building
jobs.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/tools/pull/71)