addrev: Improve flexibility providing reviewer names vs. commit refs (filter args)

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/72)

diff --git a/review-tools/addrev b/review-tools/addrev
index 5617199027cc43a1d90a7445709cfce5813b9e1d..e0128d9f48342c22a433df1b74af1ef8dd387efd 100755 (executable)
--- a/review-tools/addrev
+++ b/review-tools/addrev
@@ -14,8 +14,14 @@ my $useself = 1;
 my $my_email;
 
 foreach (@ARGV) {
-    if (/^[a-z]+$/ || /^\@\w(?:[-\w]*\w)?$/) {
+    if (/^\@.+$/) {
         $args .= "--reviewer=$_ ";
+    } elsif (/^[-\w]+$/) {
+        if (/^[0-9a-f]{7,}+/) {
+            $filterargs = "$_";
+        } else {
+            $args .= "--reviewer=$_ ";
+        }
     } elsif (/^--reviewer=(.+)$/) {
         $args .= "--reviewer=$1 ";
     } elsif (/^--rmreviewers$/) {
@@ -98,7 +104,7 @@ option style arguments:
 
 non-option style arguments can be:
 
-a string of lower case letters, denoting a reviewer name.
+a string of alphanumeric or '-' characters, denoting a reviewer name.
 
 a string starting with \@, denoting a reviewer's github ID.