From adf87b2df5bb8038f12947cdc97e2eaa52eb6e8b Mon Sep 17 00:00:00 2001 From: "Dr. Stephen Henson" Date: Thu, 11 Jan 2001 23:24:28 +0000 Subject: [PATCH 1/1] Fix typo in OCSP ASN1 module, this caused invalid format in OCSP request signatures. Add spaces to OCSP HTTP header. Change X509_NAME_set() there's no reason why it should return an error if the destination points to NULL... though it should if the destination is NULL. --- crypto/asn1/x_name.c | 2 +- crypto/ocsp/ocsp_asn.c | 2 +- crypto/ocsp/ocsp_ht.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/asn1/x_name.c b/crypto/asn1/x_name.c index 5da0669492..60b067611c 100644 --- a/crypto/asn1/x_name.c +++ b/crypto/asn1/x_name.c @@ -245,7 +245,7 @@ int X509_NAME_set(X509_NAME **xn, X509_NAME *name) { X509_NAME *in; - if (*xn == NULL) return(0); + if (!xn || !name) return(0); if (*xn != name) { diff --git a/crypto/ocsp/ocsp_asn.c b/crypto/ocsp/ocsp_asn.c index cfe3118dc7..0616b0ebe5 100644 --- a/crypto/ocsp/ocsp_asn.c +++ b/crypto/ocsp/ocsp_asn.c @@ -62,7 +62,7 @@ ASN1_SEQUENCE(OCSP_SIGNATURE) = { ASN1_SIMPLE(OCSP_SIGNATURE, signatureAlgorithm, X509_ALGOR), ASN1_SIMPLE(OCSP_SIGNATURE, signature, ASN1_BIT_STRING), - ASN1_SEQUENCE_OF(OCSP_SIGNATURE, certs, X509) + ASN1_EXP_SEQUENCE_OF(OCSP_SIGNATURE, certs, X509, 0) } ASN1_SEQUENCE_END(OCSP_SIGNATURE); IMPLEMENT_ASN1_FUNCTIONS(OCSP_SIGNATURE) diff --git a/crypto/ocsp/ocsp_ht.c b/crypto/ocsp/ocsp_ht.c index 58774b3f46..a0fd825dbf 100644 --- a/crypto/ocsp/ocsp_ht.c +++ b/crypto/ocsp/ocsp_ht.c @@ -80,8 +80,8 @@ OCSP_RESPONSE *OCSP_sendreq_bio(BIO *b, char *path, OCSP_REQUEST *req) int len, retcode; static char req_txt[] = "POST %s HTTP/1.0\r\n\ -Content-Type:application/ocsp-request\r\n\ -Content-length: %d\r\n\r\n"; +Content-Type: application/ocsp-request\r\n\ +Content-Length: %d\r\n\r\n"; len = i2d_OCSP_REQUEST(req, NULL); if(BIO_printf(b, req_txt, path, len) < 0) { -- 2.34.1