Fix a merge mistake in engne_list_add

master version increments the struct_ref early and needs to decrement the struct_ref on error, while 3.1 and 3.0 increment the struct_ref later. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #22115)
openssl · Sep 15, 2023 · bb67dff · bb67dff
1 parent 5b7167a
commit bb67dff
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/crypto/engine/eng_list.c b/crypto/engine/eng_list.c
@@ -82,7 +82,6 @@ static int engine_list_add(ENGINE *e)
          * The first time the list allocates, we should register the cleanup.
          */
         if (!engine_cleanup_add_last(engine_list_cleanup)) {
-            CRYPTO_DOWN_REF(&e->struct_ref, &ref);
             ERR_raise(ERR_LIB_ENGINE, ENGINE_R_INTERNAL_LIST_ERROR);
             return 0;
         }