openssl.git
3 years agoCorrecting typo that causes make install fail
Coty Sutherland [Fri, 1 Apr 2016 18:20:11 +0000 (14:20 -0400)]
Correcting typo that causes make install fail

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoAdd the C macro NDEBUG when configuring for release
Richard Levitte [Fri, 1 Apr 2016 14:03:46 +0000 (16:03 +0200)]
Add the C macro NDEBUG when configuring for release

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoForce argv to be an array of long pointers on VMS
Richard Levitte [Fri, 1 Apr 2016 10:36:51 +0000 (12:36 +0200)]
Force argv to be an array of long pointers on VMS

Reverts commit 087ca80ad83071dde0bb6bc1c28c743caa00eaf8

Instead of battling the odd format of argv given to main() in default
P64 mode, tell the compiler to make it an array of 64-bit pointers
when compiling in P64 mode.

A note is added in NOTES.VMS regarding minimum DEC C version.

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoMake the use of perl more consistent
Richard Levitte [Thu, 31 Mar 2016 07:27:15 +0000 (09:27 +0200)]
Make the use of perl more consistent

- In Configure, register the perl interpreter used to run Configure,
  so that's the one being used throughout instead of something else
  that Configure happens to find.  This is helpful for using a perl
  version that's not necessarely first in $PATH:

    /opt/perl/5.22.1/bin/perl ./Configure

- Make apps/tsget a generated file, just like apps/CA.pl, so the
  perl interpreter registered by Configure becomes the hashbang path
  instead of a hardcoded /usr/bin/perl

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoUse return "" not set a var and return.
Rich Salz [Tue, 22 Mar 2016 14:52:13 +0000 (10:52 -0400)]
Use return "" not set a var and return.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agocrypto/blake2: make lowest-level function handle multiple blocks..
Andy Polyakov [Sun, 13 Mar 2016 21:19:53 +0000 (22:19 +0100)]
crypto/blake2: make lowest-level function handle multiple blocks..

This minimizes inter-block overhead. Performance gain naturally
varies from case to case, up to 10% was spotted so far. There is
one thing to recognize, given same circumstances gain would be
higher faster computational part is. Or in other words biggest
improvement coefficient would have been observed with assembly.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoOpenSSL::Test: have cmdstr() return the true command.
Richard Levitte [Thu, 31 Mar 2016 13:08:34 +0000 (15:08 +0200)]
OpenSSL::Test: have cmdstr() return the true command.

On the other hand, have run() display the display variant.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoWhen looking for executables, don't forget the extension
Richard Levitte [Thu, 31 Mar 2016 13:02:02 +0000 (15:02 +0200)]
When looking for executables, don't forget the extension

Because some operating systems have executable extensions, typically
".exe", we need to append it when looking for files in test() and
app() (or rather, their subroutines).

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoRT4458: Fix #ifndef line for GOST
Pauli [Mon, 21 Mar 2016 23:16:36 +0000 (09:16 +1000)]
RT4458: Fix #ifndef line for GOST

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoFix "no-ui" configuration
Richard Levitte [Mon, 21 Mar 2016 17:08:57 +0000 (18:08 +0100)]
Fix "no-ui" configuration

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoMake the '-in' option in apps/passwd.c less mandatory
Richard Levitte [Thu, 31 Mar 2016 06:29:39 +0000 (08:29 +0200)]
Make the '-in' option in apps/passwd.c less mandatory

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoRemove the CRYPTO_mem_leaks adjustment for the BIO
Matt Caswell [Wed, 30 Mar 2016 17:12:59 +0000 (18:12 +0100)]
Remove the CRYPTO_mem_leaks adjustment for the BIO

CRYPTO_mem_leaks attempts to adjust the count of bytes leaks to not
include the BIO that is being used to print the results out. However this
does not work properly. In all internal cases we switch off recording
the memory allocation during creation of the BIO so it makes no difference.
In other cases if the BIO allocates any additional memory during
construction then the adjustment will be wrong anyway. It also skips over
the BIO memory during print_leak anyway, so the BIO memory is never
added into the total. In other words this was broken in lots of ways and
has been since it was first added.

The simplest solution is just to make it the documented behaviour that
you must turn off memory logging when creating the BIO, and remove all
the adjustment stuff completely. The adjustment code was only ever in
master and never made it to a release branch so there is no loss of
functionality.

This commit also fixes a compilation failure when using
enable-crypto-mdebug.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFix buffer overrun in ASN1_parse().
Ben Laurie [Tue, 29 Mar 2016 18:37:57 +0000 (19:37 +0100)]
Fix buffer overrun in ASN1_parse().

Fix buffer overrun in asn1_get_length().

Reproducer: asn1parse-reproduce crash-6bfd417f47bc940f6984f5e639b637fd4e6074bc

Fix length calculations.

Reproducer: asn1parse-reproduce crash-1819d0e54cd2b0430626c59053e6077ef04c2ffb
Reproducer: asn1parse-reproduce crash-9969db8603e644ddc0ba3459b51eac7a2c4b729b

Make i long.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFix pointer size issues with argv on VMS
Richard Levitte [Wed, 30 Mar 2016 06:35:18 +0000 (08:35 +0200)]
Fix pointer size issues with argv on VMS

The argument 'argv' in 'main' is a short pointer to a short pointer on
VMS, regardless of initial pointer size.  We must therefore make sure
that 'copy_argv' gets a 32-bit pointer for argv, and that the copied
argv is used for the rest of main().

This introduces the local type argv_t, which will have correct pointer
size in all cases (and be harmless on all other platforms) as well as
the macro Argv, which is defined as 'copied_argv' or 'argv', as the
case may be.

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoFix pointer size issue with setbuf() on VMS
Richard Levitte [Wed, 30 Mar 2016 06:32:19 +0000 (08:32 +0200)]
Fix pointer size issue with setbuf() on VMS

setbuf() is only for 32-bit pointers.  If compiled with /POINTER_SIZE=64,
we get a nasty warning about possible loss of data.  However, since
the only pointer used in the call is a FILE *, and the C RTL shouldn't
give us a pointer above the first 4GB, it's safe to turn off the
warning for this call.

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoFix pointer size issues on VMS
Richard Levitte [Wed, 30 Mar 2016 04:40:37 +0000 (06:40 +0200)]
Fix pointer size issues on VMS

On VMS, the C compiler can work with 32-bit and 64-bit pointers, and
the command line determines what the initial pointer size shall be.

However, there is some functionality that only works with 32-bit
pointers.  In this case, it's gethostbyname(), getservbyname() and
accompanying structures, so we need to make sure that we define our
own pointers as 32-bit ones.

Furthermore, there seems to be a bug in VMS C netdb.h, where struct
addrinfo is always defined with 32-bit pointers no matter what, but
the functions handling it are adapted to the initial pointer size.
This leads to pointer size warnings when compiling with
/POINTER_SIZE=64.  The workaround is to force struct addrinfo to be
the 64-bit variant if the initial pointer size is 64.

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoRearrange the use of 'proto' in BIO_lookup
Richard Levitte [Wed, 30 Mar 2016 16:18:24 +0000 (18:18 +0200)]
Rearrange the use of 'proto' in BIO_lookup

'proto' wasn't properly used as a fallback in all appropriate cases.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoWhen verbosity is requested, OpenSSL::Test::run() displays the command
Richard Levitte [Tue, 29 Mar 2016 17:43:33 +0000 (19:43 +0200)]
When verbosity is requested, OpenSSL::Test::run() displays the command

It displays the command's exit code as well.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoHave OpenSsl..Test::app() and friends look for file in source as well
Richard Levitte [Tue, 29 Mar 2016 17:41:20 +0000 (19:41 +0200)]
Have OpenSsl..Test::app() and friends look for file in source as well

If the command file that app(), test(), perlapp(9 and perltest() are
looking for doesn't exist in the build tree, look for it in the source
tree as well.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoSince OpenSSL::Test redirects stderr to /dev/null, don't do so in 80-test_ca.t
Richard Levitte [Tue, 29 Mar 2016 17:38:30 +0000 (19:38 +0200)]
Since OpenSSL::Test redirects stderr to /dev/null, don't do so in 80-test_ca.t

Since OpenSSL::Test only redirects stderr to /dev/null when being run
through non-verbose test harness, this change allows the stderr output
to be displayed when verbosity is requested.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoAdd the option 'interpreter_args' to perlapps() and perltest()
Richard Levitte [Tue, 29 Mar 2016 17:36:55 +0000 (19:36 +0200)]
Add the option 'interpreter_args' to perlapps() and perltest()

The intention with that option is to allow extra flags to the perl
interpreter itself.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoRemove X509_PUBKEY lock.
Dr. Stephen Henson [Wed, 23 Mar 2016 21:04:49 +0000 (21:04 +0000)]
Remove X509_PUBKEY lock.

Cache the decoded public key when an X509_PUBKEY structure is initially
parsed so no locking is required. Ignore any decode errors.

When an application calls X509_PUBKEY_get0() subsequently it will either
get the cached key or the decode operation will be repeated which will
return an appropriate error.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoMake it legal C.
Ben Laurie [Sun, 27 Mar 2016 11:28:56 +0000 (12:28 +0100)]
Make it legal C.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoMore things that don't work together.
Ben Laurie [Sun, 27 Mar 2016 11:28:23 +0000 (12:28 +0100)]
More things that don't work together.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFix build compilation failures
Matt Caswell [Wed, 30 Mar 2016 09:59:32 +0000 (10:59 +0100)]
Fix build compilation failures

BIO_f_linebuffer() is now built by default instead of just on VMS, but
the prototype in the header was still only available on VMS.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoBreak out DllMain from crypto/cryptlib.c and use it in shared libs only
Richard Levitte [Tue, 29 Mar 2016 14:48:02 +0000 (16:48 +0200)]
Break out DllMain from crypto/cryptlib.c and use it in shared libs only

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoMake it possible to specify source files that will only be used for shared libs
Richard Levitte [Tue, 29 Mar 2016 14:45:03 +0000 (16:45 +0200)]
Make it possible to specify source files that will only be used for shared libs

There are rare cases when an object file will only be used when
building a shared library.  To enable this, we introduce
SHARED_SOURCE:

    SHARED_SOURCE[libfoo]=dllmain.c

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoAdapt bf_lbuf for opaque BIO
Richard Levitte [Tue, 29 Mar 2016 19:36:06 +0000 (21:36 +0200)]
Adapt bf_lbuf for opaque BIO

Also, have it always be built, even though it's only (currently) used
on VMS.  That will assure it will get the same changes as all others.

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years ago'make test' depends of having util/shlib-wrap.sh symlinked in build dir
Richard Levitte [Tue, 29 Mar 2016 16:55:05 +0000 (18:55 +0200)]
'make test' depends of having util/shlib-wrap.sh symlinked in build dir

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoRequire intermediate CAs to have basicConstraints CA:true.
Viktor Dukhovni [Tue, 29 Mar 2016 23:40:03 +0000 (19:40 -0400)]
Require intermediate CAs to have basicConstraints CA:true.

Previously, it was sufficient to have certSign in keyUsage when the
basicConstraints extension was missing.  That is still accepted in
a trust anchor, but is no longer accepted in an intermediate CA.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFix the zlib config option
Matt Caswell [Tue, 29 Mar 2016 22:20:32 +0000 (23:20 +0100)]
Fix the zlib config option

The zlib config option was broken by the BIO opacity changes.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoClarify the behavior of BIO_gets() a bit more
Benjamin Kaduk [Tue, 29 Mar 2016 19:56:44 +0000 (14:56 -0500)]
Clarify the behavior of BIO_gets() a bit more

The API contract is more tight than was previously documented -- the returned
string must be NUL-terminated, and the supplied buffer includes space for
the trailing NUL, so the maximum length that can be read in is reduced.

Clarify that the NUL is not included in the returned length, and fix the
spelling of "NUL-terminated" in a nearby spot.

Adjust punctuation to make a modest improvement to the grammar.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFixup SSL EX_DATA index
Todd Short [Tue, 29 Mar 2016 17:40:48 +0000 (13:40 -0400)]
Fixup SSL EX_DATA index

The SSL, SSL_CTX, and SSL_SESSION indices were being referenced
incorrectly in the "_get_ex_new_index" functions.

Remove the STORE EX_DATA index; that functionality is gone.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoConfig: The cflags in vms-alpha and vms-ia64 have to be added
Richard Levitte [Tue, 29 Mar 2016 20:06:07 +0000 (22:06 +0200)]
Config: The cflags in vms-alpha and vms-ia64 have to be added

"vms-generic" already has some values, which were discarded.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: Disable the warning MAYLOSEDATA3
Richard Levitte [Tue, 29 Mar 2016 18:18:31 +0000 (20:18 +0200)]
VMS: Disable the warning MAYLOSEDATA3

The warning MAYLOSEDATA3 is one you will always get when compiling
source that calculates the difference between two pointers with
/POINTER_SIZE=64.

The reason is quite simple, ptrdiff_t is always a 32-bit integer
regardless of pointer size, so the result of 'ptr1 - ptr2' can
potentially be larger than a 32-bit integer.  The compiler simply
warns you of that possibility.

However, we only use pointer difference within objects and strings,
all of them well within 2^32 bytes in size, so that operation is
harmless with our source, and we can therefore safely turn off that
warning.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: Harmonize the paths in openssl_startup.com with what's really installed
Richard Levitte [Tue, 29 Mar 2016 18:02:15 +0000 (20:02 +0200)]
VMS: Harmonize the paths in openssl_startup.com with what's really installed

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: Display the correct path to openssl_startup.com and openssl-utils.com
Richard Levitte [Tue, 29 Mar 2016 18:01:33 +0000 (20:01 +0200)]
VMS: Display the correct path to openssl_startup.com and openssl-utils.com

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoRT 4393: Call EC_GROUP_order_bits in priv2opt.
David Benjamin [Mon, 7 Mar 2016 14:57:58 +0000 (09:57 -0500)]
RT 4393: Call EC_GROUP_order_bits in priv2opt.

The private key is a scalar and should be sized by the order, not the
degree. See RFC 5915.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoAdd a CHANGES entry for opaque BIOs
Matt Caswell [Tue, 29 Mar 2016 15:03:08 +0000 (16:03 +0100)]
Add a CHANGES entry for opaque BIOs

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoAdd documentation for BIO functions
Matt Caswell [Tue, 29 Mar 2016 13:25:23 +0000 (14:25 +0100)]
Add documentation for BIO functions

Add the documentation for new BIO functions added as a result of
making BIO and BIO_METHOD opaque.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agomake update
Matt Caswell [Wed, 23 Mar 2016 15:05:27 +0000 (15:05 +0000)]
make update

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoMake BIO opaque
Matt Caswell [Tue, 22 Mar 2016 09:21:29 +0000 (09:21 +0000)]
Make BIO opaque

Move the the BIO_METHOD and BIO structures into internal header files,
provide appropriate accessor methods and update all internal code to use
the new accessors where appropriate.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoAdd functions for creating BIO_METHODs
Matt Caswell [Tue, 22 Mar 2016 11:34:32 +0000 (11:34 +0000)]
Add functions for creating BIO_METHODs

BIO_METHODs are soon to be opaque so we need to have functions available
to set them up.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoFix a big leak when using stack-allocated BIO items.
FdaSilvaYY [Fri, 18 Mar 2016 23:40:11 +0000 (00:40 +0100)]
Fix a big leak when using stack-allocated BIO items.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agopoly1305/asm/poly1305-x86.pl: don't loose 59-th bit.
Andy Polyakov [Sun, 20 Mar 2016 20:52:54 +0000 (21:52 +0100)]
poly1305/asm/poly1305-x86.pl: don't loose 59-th bit.

RT#4439

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
3 years agocrypto/seed: add small-footprint path.
Andy Polyakov [Mon, 21 Mar 2016 19:06:23 +0000 (20:06 +0100)]
crypto/seed: add small-footprint path.

The space saving is >5x on x86_64 at ~40% performance penalty.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoWindows build system: fix 32-bit appveyor build.
Andy Polyakov [Wed, 23 Mar 2016 20:04:22 +0000 (21:04 +0100)]
Windows build system: fix 32-bit appveyor build.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoBuild system: VC-WIN64I fixups.
Andy Polyakov [Wed, 23 Mar 2016 19:33:29 +0000 (20:33 +0100)]
Build system: VC-WIN64I fixups.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoWhen using no-dtls create OPENSSL_NO_DTLS
Kurt Roeckx [Sun, 27 Mar 2016 22:31:23 +0000 (00:31 +0200)]
When using no-dtls create OPENSSL_NO_DTLS

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
MR: #2452

3 years agoAdd session reuse tests.
Kurt Roeckx [Sun, 27 Mar 2016 18:53:01 +0000 (20:53 +0200)]
Add session reuse tests.

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
MR: #2452

3 years agoResolve DTLS cookie and version before session resumption.
David Benjamin [Sun, 6 Mar 2016 05:19:59 +0000 (00:19 -0500)]
Resolve DTLS cookie and version before session resumption.

Session resumption involves a version check, so version negotiation must
happen first. Currently, the DTLS implementation cannot do session
resumption in DTLS 1.0 because the ssl_version check always checks
against 1.2.

Switching the order also removes the need to fixup ssl_version in DTLS
version negotiation.

Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
RT: #4392, MR: #2452

3 years agoIt's called SSL_session_reused(), not SSL_session_resumed()
Kurt Roeckx [Sun, 27 Mar 2016 18:52:03 +0000 (20:52 +0200)]
It's called SSL_session_reused(), not SSL_session_resumed()

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
MR: #2452

3 years agoAllow different protocol version when trying to reuse a session
Fedor Indutny [Fri, 11 Mar 2016 14:44:01 +0000 (17:44 +0300)]
Allow different protocol version when trying to reuse a session

We now send the highest supported version by the client, even if the session
uses an older version.

This fixes 2 problems:
- When you try to reuse a session but the other side doesn't reuse it and
  uses a different protocol version the connection will fail.
- When you're trying to reuse a session with an old version you might be
  stuck trying to reuse the old version while both sides support a newer
  version

Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
GH: #852, MR: #2452

3 years agoMath::BigInt does floored divs, BN_div does truncated div, compensate
Richard Levitte [Fri, 25 Mar 2016 23:07:50 +0000 (00:07 +0100)]
Math::BigInt does floored divs, BN_div does truncated div, compensate

According to documentation, perl's Math::BigInt does floored division,
i.e. the bdiv function does 1 / -4 = -1.  OpenSSL's BN_div, as well as
bc, do truncated division, i.e. 1 / -4 = 0.

We need to compensate for that difference in test/recipes/bc.pl to
make sure to verify the bntest results under its own conditions, by
dividing the absolute values of the given numbers and fixup the
result's negativity afterwards.

Closes RT#4485

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
3 years agoRT4476: Fix some cast-alignment warnings
Jeffrey Walton [Fri, 25 Mar 2016 13:06:47 +0000 (09:06 -0400)]
RT4476: Fix some cast-alignment warnings

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoVMS: add a note about DECC$* logical names
Richard Levitte [Fri, 25 Mar 2016 07:27:35 +0000 (08:27 +0100)]
VMS: add a note about DECC$* logical names

These logical names are used to make the C RTL change certain
behaviors, sometimes to make it act more like Unix.  While they can
make life easier in some cases, they can be disruptive as well.  When
building and testing OpenSSL, the latter is the case, so we ask people
to avoid using them.

Reviewed-by: Tim Hudson <tjh@openssl.org>
3 years agoRevert part of applink/Borland commit
Rich Salz [Thu, 24 Mar 2016 20:43:19 +0000 (16:43 -0400)]
Revert part of applink/Borland commit

This allows developer to glue DLL built with VC into their application
compiled with Borland C.

Reviewed-by: Andy Polyakov <appro@openssl.org>
3 years agoMore Borland removal.
Rich Salz [Thu, 24 Mar 2016 17:36:23 +0000 (13:36 -0400)]
More Borland removal.

And thanks to Miod Vallat for the nudge about ERR_PACK :)

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoVMS: $? might be huge enough to break line length limit, so don't print it
Richard Levitte [Wed, 23 Mar 2016 23:29:31 +0000 (00:29 +0100)]
VMS: $? might be huge enough to break line length limit, so don't print it

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: install openssl.conf in OPENSSLDIR, not INSTALLTOP
Richard Levitte [Wed, 23 Mar 2016 23:29:17 +0000 (00:29 +0100)]
VMS: install openssl.conf in OPENSSLDIR, not INSTALLTOP

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: have mms ignore creation of already existing dirs
Richard Levitte [Wed, 23 Mar 2016 23:28:38 +0000 (00:28 +0100)]
VMS: have mms ignore creation of already existing dirs

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: Rethink the staging directory
Richard Levitte [Wed, 23 Mar 2016 22:08:18 +0000 (23:08 +0100)]
VMS: Rethink the staging directory

On Windows and Unix, the staging directory $(DESTDIR) can simply be
prepended to the installation directory.  An attempt was made to do
something similar on VMS, but that ended up being a half measure
solution.  Instead of that, simply use the staging directory as a
prefix under which [.OPENSSL-INSTALL] and [.OPENSSL-COMMON] will hold
the two directory trees that should end up in the directories
indicated by --prefix and --openssldir, and finish the installation
with appropriate instructions on what to do next.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoMisc fixes in VMS/openssl_startup.com.in
Richard Levitte [Wed, 23 Mar 2016 22:07:56 +0000 (23:07 +0100)]
Misc fixes in VMS/openssl_startup.com.in

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoAdjust some default installation directories
Richard Levitte [Wed, 23 Mar 2016 22:04:32 +0000 (23:04 +0100)]
Adjust some default installation directories

- on VMS, SYS$COMMON:[SSL] is already used as installation directory
  by HP SSL, so we make our default for --openssldir
  SYS$COMMON:[OPENSSL-COMMON] instead.
- Updated notes on default installation dirs fir Unix and Windows

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: update the properties of symbol search
Richard Levitte [Wed, 23 Mar 2016 18:30:31 +0000 (19:30 +0100)]
VMS: update the properties of symbol search

In this OpenSSL version, we deliver engines with lower case symbol
names.  The DSO symbol finder must be updated to allow for mixed case
symbols or it won't fine them.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoVMS: compensate for command line length limits with a logical name
Richard Levitte [Wed, 23 Mar 2016 18:27:08 +0000 (19:27 +0100)]
VMS: compensate for command line length limits with a logical name

Sometimes, you might end up with a rather long compile line due to
excessively long /INCLUDE directories.  Compensate for it by making
a temporary logical name with them and using said logical name as
/INCLUDE argument.

A note was added to NOTES.VMS regarding these limitations.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoMove dso.h to internal
Rich Salz [Wed, 23 Mar 2016 12:54:52 +0000 (08:54 -0400)]
Move dso.h to internal

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoRemove several unused undocumented functions.
Rich Salz [Tue, 22 Mar 2016 18:33:00 +0000 (14:33 -0400)]
Remove several unused undocumented functions.

Removed the following:
    DSO_bind_var, DSO_bind_var, DSO_get_default_method,
    DSO_get_loaded_filename, DSO_get_loaded_filename, DSO_get_method,
    DSO_new_method, DSO_pathbyaddr, DSO_set_default_method, DSO_set_method,
    DSO_set_name_converter, DSO_set_name_converter

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoFix error code
FdaSilvaYY [Mon, 14 Mar 2016 20:46:54 +0000 (21:46 +0100)]
Fix error code

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoSmall fixups in DSO
Richard Levitte [Wed, 23 Mar 2016 07:40:56 +0000 (08:40 +0100)]
Small fixups in DSO

- VMS configs had no dso_scheme
- Incorrect return of NULL method.

Reviewed-by: Tim Hudson <tjh@openssl.org>
3 years agoRemoved unused fields of CT_POLICY_EVAL_CTX
Rob Percival [Thu, 17 Mar 2016 20:57:24 +0000 (20:57 +0000)]
Removed unused fields of CT_POLICY_EVAL_CTX

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoCorrect another batch of typos
Alex Gaynor [Sun, 20 Mar 2016 15:51:06 +0000 (11:51 -0400)]
Correct another batch of typos

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoCheck algo_strength using SSL_STRONG_MASK
Kurt Roeckx [Sun, 21 Feb 2016 17:02:36 +0000 (18:02 +0100)]
Check algo_strength using SSL_STRONG_MASK

algo_strength contains 2 parts that need to be checked by their own.

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
MR: #2082

3 years agoremove unused references field
Dr. Stephen Henson [Tue, 22 Mar 2016 15:26:36 +0000 (15:26 +0000)]
remove unused references field

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoHave only one DSO_METHOD_openssl
Rich Salz [Tue, 22 Mar 2016 17:35:03 +0000 (13:35 -0400)]
Have only one DSO_METHOD_openssl

Instead of have every DSO_METHOD_xxx in all platforms, ensure that only
one DSO_METHOD_openssl is available on all platforms.

Reviewed-by: Tim Hudson <tjh@openssl.org>
3 years agoMake DSO opaque.
Rich Salz [Tue, 22 Mar 2016 17:16:54 +0000 (13:16 -0400)]
Make DSO opaque.

This was really easy.

Reviewed-by: Tim Hudson <tjh@openssl.org>
3 years agoMake X509_PUBKEY opaque
Dr. Stephen Henson [Tue, 22 Mar 2016 13:16:42 +0000 (13:16 +0000)]
Make X509_PUBKEY opaque

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agomove x_pubkey.c to crypto/x509
Dr. Stephen Henson [Tue, 22 Mar 2016 12:45:58 +0000 (12:45 +0000)]
move x_pubkey.c to crypto/x509

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoFix enable-zlib no-comp.
Ben Laurie [Tue, 22 Mar 2016 10:40:13 +0000 (10:40 +0000)]
Fix enable-zlib no-comp.

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoFix no-rc4.
Ben Laurie [Tue, 22 Mar 2016 02:39:36 +0000 (02:39 +0000)]
Fix no-rc4.

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoMove declaration of i into blocks where it is used.
Ben Laurie [Thu, 17 Mar 2016 18:17:27 +0000 (18:17 +0000)]
Move declaration of i into blocks where it is used.

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agosctp requires dgram.
Ben Laurie [Thu, 17 Mar 2016 18:17:03 +0000 (18:17 +0000)]
sctp requires dgram.

Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoRT4660: BIO_METHODs should be const.
David Benjamin [Sat, 19 Mar 2016 16:32:14 +0000 (12:32 -0400)]
RT4660: BIO_METHODs should be const.

BIO_new, etc., don't need a non-const BIO_METHOD. This allows all the
built-in method tables to live in .rodata.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoDowncase VMS config names
Richard Levitte [Mon, 21 Mar 2016 19:20:15 +0000 (20:20 +0100)]
Downcase VMS config names

On VMS, we downcase option names, which means that config names are
downcased as well, so they need to be downcased in the target table to
be found.

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoJust like bio_out, bio_err needs the linebuffer filter on VMS
Richard Levitte [Mon, 21 Mar 2016 17:30:30 +0000 (18:30 +0100)]
Just like bio_out, bio_err needs the linebuffer filter on VMS

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoAdds s2i function for ct_precert_poison X509 extension
Rob Percival [Mon, 21 Mar 2016 15:29:52 +0000 (15:29 +0000)]
Adds s2i function for ct_precert_poison X509 extension

Allows CONF files for certificate requests to specify that a pre-
certificate should be created (see RFC6962).

Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
3 years agoFix memory leak where fdlookup linked list is not freed during
Steven Linsell [Sun, 20 Mar 2016 23:00:13 +0000 (23:00 +0000)]
Fix memory leak where fdlookup linked list is not freed during
ASYNC_WAIT_CTX_free

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
3 years agoFix no-ts with --strict-warnings
Matt Caswell [Mon, 21 Mar 2016 16:24:30 +0000 (16:24 +0000)]
Fix no-ts with --strict-warnings

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoFix no-sock
Matt Caswell [Mon, 21 Mar 2016 15:32:40 +0000 (15:32 +0000)]
Fix no-sock

Misc fixes for no-sock

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoFix no-gost
Matt Caswell [Mon, 21 Mar 2016 15:04:08 +0000 (15:04 +0000)]
Fix no-gost

Configure had the wrong name for the no-gost option.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoDon't use hardcoded values for types
Dr. Stephen Henson [Mon, 21 Mar 2016 14:49:11 +0000 (14:49 +0000)]
Don't use hardcoded values for types

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoIn for loop values, introduce a dummy to protect against empty list
Richard Levitte [Mon, 21 Mar 2016 07:11:14 +0000 (08:11 +0100)]
In for loop values, introduce a dummy to protect against empty list

In constructions such as 'for x in $(MAKEVAR); do ...', there's the
possibility that $(MAKEVAR) is en empty value.  Some shells don't like
that, so introduce a dummy value that gets discarded:

    for x in dummy $(MAKEVAR); do
        if [ "$$x" = "dummy" ]; then continue; fi

Closes RT#4459

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoFix no-seed
Matt Caswell [Mon, 21 Mar 2016 12:00:41 +0000 (12:00 +0000)]
Fix no-seed

Fix compilation with --strict-warnings and no-seed

Reviewed-by: Rich Salz <rsalz@openssl.org>
3 years agoRemove the no-rijndael option
Matt Caswell [Mon, 21 Mar 2016 11:51:16 +0000 (11:51 +0000)]
Remove the no-rijndael option

Rijndael is an old name for AES.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
3 years agoFix no-scrypt
Matt Caswell [Mon, 21 Mar 2016 11:23:08 +0000 (11:23 +0000)]
Fix no-scrypt

Fix the evp tests when no-scrypt is used.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoSkip the CMS tests if CMS is disabled
Matt Caswell [Mon, 21 Mar 2016 11:07:14 +0000 (11:07 +0000)]
Skip the CMS tests if CMS is disabled

This fixes the no-cms compile time option.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
3 years agoFix no-dsa
Matt Caswell [Fri, 18 Mar 2016 17:43:58 +0000 (17:43 +0000)]
Fix no-dsa

Misc fixes for no-dsa.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoBuild system: VC-WIN64I fixups.
Andy Polyakov [Fri, 18 Mar 2016 14:45:52 +0000 (15:45 +0100)]
Build system: VC-WIN64I fixups.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoConfigurations/windows-makefile.tmpl: respect no-makedepend.
Andy Polyakov [Fri, 18 Mar 2016 23:05:25 +0000 (00:05 +0100)]
Configurations/windows-makefile.tmpl: respect no-makedepend.

Reviewed-by: Richard Levitte <levitte@openssl.org>
3 years agoWindows build system: get uplink right.
Andy Polyakov [Fri, 18 Mar 2016 22:31:17 +0000 (23:31 +0100)]
Windows build system: get uplink right.

Reviewed-by: Richard Levitte <levitte@openssl.org>