From: Pascal Cuoq <cuoq@trust-in-soft.com>
Date: Wed, 6 May 2015 07:55:28 +0000 (+0200)
Subject: Properly check return type of DH_compute_key()
X-Git-Tag: OpenSSL_1_1_0-pre1~455
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=d6e92c0bd6c36fc68291e79ef5753fd7f0420695;ds=sidebyside

Properly check return type of DH_compute_key()

It returns -1 on error, not 0.

Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
MR #1231
---

diff --git a/test/dhtest.c b/test/dhtest.c
index 9ce92ee392..896af851ce 100644
--- a/test/dhtest.c
+++ b/test/dhtest.c
@@ -515,9 +515,9 @@ static int run_rfc5114_tests(void)
          * Work out shared secrets using both sides and compare with expected
          * values.
          */
-        if (!DH_compute_key(Z1, dhB->pub_key, dhA))
+        if (DH_compute_key(Z1, dhB->pub_key, dhA) == -1)
             goto bad_err;
-        if (!DH_compute_key(Z2, dhA->pub_key, dhB))
+        if (DH_compute_key(Z2, dhA->pub_key, dhB) == -1)
             goto bad_err;
 
         if (memcmp(Z1, td->Z, td->Z_len))