From: Dr. Stephen Henson <steve@openssl.org>
Date: Mon, 9 Mar 2015 23:11:45 +0000 (+0000)
Subject: Fix ASN1_TYPE_cmp
X-Git-Tag: OpenSSL_1_0_1m~9
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=c982285ab63adeb473197d54d246d120bf60778b

Fix ASN1_TYPE_cmp

Fix segmentation violation when ASN1_TYPE_cmp is passed a boolean type. This
can be triggered during certificate verification so could be a DoS attack
against a client or a server enabling client authentication.

CVE-2015-0286

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/asn1/a_type.c b/crypto/asn1/a_type.c
index 4a36aff6ac..af795306b5 100644
--- a/crypto/asn1/a_type.c
+++ b/crypto/asn1/a_type.c
@@ -119,6 +119,9 @@ int ASN1_TYPE_cmp(const ASN1_TYPE *a, const ASN1_TYPE *b)
     case V_ASN1_OBJECT:
         result = OBJ_cmp(a->value.object, b->value.object);
         break;
+    case V_ASN1_BOOLEAN:
+        result = a->value.boolean - b->value.boolean;
+        break;
     case V_ASN1_NULL:
         result = 0;             /* They do not have content. */
         break;