From: Ben Laurie <ben@links.org>
Date: Thu, 10 Jul 2014 16:47:48 +0000 (+0100)
Subject: Don't clean up uninitialised EVP_CIPHER_CTX on error (CID 483259).
X-Git-Tag: master-post-reformat~587^2~7
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=c1d1b0114e9d370c30649e46182393dbfc00e20c

Don't clean up uninitialised EVP_CIPHER_CTX on error (CID 483259).
---

diff --git a/crypto/cms/cms_pwri.c b/crypto/cms/cms_pwri.c
index 8a574616d2..28f8f261a6 100644
--- a/crypto/cms/cms_pwri.c
+++ b/crypto/cms/cms_pwri.c
@@ -93,9 +93,10 @@ CMS_RecipientInfo *CMS_add0_recipient_password(CMS_ContentInfo *cms,
 	X509_ALGOR *encalg = NULL;
 	unsigned char iv[EVP_MAX_IV_LENGTH];
 	int ivlen;
+
 	env = cms_get0_enveloped(cms);
 	if (!env)
-		goto err;
+		return NULL;
 
 	if (wrap_nid <= 0)
 		wrap_nid = NID_id_alg_PWRI_KEK;