From: Konstantin Shemyak <konstantin@shemyak.com>
Date: Thu, 28 Dec 2017 21:12:59 +0000 (+0200)
Subject: Corrected 'cms' exit status when key or certificate cannot be opened
X-Git-Tag: OpenSSL_1_1_1-pre1~234
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=a032ed0a7ba3a276fe7d9880d26c0c5f2ba702c7

Corrected 'cms' exit status when key or certificate cannot be opened

Fixes #4996.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Andy Polyakov <appro@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4997)
---

diff --git a/apps/cms.c b/apps/cms.c
index 1457cabee7..6900ddfe84 100644
--- a/apps/cms.c
+++ b/apps/cms.c
@@ -921,11 +921,15 @@ int cms_main(int argc, char **argv)
             keyfile = sk_OPENSSL_STRING_value(skkeys, i);
 
             signer = load_cert(signerfile, FORMAT_PEM, "signer certificate");
-            if (signer == NULL)
+            if (signer == NULL) {
+                ret = 2;
                 goto end;
+            }
             key = load_key(keyfile, keyform, 0, passin, e, "signing key file");
-            if (key == NULL)
+            if (key == NULL) {
+                ret = 2;
                 goto end;
+            }
             for (kparam = key_first; kparam; kparam = kparam->next) {
                 if (kparam->idx == i) {
                     tflags |= CMS_KEY_PARAM;