From: Benjamin Kaduk <bkaduk@akamai.com>
Date: Mon, 1 May 2017 17:39:20 +0000 (-0500)
Subject: Remove duplicates from clang_devteam_warnings
X-Git-Tag: OpenSSL_1_1_1-pre1~1621
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=96db26919d5caff2db6340354a026f56dc6f09da;ds=sidebyside

Remove duplicates from clang_devteam_warnings

Since the clang_devteam_warnings are appended to the gcc_devteam_warnings
when strict-warnings are requested, any items present in both the gcc
and clang variables will be duplicated in the cflags used for clang builds.
Remove the extra copy from the clang-specific flags in favor of the
gcc_devteam_warnings that are used for all strict-warnings builds.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3239)
---

diff --git a/Configure b/Configure
index d23b29cb68..24dbde84ed 100755
--- a/Configure
+++ b/Configure
@@ -141,17 +141,13 @@ my $gcc_devteam_warn = "-DDEBUG_UNUSED"
 #       -Wextended-offsetof -- no, needed in CMS ASN1 code
 my $clang_devteam_warn = ""
         . " -Qunused-arguments"
-        . " -Wextra"
-        . " -Wswitch -Wswitch-default"
-        . " -Wno-unused-parameter"
+        . " -Wswitch-default"
         . " -Wno-parentheses-equality"
-        . " -Wno-missing-field-initializers"
         . " -Wno-language-extension-token"
         . " -Wno-extended-offsetof"
         . " -Wconditional-uninitialized"
         . " -Wincompatible-pointer-types-discards-qualifiers"
         . " -Wmissing-variable-declarations"
-        . " -Wundef"
         ;
 
 # This adds backtrace information to the memory leak info.  Is only used