From: Richard Levitte Date: Wed, 7 May 2003 11:38:10 +0000 (+0000) Subject: DO NOT constify RSA* in RSA_sign() and RSA_verify(), since there are function X-Git-Tag: BEN_FIPS_TEST_1~38^2~110 X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=816d78572188d76dc9f08fa00a93d0c65f64e02a;ds=sidebyside DO NOT constify RSA* in RSA_sign() and RSA_verify(), since there are function called downstream that need it to be non-const. The fact that the RSA_METHOD functions take the RSA* as a const doesn't matter, it just expresses that *they* won't touch it. PR: 602 --- diff --git a/crypto/rsa/rsa.h b/crypto/rsa/rsa.h index 84cc779d1c..12689fc22d 100644 --- a/crypto/rsa/rsa.h +++ b/crypto/rsa/rsa.h @@ -252,9 +252,9 @@ RSA *d2i_Netscape_RSA(RSA **a, const unsigned char **pp, long length, int (*cb)( /* The following 2 functions sign and verify a X509_SIG ASN1 object * inside PKCS#1 padded RSA encryption */ int RSA_sign(int type, const unsigned char *m, unsigned int m_length, - unsigned char *sigret, unsigned int *siglen, const RSA *rsa); + unsigned char *sigret, unsigned int *siglen, RSA *rsa); int RSA_verify(int type, const unsigned char *m, unsigned int m_length, - unsigned char *sigbuf, unsigned int siglen, const RSA *rsa); + unsigned char *sigbuf, unsigned int siglen, RSA *rsa); /* The following 2 function sign and verify a ASN1_OCTET_STRING * object inside PKCS#1 padded RSA encryption */ diff --git a/crypto/rsa/rsa_sign.c b/crypto/rsa/rsa_sign.c index 1d47a3139c..02eb8136b0 100644 --- a/crypto/rsa/rsa_sign.c +++ b/crypto/rsa/rsa_sign.c @@ -67,7 +67,7 @@ #define SSL_SIG_LENGTH 36 int RSA_sign(int type, const unsigned char *m, unsigned int m_len, - unsigned char *sigret, unsigned int *siglen, const RSA *rsa) + unsigned char *sigret, unsigned int *siglen, RSA *rsa) { X509_SIG sig; ASN1_TYPE parameter; @@ -143,7 +143,7 @@ int RSA_sign(int type, const unsigned char *m, unsigned int m_len, } int RSA_verify(int dtype, const unsigned char *m, unsigned int m_len, - unsigned char *sigbuf, unsigned int siglen, const RSA *rsa) + unsigned char *sigbuf, unsigned int siglen, RSA *rsa) { int i,ret=0,sigtype; unsigned char *p,*s;