From: Bodo Möller <bodo@openssl.org>
Date: Sun, 2 May 1999 04:03:22 +0000 (+0000)
Subject: Annotate a bug.
X-Git-Tag: OpenSSL_0_9_3beta1~168
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=8051996a5be1add0a935e1c60fe16c05f7b63b95;ds=sidebyside

Annotate a bug.

Submitted by:
Reviewed by:
PR:
---

diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index 154b6ada34..ccf81b8881 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -1652,7 +1652,19 @@ static int ssl3_get_client_certificate(SSL *s)
 	if (s->session->peer != NULL)
 		X509_free(s->session->peer);
 	s->session->peer=sk_X509_shift(sk);
+
+	/* FIXME: s->session->cert could be a SSL_CTX's struct cert_st!
+	 * struct cert_st is used for too many purposes.  It makes
+	 * sense to use the same structure in both SSL_CTX and SSL,
+	 * but then don't put any per-connection data in it. */
+#if 0 /* This could become a workaround, but it would still be utterly ugly */
+	if (!ssl_cert_instantiate(&s->cert, s->ctx->default_cert)) 
+		{
+		handle the error;
+		}
+#endif
 	s->session->cert->cert_chain=sk;
+
 	sk=NULL;
 
 	ret=1;