From: Dr. Stephen Henson <steve@openssl.org>
Date: Mon, 27 Feb 2012 18:45:28 +0000 (+0000)
Subject: PR: 2736
X-Git-Tag: master-post-reformat~1926
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=68a7b5ae1ed1d00df3df9d903f751d2c5abad985

PR: 2736
Reported by: Remi Gacogne <rgacogne-bugs@coredump.fr>

Preserve unused bits value in non-canonicalised ASN1_STRING structures
by using ASN1_STRING_copy which preseves flags.
---

diff --git a/crypto/asn1/x_name.c b/crypto/asn1/x_name.c
index 49be08b4da..d7c2318693 100644
--- a/crypto/asn1/x_name.c
+++ b/crypto/asn1/x_name.c
@@ -399,8 +399,7 @@ static int asn1_string_canon(ASN1_STRING *out, ASN1_STRING *in)
 	/* If type not in bitmask just copy string across */
 	if (!(ASN1_tag2bit(in->type) & ASN1_MASK_CANON))
 		{
-		out->type = in->type;
-		if (!ASN1_STRING_set(out, in->data, in->length))
+		if (!ASN1_STRING_copy(out, in))
 			return 0;
 		return 1;
 		}