From: Matt Caswell <matt@openssl.org>
Date: Thu, 22 Mar 2018 14:33:05 +0000 (+0000)
Subject: Don't write out a bad OID
X-Git-Tag: OpenSSL_1_1_1-pre4~49
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=53c9818e970fc0c22d77e19fda3b3e6f6c9e759d

Don't write out a bad OID

If we don't have OID data for an object then we should fail if we
are asked to encode the ASN.1 for that OID.

Fixes #5723

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5725)
---

diff --git a/crypto/asn1/tasn_enc.c b/crypto/asn1/tasn_enc.c
index caa48696da..8b562ba1f4 100644
--- a/crypto/asn1/tasn_enc.c
+++ b/crypto/asn1/tasn_enc.c
@@ -528,6 +528,8 @@ static int asn1_ex_i2c(ASN1_VALUE **pval, unsigned char *cout, int *putype,
         otmp = (ASN1_OBJECT *)*pval;
         cont = otmp->data;
         len = otmp->length;
+        if (cont == NULL || len == 0)
+            return -1;
         break;
 
     case V_ASN1_NULL: