From: Dmitry-Me Date: Sun, 1 Jun 2014 17:30:52 +0000 (+0400) Subject: Fix wrong numbers being passed as string lengths X-Git-Tag: OpenSSL_1_0_1m~33 X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=521246e6085d5e1530c58ab8a50ce898d280ceed Fix wrong numbers being passed as string lengths Signed-off-by: Richard Levitte Reviewed-by: Matt Caswell (cherry picked from commit 0b142f022e2c5072295e00ebc11c5b707a726d74) --- diff --git a/apps/s_server.c b/apps/s_server.c index d5ac75ac7b..caba5b3af0 100644 --- a/apps/s_server.c +++ b/apps/s_server.c @@ -2642,7 +2642,7 @@ static int www_body(char *hostname, int s, unsigned char *context) /* else we have data */ if (((www == 1) && (strncmp("GET ", buf, 4) == 0)) || - ((www == 2) && (strncmp("GET /stats ", buf, 10) == 0))) { + ((www == 2) && (strncmp("GET /stats ", buf, 11) == 0))) { char *p; X509 *peer; STACK_OF(SSL_CIPHER) *sk; diff --git a/crypto/asn1/asn1_gen.c b/crypto/asn1/asn1_gen.c index aaec009f22..b71ae4841b 100644 --- a/crypto/asn1/asn1_gen.c +++ b/crypto/asn1/asn1_gen.c @@ -359,7 +359,7 @@ static int asn1_cb(const char *elem, int len, void *bitstr) arg->format = ASN1_GEN_FORMAT_UTF8; else if (!strncmp(vstart, "HEX", 3)) arg->format = ASN1_GEN_FORMAT_HEX; - else if (!strncmp(vstart, "BITLIST", 3)) + else if (!strncmp(vstart, "BITLIST", 7)) arg->format = ASN1_GEN_FORMAT_BITLIST; else { ASN1err(ASN1_F_ASN1_CB, ASN1_R_UNKOWN_FORMAT); diff --git a/crypto/asn1/asn1_par.c b/crypto/asn1/asn1_par.c index f6cd4b2b8c..a5d2da10bb 100644 --- a/crypto/asn1/asn1_par.c +++ b/crypto/asn1/asn1_par.c @@ -337,7 +337,7 @@ static int asn1_parse2(BIO *bp, const unsigned char **pp, long length, goto end; } } else { - if (BIO_write(bp, "BAD ENUMERATED", 11) <= 0) + if (BIO_write(bp, "BAD ENUMERATED", 14) <= 0) goto end; } M_ASN1_ENUMERATED_free(bs);