From: Richard Levitte <levitte@openssl.org>
Date: Wed, 20 Feb 2002 11:57:33 +0000 (+0000)
Subject: Comparing a pointer (data) with 0 using > is incorrect.  The changed
X-Git-Tag: OpenSSL_0_9_6d~20^2~155
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=4b71f63ac0de0df0ec321b0522a30e8d3e356760;hp=3adb8c385404448629465cdf02fe1431b8e0e160

Comparing a pointer (data) with 0 using > is incorrect.  The changed
comparison doesn't look right, but at least it compiles.  It would be nice
if the one who knows what this is supposed to do changed it to do it correctly
---

diff --git a/crypto/ecdsa/ecs_asn1.c b/crypto/ecdsa/ecs_asn1.c
index b3bdd4e5fb..542a987bc2 100644
--- a/crypto/ecdsa/ecs_asn1.c
+++ b/crypto/ecdsa/ecs_asn1.c
@@ -439,7 +439,9 @@ ECDSA         *ECDSA_x9_62parameters2ecdsa(const X9_62_EC_PARAMETERS *params, EC
 		if ((point = EC_POINT_new(ret->group)) == NULL) goto err;
 	}
 	else OPENSSL_ECDSA_ABORT(ECDSA_R_WRONG_FIELD_IDENTIFIER)
-	if (params->curve->seed != NULL && params->curve->seed->data > 0)
+	/* FIXME!!!  It seems like the comparison of data with 0 isn't the
+	   intended thing. */
+	if (params->curve->seed != NULL && params->curve->seed->data != 0)
 	{
 		if (ret->seed != NULL)
 			OPENSSL_free(ret->seed);