From: Pauli <paul.dale@oracle.com>
Date: Sun, 26 Apr 2020 22:58:59 +0000 (+1000)
Subject: coverity 1462562 Dereference before null check
X-Git-Tag: openssl-3.0.0-alpha2~120
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=437e36aed578f0a3213cc87b34abecb36bf1bde5

coverity 1462562 Dereference before null check

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/11651)
---

diff --git a/test/drbg_extra_test.c b/test/drbg_extra_test.c
index 8d7b8fbf8f..e7c0d77d7f 100644
--- a/test/drbg_extra_test.c
+++ b/test/drbg_extra_test.c
@@ -75,10 +75,8 @@ static int run_extra_kat(const struct drbg_extra_kat *td)
         failures++;
 
 err:
-    if (drbg != NULL) {
-        RAND_DRBG_uninstantiate(drbg);
-        RAND_DRBG_free(drbg);
-    }
+    RAND_DRBG_uninstantiate(drbg);
+    RAND_DRBG_free(drbg);
     return failures == 0;
 }