From: Ben Laurie <ben@openssl.org>
Date: Wed, 4 Apr 2007 14:35:56 +0000 (+0000)
Subject: Return an error if the serial number is badly formed. (Coverity ID 116).
X-Git-Tag: OpenSSL_0_9_8k^2~916
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=309fa55bbbc1465eb42fbe05c789a1e98c4ccb9a;hp=4b8747e44043c7f429e60eea2ba03ed2a1755463

Return an error if the serial number is badly formed. (Coverity ID 116).
---

diff --git a/apps/ca.c b/apps/ca.c
index 7666e35d54..291f16487a 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -2406,6 +2406,8 @@ static int do_revoke(X509 *x509, CA_DB *db, int type, char *value)
 		row[i]=NULL;
 	row[DB_name]=X509_NAME_oneline(X509_get_subject_name(x509),NULL,0);
 	bn = ASN1_INTEGER_to_BN(X509_get_serialNumber(x509),NULL);
+	if (!bn)
+		goto err;
 	if (BN_is_zero(bn))
 		row[DB_serial]=BUF_strdup("00");
 	else